Re: [10] RFR JDK-8191639:NPE from BasicListUI.Actions.getNextPageIndex

2017-11-29 Thread Prasanta Sadhukhan
OK. http://cr.openjdk.java.net/~psadhukhan/8191639/webrev.03/ Regards Prasanta On 11/29/2017 12:35 AM, Sergey Bylokhov wrote: On 27/11/2017 23:45, Prasanta Sadhukhan wrote: Ok. I have added the check for scrollRectToVisible() too. http://cr.openjdk.java.net/~psadhukhan/8191639/webrev.02 Sh

[10] Review Request: JDK-8191436 : ListSelectionModel.setSelectionMode() underspecified

2017-11-29 Thread Pankaj Bansal
Hi All, Please review the fix for JDK 10. Bug: https://bugs.openjdk.java.net/browse/JDK-8191436 Webrev: http://cr.openjdk.java.net/~pbansal/8191436/webrev.00/ Issue: ListSelectionModel.setSelectionMode() or JList.setSelectionMode() does not change the selection and leaves the se

Re: [10] Review Request: JDK-8191436 : ListSelectionModel.setSelectionMode() underspecified

2017-11-29 Thread Semyon Sadetsky
+1 --Semyon On 11/29/2017 04:54 AM, Pankaj Bansal wrote: Hi All, Please review the fix for JDK 10. Bug: https://bugs.openjdk.java.net/browse/JDK-8191436 Webrev: http://cr.openjdk.java.net/~pbansal/8191436/webrev.00/ Issue: Li

Re: [10] RFR JDK-8191639:NPE from BasicListUI.Actions.getNextPageIndex

2017-11-29 Thread Sergey Bylokhov
Looks fine. Two small issues should be fixed before the push. - Typo in the summary "Verifies no NPE is thrown wjen pageup/down is pressed in a JList" - "@headful" should be "* @key headful" On 29/11/2017 01:04, Prasanta Sadhukhan wrote: OK. http://cr.openjdk.java.net/~psadhukhan/8191639/web

Re: [10] Review Request: JDK-8191436 : ListSelectionModel.setSelectionMode() underspecified

2017-11-29 Thread Sergey Bylokhov
Looks fine On 29/11/2017 04:54, Pankaj Bansal wrote: Hi All, Please review the fix for JDK 10. Bug: https://bugs.openjdk.java.net/browse/JDK-8191436 Webrev: http://cr.openjdk.java.net/~pbansal/8191436/webrev.00/ Issue: ListSelectionModel.setSelectionMode() or JList.setSelectionMode() does

Re: [10] RFR JDK-8191639:NPE from BasicListUI.Actions.getNextPageIndex

2017-11-29 Thread Semyon Sadetsky
Hi Prasanta, I suggest to call list.getCellBounds() only if index != -1 since the result will be always null in that case. --Semyon On 11/29/2017 01:04 AM, Prasanta Sadhukhan wrote: OK. http://cr.openjdk.java.net/~psadhukhan/8191639/webrev.03/ Regards Prasanta On 11/29/2017 12:35 AM, Ser