[11][JDK-6303622]Use generic in Swing components like JComboBox

2018-01-25 Thread Krishna Addepalli
Hi All, Please review a fix for the Enhancement: JDK-6303622: https://bugs.openjdk.java.net/browse/JDK-6303622 Webrev: http://cr.openjdk.java.net/~kaddepalli/6303622/webrev00/ The enhancement requests to provide the generic return type for getSelectedItem() to avoid ugly casts for

Re: [11][JDK-6303622]Use generic in Swing components like JComboBox

2018-01-25 Thread Kevin Rushforth
I presume you plan to file a CSR? Have you verified that this change preserves both binary and source code compatibility? -- Kevin Krishna Addepalli wrote: Hi All, Please review a fix for the Enhancement: JDK-6303622: https://bugs.openjdk.java.net/browse/JDK-6303622 Webrev:

Re: [11] Review Request: JDK-6481195 ListSelectionListener indicates events on model.addElement after model.clear()

2018-01-25 Thread Jayathirth D V
Hi Pankaj, Please find my inputs: Test case is working properly before and after changes. But I think we should make changes in test to actually detect all failure cases properly instead of throwing RuntimeException when we hit first failure: if (numberOfEvents > 2)

Re: [11] Review Request: JDK-7007967 DefaultRowSorter: incorrect sorting due to not updating comparator cache

2018-01-25 Thread Jayathirth D V
Hello Pankaj, Please find my inputs: At line 1036 number of characters per line is more than 80, we can divide the conditions into multiple lines. 1036 if (!sorted || viewToModel.length == 0 || (lastRow - firstRow) > viewToModel.length / 10) { 1037 // We either