Re: [11] RFR:JDK-8176359: Frame#setMaximizedbounds not working properly in multi screen environments

2018-06-28 Thread Krishna Addepalli
Hi Sergey, Could you approve this webrev as per our conversation? @All, I need one more review for pushing. Thanks, Krishna From: Krishna Addepalli Sent: Friday, June 22, 2018 6:53 PM To: swing-dev@openjdk.java.net Subject: RE: [11] RFR:JDK-8176359: Frame#setMaximizedbounds n

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L&F at Hidpi

2018-06-28 Thread Sergey Bylokhov
Hi, Phil. The new webrev: http://cr.openjdk.java.net/~serb/8201552/webrev.03/ I have checked why validation of the component is necessary, when the "ancestor" is changed (I removed it, but the new validation on GC change null->non-null is equivalent). Such validation is used as a last chance

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L&F at Hidpi

2018-06-28 Thread Phil Race
2336 var newGC = (GraphicsConfiguration) oldValue; 2337 var oldGC = (GraphicsConfiguration) newValue; 2338 var newTx = newGC != null ? newGC.getDefaultTransform() : null; 2339 var oldTx = oldGC != null ? oldGC.getDefaultTransform() : null; 2340 return !Objects.equals(newTx, oldTx); var ?? I supp

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L&F at Hidpi

2018-06-28 Thread Sergey Bylokhov
On 28/06/2018 14:20, Phil Race wrote: 2336 var newGC = (GraphicsConfiguration) oldValue; 2337 var oldGC = (GraphicsConfiguration) newValue; 2338 var newTx = newGC != null ? newGC.getDefaultTransform() : null; 2339 var oldTx = oldGC != null ? oldGC.getDefaultTransform() : null; 2340 return !Obje

Re: [11] Review Request: 8201552 Ellipsis in "Classical" label in SwingSet2 demo with Windows L&F at Hidpi

2018-06-28 Thread Phil Race
On 6/28/2018 3:14 PM, Sergey Bylokhov wrote: On 28/06/2018 14:20, Phil Race wrote: 2336 var newGC = (GraphicsConfiguration) oldValue; 2337 var oldGC = (GraphicsConfiguration) newValue; 2338 var newTx = newGC != null ? newGC.getDefaultTransform() : null; 2339 var oldTx = oldGC != null ? oldGC.g