Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

Hi all, I have removed GridBagLayout() ,GridBagConstraints and author tag , moved dispose() call to EDT and changed the test name to TestCCEOnEditEvet. Please find the updated webrev http://cr.openjdk.java.net/~trebari/swing/8190763/webrev2/

Re: [14] RFR JDK-8233696:[TESTBUG]Some jtreg tests fail when CAPS_LOCK is ON

Hi, Please find updated webrev with equalsIgnoreCase(): http://cr.openjdk.java.net/~jdv/8233696/webrev.01/ Thanks, Jay From: Jayathirth Rao Sent: Monday, November 11, 2019 10:45 AM To: Sergey Bylokhov ; Phil Race Cc: awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject:

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

dispose is called from createTextArea when CCE is thrown so ideally the EDT should be inside dispose() function. I guess it will be clean if you remove dispose() from CCE and add frame.dispose() under try-finally clause in main() itself. I guess frame.setIconImage() also is not needed. Also,

Re: [14] RFR JDK-8233696:[TESTBUG]Some jtreg tests fail when CAPS_LOCK is ON

On 11/10/19 9:15 pm, Jayathirth Rao wrote: Hi Sergey, I tested with get and setLockingKeyState() and it is not supported in all platforms. I got UnsupportedOperationException in Linux and MacOS in our internal test CI system. But on platforms where it is supported, we can use it. Also

Re: [8u] RFR: 8225505: ctrl-F1 does not show the tooltip of a menu item (JMenuItems)

On 11/11/2019 05:17 PM, Hohensee, Paul wrote: Looks fine. Thanks for the review! I added 8u fix request for this issue. Paul On 11/11/19, 5:47 AM, "jdk8u-dev on behalf of Alex Kashchenko" wrote: Hi, Please review the backport of JDK-8225505 to 8u: Bug:

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

Looks good to me   -Pankaj   From: Prasanta Sadhukhan Sent: Tuesday, November 12, 2019 11:30 AM To: Tejpal Rebari; Pankaj Bansal Cc: swing-dev@openjdk.java.net Subject: Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()   Please remove ununsed

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

Please remove ununsed imports from the test(no need for new webrev for me), other than that, looks ok to me. Regards Prasanta On 12-Nov-19 11:24 AM, Tejpal Rebari wrote: Hi Prasanta, I have added try-finally in the main and called frame.dispose from finally clause. Please find the updated

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

Hi Prasanta, I have added try-finally in the main and called frame.dispose from finally clause. Please find the updated webrev http://cr.openjdk.java.net/~trebari/swing/8190763/webrev3/ Regards Tejpal > On 11-Nov-2019, at 4:34 PM,