Re: Minor copy/paste issue in BasicScrollBarUI ?
This code snippet is part of the enhancement that has been added to
support Nimbus L&F. It seems to be a bug as it is like this from initial
commit for the enhancement.
You can raise a bug for this in JBS.
Regards
Prasanta
On 21-May-20 9:07 PM, Vicne wrote:
Hi,
I came across the following code in
javax.swing.plaf.basic.BasicScrollBarUI.installDefaults() :
if ("large".equals(scaleKey)){
scrollBarWidth *= 1.15;
incrGap *= 1.15;
decrGap *= 1.15;
} else if ("small".equals(scaleKey)){
scrollBarWidth *= 0.857;
incrGap *= 0.857;
* decrGap *= 0.714;*
} else if ("mini".equals(scaleKey)){
scrollBarWidth *= 0.714;
incrGap *= 0.714;
decrGap *= 0.714;
}
There is no comment indicating a reason why decrGap is multiplied by
0.714 - instead of 0.857 - in the second case, so I'd be tempted to
think it's a copy/paste error...
What do you think ?
KR,
Vicne
Minor copy/paste issue in BasicScrollBarUI ?
Hi,
I came across the following code in
javax.swing.plaf.basic.BasicScrollBarUI.installDefaults() :
if ("large".equals(scaleKey)){
scrollBarWidth *= 1.15;
incrGap *= 1.15;
decrGap *= 1.15;
} else if ("small".equals(scaleKey)){
scrollBarWidth *= 0.857;
incrGap *= 0.857;
* decrGap *= 0.714;*
} else if ("mini".equals(scaleKey)){
scrollBarWidth *= 0.714;
incrGap *= 0.714;
decrGap *= 0.714;
}
There is no comment indicating a reason why decrGap is multiplied by
0.714 - instead of 0.857 - in the second case, so I'd be tempted to
think it's a copy/paste error...
What do you think ?
KR,
Vicne
Re: RFR: 8233552: [TESTBUG] JTable Test bug7068740.java fails on MacOS
+1 Regards Prasanta On 21-May-20 6:49 PM, Pankaj Bansal wrote: Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233552 Patch: diff -r dd652a1b2a39 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt Sat May 09 09:49:08 2020 +0530 +++ b/test/jdk/ProblemList.txt Thu May 21 18:43:16 2020 +0530 @@ -860,7 +860,6 @@ javax/swing/JTree/4908142/bug4908142.java 8233550 macosx-all javax/swing/JTree/4330357/bug4330357.java 8233550 macosx-all javax/swing/JTable/7124218/SelectEditTableCell.java 8233551 macosx-all -javax/swing/JTable/7068740/bug7068740.java 8233552 macosx-all javax/swing/JSpinner/4973721/bug4973721.java 8233553 macosx-all javax/swing/JRootPane/4670486/bug4670486.java 8042381 macosx-all javax/swing/JRadioButton/ButtonGroupFocus/ButtonGroupFocusTest.java 8233555 macosx-all This test was added to the ProblemList as it was failing in nightly automated testing. Ran this test again several times and it is passing in mach5. Links are in JBS. So removing this from the problem list. Regards Pankaj
RFR: 8233552: [TESTBUG] JTable Test bug7068740.java fails on MacOS
Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233552 Patch: diff -r dd652a1b2a39 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt Sat May 09 09:49:08 2020 +0530 +++ b/test/jdk/ProblemList.txt Thu May 21 18:43:16 2020 +0530 @@ -860,7 +860,6 @@ javax/swing/JTree/4908142/bug4908142.java 8233550 macosx-all javax/swing/JTree/4330357/bug4330357.java 8233550 macosx-all javax/swing/JTable/7124218/SelectEditTableCell.java 8233551 macosx-all -javax/swing/JTable/7068740/bug7068740.java 8233552 macosx-all javax/swing/JSpinner/4973721/bug4973721.java 8233553 macosx-all javax/swing/JRootPane/4670486/bug4670486.java 8042381 macosx-all javax/swing/JRadioButton/ButtonGroupFocus/ButtonGroupFocusTest.java 8233555 macosx-all This test was added to the ProblemList as it was failing in nightly automated testing. Ran this test again several times and it is passing in mach5. Links are in JBS. So removing this from the problem list. Regards Pankaj
Re: RFR: 8233635: [TESTBUG] ProgressMonitorEscapeKeyPress.java fails on macos
Hi Prasanta, No, I did not test it explicitly on osx10.15, I don't access to one. I thought one of the mach5 machine will have it. -Pankaj On 21/05/20 1:01 PM, Prasanta Sadhukhan wrote: Hi Pankaj, It seems this issue is observed in osx10.15 as was commented by one tester. I do not see mach5 running this test on osx10.15. Did you verify in osx10.15? Regards Prasanta On 21-May-20 10:08 AM, Pankaj Bansal wrote: Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233635 Patch: diff -r dd652a1b2a39 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt Sat May 09 09:49:08 2020 +0530 +++ b/test/jdk/ProblemList.txt Thu May 21 09:59:56 2020 +0530 @@ -854,7 +854,6 @@ javax/swing/text/StyledEditorKit/4506788/bug4506788.java 8233561 macosx-all javax/swing/text/JTextComponent/6361367/bug6361367.java 8233569 macosx-all javax/swing/text/html/HTMLEditorKit/5043626/bug5043626.java 233570 macosx-all -javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java 8233635 macosx-all javax/swing/plaf/nimbus/TestNimbusOverride.java 8233559 macosx-all javax/swing/JTree/4927934/bug4927934.java 8233550 macosx-all javax/swing/JTree/4908142/bug4908142.java 8233550 macosx-all This test was added to the problemList as it was failing in nightly automated testing. Ran this test again several times and it is passing in mach5. Links are in JBS. So removing this from the problem list. Regards Pankaj
Re: RFR: 8233635: [TESTBUG] ProgressMonitorEscapeKeyPress.java fails on macos
Hi Pankaj, It seems this issue is observed in osx10.15 as was commented by one tester. I do not see mach5 running this test on osx10.15. Did you verify in osx10.15? Regards Prasanta On 21-May-20 10:08 AM, Pankaj Bansal wrote: Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233635 Patch: diff -r dd652a1b2a39 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt Sat May 09 09:49:08 2020 +0530 +++ b/test/jdk/ProblemList.txt Thu May 21 09:59:56 2020 +0530 @@ -854,7 +854,6 @@ javax/swing/text/StyledEditorKit/4506788/bug4506788.java 8233561 macosx-all javax/swing/text/JTextComponent/6361367/bug6361367.java 8233569 macosx-all javax/swing/text/html/HTMLEditorKit/5043626/bug5043626.java 233570 macosx-all -javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java 8233635 macosx-all javax/swing/plaf/nimbus/TestNimbusOverride.java 8233559 macosx-all javax/swing/JTree/4927934/bug4927934.java 8233550 macosx-all javax/swing/JTree/4908142/bug4908142.java 8233550 macosx-all This test was added to the problemList as it was failing in nightly automated testing. Ran this test again several times and it is passing in mach5. Links are in JBS. So removing this from the problem list. Regards Pankaj
