On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov wrote:
> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
>
> The fix:
> - Adds missing comments to the non-static/non-transient fields(even
> priva
On Fri, 2 Oct 2020 23:29:10 GMT, Sergey Bylokhov wrote:
>> @aivanov-jdk Can you review this?
>
> I still suggest to try the approach recommended here:
> https://mail.openjdk.java.net/pipermail/awt-dev/2020-August/016074.html
>
> On 29.05.2020 14:35, Alexey Ivanov wrote:
>> The ultimate goal of t
On Mon, 5 Oct 2020 19:49:43 GMT, Sergey Bylokhov wrote:
> While working on the JDK-8240709 I have found that the test created for
> JDK-8134947 (currently executed on macOS only)
> can fail due to memory leaks(more often if change it to be stricter). See my
> comments inline.
This pull request
On Wed, 7 Oct 2020 04:16:51 GMT, Prasanta Sadhukhan
wrote:
> Please review a test issue where the test was seen to be failing on windows
> mach5 system in hidpi mode.
> I have ran the test locally with different scale factors without reproducing
> the issue. Also, mach5 job running this
> test
Please review a test issue where the test was seen to be failing on windows
mach5 system in hidpi mode.
I have ran the test locally with different scale factors without reproducing
the issue. Also, mach5 job running this
test for several iterations works ok. So, proposing to remove the test from
On Mon, 5 Oct 2020 08:11:10 GMT, Prasanta Sadhukhan
wrote:
> This test was seen to be failing in mach5 hidpi system on windows.
> The test actually checks for the fact that popup size should be 10 pixels
> wider than the comboBox width and the popup
> should overlap the comboBox by 5 pixels (ne
On Mon, 5 Oct 2020 19:32:29 GMT, Sergey Bylokhov wrote:
>> I tried at the time of PR but unable to check as MetalRootLayout is private
>> so not able to access its methods. That is
>> why I ran all client-tier3 jtreg and jck tests, and mach5 job link is posted
>> in JBS.
>
> If the MetalRootLay
