Re: RFR: 8211999: Window positioning bugs due to overlapping GraphicsDevice bounds (Windows/HiDPI) [v4]

2020-11-10 Thread Alexander Zuev
On Wed, 28 Oct 2020 23:46:55 GMT, Sergey Bylokhov wrote: >> Hello. >> Please review the fix for jdk. >> >> Old review request: >> https://mail.openjdk.java.net/pipermail/awt-dev/2020-July/015991.html >> >> >> (Note: the fix use API available since Windows 8.1: WM_DPICHANGED, but it >> should

Re: RFR: 8211999: Window positioning bugs due to overlapping GraphicsDevice bounds (Windows/HiDPI) [v4]

2020-11-10 Thread Alexey Ivanov
On Wed, 28 Oct 2020 23:46:55 GMT, Sergey Bylokhov wrote: >> Hello. >> Please review the fix for jdk. >> >> Old review request: >> https://mail.openjdk.java.net/pipermail/awt-dev/2020-July/015991.html >> >> >> (Note: the fix use API available since Windows 8.1: WM_DPICHANGED, but it >> should

Re: RFR: 8253820: Save test images and dumps with timestamps from client sanity suite

2020-11-10 Thread Alexandre Iline
On Tue, 10 Nov 2020 18:39:58 GMT, Alexandre Iline wrote: > All screen images and xml dumps, if saved with help of the library methods, > are saved by adding a timestamp and a LAF name. This is useful when there is > some test re-execution, so all images are preserved and it is clear which > i

RFR: 8253820: Save test images and dumps with timestamps from client sanity suite

2020-11-10 Thread Alexandre Iline
All screen images and xml dumps, if saved with help of the library methods, are saved by adding a timestamp and a LAF name. This is useful when there is some test re-execution, so all images are preserved and it is clear which image happened first. - Commit messages: - Merge branc

Re: RFR: 8211999: Window positioning bugs due to overlapping GraphicsDevice bounds (Windows/HiDPI) [v4]

2020-11-10 Thread Sergey Bylokhov
On Tue, 10 Nov 2020 09:33:22 GMT, Alexey Ivanov wrote: >> Sergey Bylokhov has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 12 commits: >> >> - Update WindowSizeDifferentScreens.java >> - Update ListMultipleSelectTest.java >> - s

Re: RFR: 8211999: Window positioning bugs due to overlapping GraphicsDevice bounds (Windows/HiDPI) [v4]

2020-11-10 Thread Alexey Ivanov
On Tue, 10 Nov 2020 18:40:45 GMT, Sergey Bylokhov wrote: >> src/java.desktop/share/classes/sun/java2d/SunGraphicsEnvironment.java line >> 357: >> >>> 355: * @param config the graphics configuration which bounds are >>> requested >>> 356: * @return the bounds of the area covered by t

Re: RFR: 8211999: Window positioning bugs due to overlapping GraphicsDevice bounds (Windows/HiDPI) [v4]

2020-11-10 Thread Sergey Bylokhov
On Tue, 10 Nov 2020 19:35:58 GMT, Alexey Ivanov wrote: >> I'll fix it and also merge the master, then update the PR. > > In this case, also consider adding a space between the word and the opening > parenthesis in these _coordinates (x, y)_ and _size (w, h)_ and, probably, a > space after comm

Re: RFR: 8211999: Window positioning bugs due to overlapping GraphicsDevice bounds (Windows/HiDPI) [v5]

2020-11-10 Thread Sergey Bylokhov
> Hello. > Please review the fix for jdk. > > Old review request: > https://mail.openjdk.java.net/pipermail/awt-dev/2020-July/015991.html > > > (Note: the fix use API available since Windows 8.1: WM_DPICHANGED, but it > should be fine for > Windows 7, because it does not support different DPI f

Integrated: 8211999: Window positioning bugs due to overlapping GraphicsDevice bounds (Windows/HiDPI)

2020-11-10 Thread Sergey Bylokhov
On Sun, 27 Sep 2020 22:16:22 GMT, Sergey Bylokhov wrote: > Hello. > Please review the fix for jdk. > > Old review request: > https://mail.openjdk.java.net/pipermail/awt-dev/2020-July/015991.html > > > (Note: the fix use API available since Windows 8.1: WM_DPICHANGED, but it > should be fine f

Re: RFR: 7190978: javax/swing/JComponent/7154030/bug7154030.java fails on mac [v5]

2020-11-10 Thread Sergey Bylokhov
On Mon, 9 Nov 2020 04:04:09 GMT, Prasanta Sadhukhan wrote: >> Please review a test fix for an issue seen where robot image capture is >> wrong if screen scale factor is more, which could result in button or frame >> to move out of captured dimension of 300,300. >> Fixed by setting uiScale=1 in

Re: RFR: 8255916: [macos] javax/swing/JInternalFrame/6647340/bug6647340.java timed out [v2]

2020-11-10 Thread Sergey Bylokhov
On Tue, 10 Nov 2020 04:14:15 GMT, Prasanta Sadhukhan wrote: >> This test has failed in one of jdk nightly testing although it always passed >> locally. Made the test use robot delays, waitForIdle() to make it more >> stable and appropriate to run in slower mach5 systems and also remove the >>

Re: RFR: 4907798: MEMORY LEAK: javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper [v2]

2020-11-10 Thread Alexander Zuev
On Tue, 10 Nov 2020 02:48:19 GMT, Sergey Bylokhov wrote: >> The code block here with uninstall is called if currently installed LAF is >> not derived from BasicLAF in which case we will not have this problem in the >> first place - the only place where we are setting menuInputMap variable is >

Re: RFR: 4907798: MEMORY LEAK: javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper [v2]

2020-11-10 Thread Sergey Bylokhov
On Mon, 9 Nov 2020 12:03:11 GMT, Alexander Zuev wrote: >> 4907798: MEMORY LEAK: >> javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Test case made multiplatform a

RFR: 4916923: In MetalRootPaneUI, MetalRootLayout does not correctly calculate minimumsize

2020-11-10 Thread Sergey Bylokhov
The typo in the MetalRootLayout is fixed. The tpWidth was replaced by the tpHeight for height calculation. - Commit messages: - Initial fix Changes: https://git.openjdk.java.net/jdk/pull/1155/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1155&range=00 Issue: https:

Re: RFR: 4907798: MEMORY LEAK: javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper [v2]

2020-11-10 Thread Prasanta Sadhukhan
On Mon, 9 Nov 2020 12:03:11 GMT, Alexander Zuev wrote: >> 4907798: MEMORY LEAK: >> javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Test case made multiplatform a