RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

2020-11-12 Thread Prasanta Sadhukhan
On macOS 11 (bigsur) beta, using the Swing Aqua Look and Feel, the text of the selected JTabbedPane tab title text is just a light gray outline of white text on a white background. The macOS 11 design inverted from dark background / light text to light background / dark text, Proposed fix is to

Re: RFR: 8253820: Save test images and dumps with timestamps from client sanity suite

2020-11-12 Thread Alexandre Iline
On Tue, 10 Nov 2020 18:40:45 GMT, Alexandre Iline wrote: >> All screen images and xml dumps, if saved with help of the library methods, >> are saved by adding a timestamp and a LAF name. This is useful when there is >> some test re-execution, so all images are preserved and it is clear which

Re: RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs

2020-11-12 Thread Andy Herrick
On Mon, 9 Nov 2020 13:56:33 GMT, Andy Herrick wrote: > JDK-8189198: Add "forRemoval = true" to Applet APIs preliminary changes for JDK-8189198 for evaluation - PR: https://git.openjdk.java.net/jdk/pull/1127

RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs

2020-11-12 Thread Andy Herrick
JDK-8189198: Add "forRemoval = true" to Applet APIs - Commit messages: - Merge branch 'master' into JDK-8189198 - JDK-8189198: Add "forRemoval = true" to Applet APIs - JDK-8189198: Add "forRemoval = true" to Applet APIs - JDK-8189198: Add "forRemoval = true" to Applet APIs Change

Re: RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs

2020-11-12 Thread Kevin Rushforth
On Mon, 9 Nov 2020 13:57:32 GMT, Andy Herrick wrote: >> JDK-8189198: Add "forRemoval = true" to Applet APIs > > preliminary changes for JDK-8189198 for evaluation The following field, which is currently deprecated (not for removal) should probably also be marked as deprecated for removal:: jav

Re: RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs

2020-11-12 Thread Iris Clark
On Mon, 9 Nov 2020 13:56:33 GMT, Andy Herrick wrote: > JDK-8189198: Add "forRemoval = true" to Applet APIs Since all APIs in the java.applet package are deprecated "forRemoval = true", consider adding a brief deprecation note to java/applet/package-info.java too. As an example, when all of the

Re: RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs [v2]

2020-11-12 Thread Andy Herrick
> JDK-8189198: Add "forRemoval = true" to Applet APIs Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the las

Re: RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs [v2]

2020-11-12 Thread Alexander Matveev
On Thu, 12 Nov 2020 20:48:13 GMT, Andy Herrick wrote: >> JDK-8189198: Add "forRemoval = true" to Applet APIs > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase.

Re: RFR: JDK-8189198: Add "forRemoval = true" to Applet APIs

2020-11-12 Thread Kevin Rushforth
On Mon, 9 Nov 2020 13:56:33 GMT, Andy Herrick wrote: > JDK-8189198: Add "forRemoval = true" to Applet APIs @andyherrick can you enter the `/csr needed` command? I would, but it needs to be done by either the author of the PR or a Reviewer. - PR: https://git.openjdk.java.net/jdk/pu

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

2020-11-12 Thread Sergey Bylokhov
On Thu, 12 Nov 2020 09:58:36 GMT, Prasanta Sadhukhan wrote: > On macOS 11 (bigsur) beta, using the Swing Aqua Look and Feel, the text of > the selected JTabbedPane tab title text is just a light gray outline of white > text on a white background. The macOS 11 design inverted from dark backgrou

Re: RFR: 8253820: Save test images and dumps with timestamps from client sanity suite

2020-11-12 Thread Sergey Bylokhov
On Tue, 10 Nov 2020 18:39:58 GMT, Alexandre Iline wrote: > All screen images and xml dumps, if saved with help of the library methods, > are saved by adding a timestamp and a LAF name. This is useful when there is > some test re-execution, so all images are preserved and it is clear which > i

Integrated: 8253820: Save test images and dumps with timestamps from client sanity suite

2020-11-12 Thread Alexandre Iline
On Tue, 10 Nov 2020 18:39:58 GMT, Alexandre Iline wrote: > All screen images and xml dumps, if saved with help of the library methods, > are saved by adding a timestamp and a LAF name. This is useful when there is > some test re-execution, so all images are preserved and it is clear which > i

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

2020-11-12 Thread Prasanta Sadhukhan
On Fri, 13 Nov 2020 00:24:00 GMT, Sergey Bylokhov wrote: >> On macOS 11 (bigsur) beta, using the Swing Aqua Look and Feel, the text of >> the selected JTabbedPane tab title text is just a light gray outline of >> white text on a white background. The macOS 11 design inverted from dark >> backg

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

2020-11-12 Thread Sergey Bylokhov
On Fri, 13 Nov 2020 02:39:29 GMT, Prasanta Sadhukhan wrote: >> src/java.desktop/macosx/classes/com/apple/laf/AquaLookAndFeel.java line 332: >> >>> 330: final ColorUIResource selectedTabTitleNormalColor = >>> 331: >>> System.getProperty("os.version").contains("10