Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

2020-12-17 Thread Kevin Rushforth
On Thu, 17 Dec 2020 04:23:42 GMT, Prasanta Sadhukhan wrote: > If 1st, is there any way to integrate the 1st version without updating the > PR? No, this is not possible. If you need to integrate an earlier version, you will need to revert those changes in your local branch and push them.

Re: [jdk16] RFR: 8258373: Update the text handling in the JPasswordField

2020-12-17 Thread Prasanta Sadhukhan
On Wed, 16 Dec 2020 20:35:04 GMT, Sergey Bylokhov wrote: > - The JTextComponent.setText() is overidden in the JPasswordField to make the > "text" property non-"bound" in the JPasswordField, same as in the > JTextComponent > - The new implementation of setText() clean an internal data storage

Re: [jdk16] RFR: 8258373: Update the text handling in the JPasswordField

2020-12-17 Thread Phil Race
On Wed, 16 Dec 2020 20:35:04 GMT, Sergey Bylokhov wrote: > - The JTextComponent.setText() is overidden in the JPasswordField to make the > "text" property non-"bound" in the JPasswordField, same as in the > JTextComponent > - The new implementation of setText() clean an internal data storage

Re: [jdk16] RFR: 8258373: Update the text handling in the JPasswordField

2020-12-17 Thread Alexander Zuev
On Wed, 16 Dec 2020 20:35:04 GMT, Sergey Bylokhov wrote: > - The JTextComponent.setText() is overidden in the JPasswordField to make the > "text" property non-"bound" in the JPasswordField, same as in the > JTextComponent > - The new implementation of setText() clean an internal data storage

Re: [jdk16] RFR: 8258373: Update the text handling in the JPasswordField

2020-12-17 Thread Victor Dyakov
On Thu, 17 Dec 2020 16:36:07 GMT, Alexander Zuev wrote: >> - The JTextComponent.setText() is overidden in the JPasswordField to make >> the "text" property non-"bound" in the JPasswordField, same as in the >> JTextComponent >> - The new implementation of setText() clean an internal data

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

2020-12-17 Thread Phil Race
On Thu, 17 Dec 2020 13:02:12 GMT, Kevin Rushforth wrote: >> @prrace Did you approve the 1st version of the fix >> [https://openjdk.github.io/cr/?repo=jdk=1182=00] >> or the current (4th) version? >> If 1st, is there any way to integrate the 1st version without updating the >> PR? > >> If

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v4]

2020-12-17 Thread Sergey Bylokhov
On Thu, 10 Dec 2020 16:06:00 GMT, Tejpal Rebari wrote: >> Please review the following fix for jdk16. >> >> Issue : There is a JToggleButton that will post/take down a JPopupMenu when >> the button is selected. If the button is selected and the menu is not posted >> the action listener will

Re: [jdk16] RFR: 8258373: Update the text handling in the JPasswordField

2020-12-17 Thread Sergey Bylokhov
On Thu, 17 Dec 2020 17:19:19 GMT, Prasanta Sadhukhan wrote: >> - The JTextComponent.setText() is overidden in the JPasswordField to make >> the "text" property non-"bound" in the JPasswordField, same as in the >> JTextComponent >> - The new implementation of setText() clean an internal data

RFR: JDK-8258645: Bring Jemmy 1.3.11 to JDK test base

2020-12-17 Thread Alexandre Iline
Some changes to JSliderDemoTest: set a non-default driver and additional diagnostics - Commit messages: - JDK-8258645: Bring Jemmy 1.3.11 to JDK test base Changes: https://git.openjdk.java.net/jdk/pull/1831/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1831=00 Issue:

Re: RFR: JDK-8258645: Bring Jemmy 1.3.11 to JDK test base

2020-12-17 Thread Alexandre Iline
On Thu, 17 Dec 2020 21:45:50 GMT, Alexandre Iline wrote: > Some changes to JSliderDemoTest: set a non-default driver and additional > diagnostics @amresh-sahu @akolarkunnu , if you can take a look that would be great - PR: https://git.openjdk.java.net/jdk/pull/1831

Re: RFR: JDK-8258645: Bring Jemmy 1.3.11 to JDK test base

2020-12-17 Thread Sergey Bylokhov
On Thu, 17 Dec 2020 21:45:50 GMT, Alexandre Iline wrote: > Some changes to JSliderDemoTest: set a non-default driver and additional > diagnostics Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1831

Re: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop [v2]

2020-12-17 Thread Sergey Bylokhov
On Wed, 16 Dec 2020 17:11:53 GMT, Phil Race wrote: >> Andrey Turbanov has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains one commit: >> >> 8258006: Replace 'while' cycles with iterator with enhanced 'for' in >> java.desktop > >

Re: [jdk16] RFR: 8258373: Update the text handling in the JPasswordField

2020-12-17 Thread Prasanta Sadhukhan
On Wed, 16 Dec 2020 20:35:04 GMT, Sergey Bylokhov wrote: > - The JTextComponent.setText() is overidden in the JPasswordField to make the > "text" property non-"bound" in the JPasswordField, same as in the > JTextComponent > - The new implementation of setText() clean an internal data storage

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

2020-12-17 Thread Prasanta Sadhukhan
On Thu, 17 Dec 2020 18:03:04 GMT, Phil Race wrote: >>> If 1st, is there any way to integrate the 1st version without updating the >>> PR? >> >> No, this is not possible. If you need to integrate an earlier version, you >> will need to revert those changes in your local branch and push them.

[jdk16] Integrated: 8258373: Update the text handling in the JPasswordField

2020-12-17 Thread Sergey Bylokhov
On Wed, 16 Dec 2020 20:35:04 GMT, Sergey Bylokhov wrote: > - The JTextComponent.setText() is overidden in the JPasswordField to make the > "text" property non-"bound" in the JPasswordField, same as in the > JTextComponent > - The new implementation of setText() clean an internal data storage

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v4]

2020-12-17 Thread Tejpal Rebari
On Fri, 18 Dec 2020 00:18:22 GMT, Sergey Bylokhov wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> changed mode of files > > src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java > line

Re: RFR: 8258557: Deproblemlist fixed problemlisted test

2020-12-17 Thread Tejpal Rebari
On Thu, 17 Dec 2020 04:59:43 GMT, Prasanta Sadhukhan wrote: > javax/swing/PopupFactory/8048506/bug8048506.java was failing on windows in > nightly mach5 testing but was later fixed in JDK-6847157 but this test was > not removed from ProblemList. > We can remove this test from problemlist