Integrated: 8259650: javax/swing/JComponent/7154030/bug7154030.java still fails with "Exception: Failed to hide opaque button"

2021-01-18 Thread Alexander Zuev
On Sun, 17 Jan 2021 09:26:52 GMT, Alexander Zuev wrote: > 8259650: javax/swing/JComponent/7154030/bug7154030.java still fails with > "Exception: Failed to hide opaque button" This pull request has now been integrated. Changeset: 917f7e9a Author:Alexander Zuev URL: https://git.openjd

Re: RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

2021-01-18 Thread Alexey Ivanov
On Sat, 16 Jan 2021 00:42:45 GMT, Sergey Bylokhov wrote: >> Dear All, >> >> Hi All, Could you please review this fix for JDK17? >> >> Problem Description: The test >> open/test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java is applet based. >> >> Fix: Rewritten the above applet based test

Re: RFR: 8257664: HTMLEditorKit: Wrong CSS relative font sizes [v5]

2021-01-18 Thread Prasanta Sadhukhan
On Sat, 16 Jan 2021 06:45:35 GMT, Stanimir Stamenkov wrote: >> Fix for [JDK-8257664][] – HTMLEditorKit: Wrong CSS relative font sizes. >> >> _Disclaimer:_ I'm the reporter of the issue and I've been advised the best >> chance to get it addressed is to submit a pull request against this >> rep

Re: RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

2021-01-18 Thread Alexey Ivanov
On Mon, 18 Jan 2021 11:30:55 GMT, Alexey Ivanov wrote: >> test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java line 50: >> >>> 48: * @bug 8032667 >>> 49: * @summary [macosx] Components cannot be rendered in HiDPI to >>> BufferedImage >>> 50: * @run main bug8032667 >> >> I suggest do not c

Re: RFR: 8257664: HTMLEditorKit: Wrong CSS relative font sizes [v5]

2021-01-18 Thread Alexey Ivanov
On Sat, 16 Jan 2021 06:45:35 GMT, Stanimir Stamenkov wrote: >> Fix for [JDK-8257664][] – HTMLEditorKit: Wrong CSS relative font sizes. >> >> _Disclaimer:_ I'm the reporter of the issue and I've been advised the best >> chance to get it addressed is to submit a pull request against this >> rep

Re: RFR: 8257664: HTMLEditorKit: Wrong CSS relative font sizes [v5]

2021-01-18 Thread Alexey Ivanov
On Mon, 18 Jan 2021 12:11:33 GMT, Prasanta Sadhukhan wrote: >> Stanimir Stamenkov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixup! 8257664: Fix font-size inheritance with percentage values >> >> Declare fontSizeInherit() acce

Re: RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

2021-01-18 Thread Sergey Bylokhov
On Mon, 18 Jan 2021 12:12:10 GMT, Alexey Ivanov wrote: >> Unifying the UI makes sense in the long run. Will it involve retrofitting >> all the existing manual test which already have its own UI? >> >> In most cases, the UI in manual tests is similar: Pass / Fail buttons at the >> bottom with t

Re: RFR: JDK-8259818: [TEST_BUG] Convert applet-based test test/jdk/javax/swing/JCheckBox/8032667/bug8032667.java to a regular java

2021-01-18 Thread Alexey Ivanov
On Mon, 18 Jan 2021 12:28:07 GMT, Sergey Bylokhov wrote: >> To confirm: we're not modifying the current applet-based manual tests until >> there's a common framework to migrate them off the applet API. Do I >> understand it correctly? > > Yes, I suggest that. Maybe we can start with that replac

Re: RFR: 8257664: HTMLEditorKit: Wrong CSS relative font sizes [v5]

2021-01-18 Thread Stanimir Stamenkov
On Mon, 18 Jan 2021 12:23:27 GMT, Alexey Ivanov wrote: >> Stanimir Stamenkov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixup! 8257664: Fix font-size inheritance with percentage values >> >> Declare fontSizeInherit() accessor p

Re: RFR: 8257664: HTMLEditorKit: Wrong CSS relative font sizes [v5]

2021-01-18 Thread Alexey Ivanov
On Mon, 18 Jan 2021 12:23:27 GMT, Alexey Ivanov wrote: >> Stanimir Stamenkov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixup! 8257664: Fix font-size inheritance with percentage values >> >> Declare fontSizeInherit() accessor p

[jdk16] Integrated: 8258643: [TESTBUG] javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button"

2021-01-18 Thread Alexander Zuev
On Wed, 13 Jan 2021 22:26:47 GMT, Alexander Zuev wrote: > Backport from mainline. This pull request has now been integrated. Changeset: bb0821eb Author:Alexander Zuev URL: https://git.openjdk.java.net/jdk16/commit/bb0821eb Stats: 13 lines in 1 file changed: 2 ins; 5 del; 6 mod 8