Re: RFR: 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X

2021-04-21 Thread Sergey Bylokhov
On Wed, 21 Apr 2021 16:15:50 GMT, Alexander Zuev wrote: > Replaces usage of SunToolkit.realSync() with Robot.waitForIdle() The Robot.waitForIdle() is implemented via SunToolkit.realSync(), I am not sure how it might solve the problem. - PR:

Re: RFR: 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X

2021-04-21 Thread Sergey Bylokhov
On Wed, 21 Apr 2021 21:12:44 GMT, Alexander Zuev wrote: > It will not solve the problem as there is no problem as such. Ok, then please add this thing to the JBS. - PR: https://git.openjdk.java.net/jdk/pull/3606

Re: RFR: 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X

2021-04-21 Thread Sergey Bylokhov
On Wed, 21 Apr 2021 16:15:50 GMT, Alexander Zuev wrote: > Replaces usage of SunToolkit.realSync() with Robot.waitForIdle() test/jdk/javax/swing/JPopupMenu/7156657/bug7156657.java line 42: > 40: > 41: import sun.awt.SunToolkit; > 42: The "@modules java.desktop/sun.awt" should be removed as

Integrated: 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X

2021-04-21 Thread Alexander Zuev
On Wed, 21 Apr 2021 16:15:50 GMT, Alexander Zuev wrote: > Replaces usage of SunToolkit.realSync() with Robot.waitForIdle() This pull request has now been integrated. Changeset: ca6b1b49 Author:Alexander Zuev URL: https://git.openjdk.java.net/jdk/commit/ca6b1b49 Stats: 9 lines in

Re: RFR: 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X

2021-04-21 Thread Alexander Zuev
On Wed, 21 Apr 2021 19:43:40 GMT, Sergey Bylokhov wrote: > The Robot.waitForIdle() is implemented via SunToolkit.realSync(), I am not > sure how it might solve the problem. It will not solve the problem as there is no problem as such. Test failed twice in two years on the same machine with

Re: RFR: 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X [v2]

2021-04-21 Thread Alexander Zuev
> Replaces usage of SunToolkit.realSync() with Robot.waitForIdle() Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Remove modules clause - Changes: - all: https://git.openjdk.java.net/jdk/pull/3606/files - new:

Re: RFR: 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X [v2]

2021-04-21 Thread Alexander Zuev
On Wed, 21 Apr 2021 21:38:07 GMT, Sergey Bylokhov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove modules clause > > test/jdk/javax/swing/JPopupMenu/7156657/bug7156657.java line 42: > >> 40: >> 41:

Re: RFR: 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X [v2]

2021-04-21 Thread Sergey Bylokhov
On Wed, 21 Apr 2021 22:39:52 GMT, Alexander Zuev wrote: >> Replaces usage of SunToolkit.realSync() with Robot.waitForIdle() > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Remove modules clause Marked as reviewed by

Re: RFR: 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable [v2]

2021-04-21 Thread Prasanta Sadhukhan
On Wed, 21 Apr 2021 05:18:06 GMT, Phil Race wrote: >> No, it still fails in macosx11 without this modification. macos11, System >> .getProperty returns 10.16 so it satisfies this macosx >=10.14 condition and >> it bails out from this subtest. > > Are you sure you are up to date ? There was a

Re: RFR: 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable [v2]

2021-04-21 Thread Prasanta Sadhukhan
> This test was marked as unstable in CI run in samevm mode but later on was > found passing in now-default othervm mode but was problemlisted only on macos > by JDK-8254976. > It is found that this test started failing in macos due to JDK-8220150: > [macos] macos10.14 Mojave returns

Re: RFR: 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable [v2]

2021-04-21 Thread Phil Race
On Wed, 21 Apr 2021 11:23:02 GMT, Prasanta Sadhukhan wrote: >> This test was marked as unstable in CI run in samevm mode but later on was >> found passing in now-default othervm mode but was problemlisted only on >> macos by JDK-8254976. >> It is found that this test started failing in macos

Re: RFR: 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable [v2]

2021-04-21 Thread Phil Race
On Wed, 21 Apr 2021 11:23:02 GMT, Prasanta Sadhukhan wrote: >> This test was marked as unstable in CI run in samevm mode but later on was >> found passing in now-default othervm mode but was problemlisted only on >> macos by JDK-8254976. >> It is found that this test started failing in macos

Re: RFR: 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable [v2]

2021-04-21 Thread Prasanta Sadhukhan
On Wed, 21 Apr 2021 14:13:47 GMT, Phil Race wrote: > > > I guess this will work - until Apple come out with 12.0 when it will break > again. > I'd have preferred to see you convert the first part of the string - up to > before any 2nd decimal pt > into a float and then just do a comparison.

Integrated: 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable

2021-04-21 Thread Prasanta Sadhukhan
On Fri, 16 Apr 2021 06:53:21 GMT, Prasanta Sadhukhan wrote: > This test was marked as unstable in CI run in samevm mode but later on was > found passing in now-default othervm mode but was problemlisted only on macos > by JDK-8254976. > It is found that this test started failing in macos due

RFR: 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X

2021-04-21 Thread Alexander Zuev
Replaces usage of SunToolkit.realSync() with Robot.waitForIdle() - Commit messages: - 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X Changes: https://git.openjdk.java.net/jdk/pull/3606/files Webrev: