On Tue, 4 May 2021 21:30:12 GMT, Alexander Zuev wrote:
>> Fixed popup position taking into account its offset
>> Added a lot of screenshots taking to better understand failures should they
>> happen down the line
>
> Alexander Zuev has updated the pull request incrementally with one additional
On Tue, 4 May 2021 21:30:12 GMT, Alexander Zuev wrote:
>> Fixed popup position taking into account its offset
>> Added a lot of screenshots taking to better understand failures should they
>> happen down the line
>
> Alexander Zuev has updated the pull request incrementally with one additional
On Fri, 30 Apr 2021 20:23:21 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp
>>
>> Select one icon at a time.
>>
On Fri, 30 Apr 2021 20:54:01 GMT, Alexey Ivanov wrote:
>> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line
>> 1146:
>>
>>> 1144: }
>>> 1145: Map multiResolutionIcon = new HashMap<>();
>>> 1146: int start = size > MAX_QUALITY_ICON ?
On Fri, 7 May 2021 16:00:37 GMT, Prasanta Sadhukhan
wrote:
> I'm not sure about this change...Maybe changing frame location from (0,0) at
> l192 to middle of screen though selLocationRelativeTo() may be enough to make
> the test more stable in CI systems.
The problem here is not only in
On Fri, 30 Apr 2021 20:48:21 GMT, Alexey Ivanov wrote:
>> Getting smaller icon is relevant in the case of the scaling. I do not think
>> refactoring image caches from icons to multiresolution images will make code
>> much cleaner - at the end we will have to extract images from the
>>
> Fix updated after first round of review.
Alexander Zuev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains five additional
commits since the last
On Fri, 30 Apr 2021 20:50:53 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 64:
>>
>>> 62: }
>>> 63:
>>> 64: if (icon.getIconWidth() != size) {
>>
>> Does it make sense to check that the icon is a multi-resolution
> The current specification of these 2 methods
> api/java.desktop/javax/swing/plaf/basic/BasicSplitPaneDivider.html#getPreferredSize().
> and
> api/java.desktop/javax/swing/plaf/basic/BasicSplitPaneDivider.html#getMinimumSize()
> does not specify correct return values. Also, the spec is not very
> Fixed popup position taking into account its offset
> Added a lot of screenshots taking to better understand failures should they
> happen down the line
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Simplify popup bounds
On Fri, 30 Apr 2021 20:34:01 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp
>>
>> Select one icon at a time.
>>
11 matches
Mail list logo
