Re: Swing Dev [9] Review request for 6302464 Allow programmatic enabling of subpixel anti-aliasing in Swing

2015-08-21 Thread Sergey Bylokhov
Hi, Alexander. It seems this is only a part of the request. It does not cover some situations like java properties, which can be used to enable/set/disable anti-aliasing. Also it is unclear how and why our look and feels modify the desktop properties, this api seems private also. On 13.08.15

Re: Swing Dev [9] Review Request: 4339584 Adding a getUI public method to JComponent

2015-08-21 Thread Sergey Bylokhov
I just double checked that if I compiles the subclass when the parent class has not this method, then recompiles a new parent, the correct method in subclass still called, so it seems fine. Probably there are some other cases, which will be checked during ccc review. Could it break a binary

Re: Swing Dev [9] Review Request: 4339584 Adding a getUI public method to JComponent

2015-08-21 Thread Alexander Scherbatiy
On 8/21/2015 1:49 PM, Sergey Bylokhov wrote: I just double checked that if I compiles the subclass when the parent class has not this method, then recompiles a new parent, the correct method in subclass still called, so it seems fine. Probably there are some other cases, which will be checked

Re: Swing Dev [9] Review request for 6302464 Allow programmatic enabling of subpixel anti-aliasing in Swing

2015-08-21 Thread Alexander Scherbatiy
On 8/21/2015 2:18 PM, Sergey Bylokhov wrote: Hi, Alexander. It seems this is only a part of the request. It does not cover some situations like java properties, which can be used to enable/set/disable anti-aliasing. The awt.useSystemAAFontSettings property overrides the desktop font

Swing Dev RFR: [JDK-8025082] The behaviour of the highlight will be lost after clicking the set button

2015-08-21 Thread Rajeev Chamyal
Hi, Please review the following fix for jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-8025082 webrev: http://cr.openjdk.java.net/~psadhukhan/rajeev/8025082/webrev.00/ The highlight of selected text in JTextPane/JTextArea is lost if some other component (e.g. button clicked) gains

Re: Swing Dev [9] Review request for 6302464 Allow programmatic enabling of subpixel anti-aliasing in Swing

2015-08-21 Thread Alexander Zvegintsev
+1 Thanks, Alexander. On 08/21/2015 06:12 PM, Sergey Bylokhov wrote: On 21.08.15 16:12, Alexander Scherbatiy wrote: On 8/21/2015 2:18 PM, Sergey Bylokhov wrote: Hi, Alexander. It seems this is only a part of the request. It does not cover some situations like java properties, which can be

Re: Swing Dev [9] Review request for 6302464 Allow programmatic enabling of subpixel anti-aliasing in Swing

2015-08-21 Thread Sergey Bylokhov
On 21.08.15 16:12, Alexander Scherbatiy wrote: On 8/21/2015 2:18 PM, Sergey Bylokhov wrote: Hi, Alexander. It seems this is only a part of the request. It does not cover some situations like java properties, which can be used to enable/set/disable anti-aliasing. The

Re: Swing Dev [9] Review Request: 4339584 Adding a getUI public method to JComponent

2015-08-21 Thread Sergey Bylokhov
On 21.08.15 14:20, Alexander Scherbatiy wrote: On 8/21/2015 1:49 PM, Sergey Bylokhov wrote: I just double checked that if I compiles the subclass when the parent class has not this method, then recompiles a new parent, the correct method in subclass still called, so it seems fine. Probably

Re: Swing Dev [9] Review Request: 4339584 Adding a getUI public method to JComponent

2015-08-21 Thread Alexander Zvegintsev
+1 Thanks, Alexander. On 08/21/2015 02:41 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 8/21/2015 2:37 PM, Sergey Bylokhov wrote: On 21.08.15 14:20, Alexander Scherbatiy wrote: On 8/21/2015 1:49 PM, Sergey Bylokhov wrote: I just double checked that

Re: Swing Dev [9] Review Request: 4339584 Adding a getUI public method to JComponent

2015-08-21 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 8/21/2015 2:37 PM, Sergey Bylokhov wrote: On 21.08.15 14:20, Alexander Scherbatiy wrote: On 8/21/2015 1:49 PM, Sergey Bylokhov wrote: I just double checked that if I compiles the subclass when the parent class has not this method, then

Re: Swing Dev RfR: JDK-8133897, IndexOutOfBounds exception being thrown

2015-08-21 Thread Walter Laan
The patch just changes the AIOOB to a NPE elsewhere, for example to a method just above: public Point getLocation() { Rectangle r = getBounds(); return new Point(r.x, r.y); } Seems like the only way for the exception to happen is because removeTabAt() or

Swing Dev [9] Review Request: 4339584 Adding a getUI public method to JComponent

2015-08-21 Thread Sergey Bylokhov
Hello. Please review a small fix for jdk9. Long long time ago the next request was filed for jdk 1.4.0: Today, there is no way for a program to access the UI of a JComponent. Adding a getUI method would provide that capability and be consistent with the fact that, for example, the JComponent's

Re: Swing Dev [9] Review Request: 4339584 Adding a getUI public method to JComponent

2015-08-21 Thread Alexander Scherbatiy
On 8/21/2015 1:04 PM, Sergey Bylokhov wrote: Hello. Please review a small fix for jdk9. Long long time ago the next request was filed for jdk 1.4.0: Today, there is no way for a program to access the UI of a JComponent. Adding a getUI method would provide that capability and be consistent

Re: Swing Dev RfR: JDK-8133897, IndexOutOfBounds exception being thrown

2015-08-21 Thread Alexander Scherbatiy
The setTabComponentAt() method allows to set a component to a tabbed pane title. In the following example the tab title is : tabbedPane.addTab(null, new JLabel(Content 1)); tabbedPane.setTabComponentAt(0, new JLabel(Title 1)); The getBounds() method can also try