Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-14 Thread prasanta sadhukhan
On 9/14/2015 12:48 PM, prasanta sadhukhan wrote: On 9/11/2015 2:20 PM, prasanta sadhukhan wrote: On 9/10/2015 4:48 PM, Sergey Bylokhov wrote: On 10.09.15 13:35, prasanta sadhukhan wrote: On 9/10/2015 3:42 PM, Sergey Bylokhov wrote: On 10.09.15 9:36, prasanta sadhukhan wrote: Please r

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

2015-09-14 Thread Alexander Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8132119/webrev.01/ I tried to use Utilities.drawStringUnderlineCharAt(...) with chars that have - 1 character:2 glyphs mapping (U+00E1) and ligature (U+FB01) The whole glyph is underlined. - 2 char

Re: [9] Review Request for 8133864: Wrong display, when the document I18n properties is true.

2015-09-14 Thread Semyon Sadetsky
On 9/11/2015 5:52 PM, Alexander Scherbatiy wrote: On 9/10/2015 6:36 PM, Semyon Sadetsky wrote: On 9/10/2015 4:14 PM, Alexander Scherbatiy wrote: On 9/9/2015 3:43 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8133864 webrev: htt

Re: [9] Review Request: 8135122 The SwingUtilities2.COMPONENT_UI_PROPERTY_KEY can be removed

2015-09-14 Thread Alexander Zvegintsev
Hi Sergey, the fix looks good to me. Thanks, Alexander. On 09/14/2015 03:29 PM, Sergey Bylokhov wrote: Hello. Please review the small fix for jdk9. The unspecified COMPONENT_UI_PROPERTY_KEY property was removed, because it was replaced by the public method in jdk9 [1]. [1] https://bugs.op

[9] Review Request: 8135122 The SwingUtilities2.COMPONENT_UI_PROPERTY_KEY can be removed

2015-09-14 Thread Sergey Bylokhov
Hello. Please review the small fix for jdk9. The unspecified COMPONENT_UI_PROPERTY_KEY property was removed, because it was replaced by the public method in jdk9 [1]. [1] https://bugs.openjdk.java.net/browse/JDK-4339584 Bug: https://bugs.openjdk.java.net/browse/JDK-8135122 The new test: http:

Re: [9] Review Request for 8133803: Swing JFileChooserBug2 test fais with MotifLookAndFeel

2015-09-14 Thread Semyon Sadetsky
Yes. It also need to be restricted. http://cr.openjdk.java.net/~ssadetsky/8133803/webrev.01/ --Semyon On 9/11/2015 5:49 PM, Alexander Scherbatiy wrote: The MotifFileChooserUI contains two text fields. Should another text filed be updated in the same way? Thanks, Alexandr. On 9/7/2015

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-14 Thread prasanta sadhukhan
On 9/11/2015 2:20 PM, prasanta sadhukhan wrote: On 9/10/2015 4:48 PM, Sergey Bylokhov wrote: On 10.09.15 13:35, prasanta sadhukhan wrote: On 9/10/2015 3:42 PM, Sergey Bylokhov wrote: On 10.09.15 9:36, prasanta sadhukhan wrote: Please review the modified webrev which solves this artifact