design question regarding UI defaults and painting

2015-11-12 Thread Alan Snyder
I am curious about a design decision that was made in the implementation of textured window backgrounds in the Aqua LAF/AWT. In a nutshell, a textured window background is an optional NSWindow background style that involves gradients. Textured windows are requested in Java using a window

Re: Review request for JDK-6288609 JInternalFrame.setDefaultCloseOperation() interferes with "close" behavior

2015-11-12 Thread Rajeev Chamyal
Hello Alexander, At all other places we call firePropertyChange(IS_CLOSED_PROPERTY, Boolean.FALSE,Boolean.TRUE); before calling dispose. Which will result in unselecting and closing the frame. If API user is extending the InternalFrameUI classes then they have to care of selection/deselection

Re: RfR JDK-8134116, Add more comprehensive fix and regression test for JDK-8133897

2015-11-12 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 11/11/2015 7:19 PM, Pete Brunet wrote: Thanks Alexandr, I made that change and added a test to ensure getAccessibleName returns the proper page when the page's component is null. Please see the following webrev.

Re: Review request for JDK-6288609 JInternalFrame.setDefaultCloseOperation() interferes with "close" behavior

2015-11-12 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 11/12/2015 12:05 PM, Rajeev Chamyal wrote: Hello Alexander, At all other places we call firePropertyChange(IS_CLOSED_PROPERTY, Boolean.FALSE,Boolean.TRUE); before calling dispose. Which will result in unselecting and closing the frame.

Re: Review request for JDK-8030099 Memory usage of java process increases after pressing start button in test window

2015-11-12 Thread Sergey Bylokhov
Still looks fine to me. On 02.11.15 19:19, Rajeev Chamyal wrote: Hello Phil, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8030099/webrev.02/ The test case has been updated as per review comments. Added tests for both Parallel and default collector. Regards, Rajeev

Re: Review for 8132770: Test javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java fails in MacOSX

2015-11-12 Thread Rajeev Chamyal
Hello Avik, 1) In the tryLookAndFeel exception handling is skipped. createUI and other calls should be skipped in case of exception.. 2) What all platforms you have tested the bug? Regards, Rajeev Chamyal From: Avik Niyogi Sent: 04 November 2015 14:51 To: Rajeev Chamyal;

Re: RfR JDK-8134116, Add more comprehensive fix and regression test for JDK-8133897

2015-11-12 Thread Sergey Bylokhov
Looks fine. On 12.11.15 14:20, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 11/11/2015 7:19 PM, Pete Brunet wrote: Thanks Alexandr, I made that change and added a test to ensure getAccessibleName returns the proper page when the page's component is

Review request for JDK-8075084 JOptionPane.showMessageDialog causes JScrollBar to move

2015-11-12 Thread Rajeev Chamyal
Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-8075084 Webrev: http://cr.openjdk.java.net/~rchamyal/8075084/webrev.00/ Issue: On running the sample program attached in bug JDK-8075084 user is expected to see a scrollbar and on clicking