Hi Rajeev,
Could you please create code reviews in plain text format or at least
not as preformatted HTML text?
It's very inconvenient to scroll the message horizontally because the
text does not wrap automatically in || HTML element.
Thank you very much in advance,
Alexey
On 22.12.2015
(Please keep my CC'd, I'm not subscribed to the list)
Hi folks,
while going over the Java keybinding code (trying to solve a different
problem), I found some strangeness in how KeyboardManager and JComponent
handle keystrokes. In particular, they try to match any registered
keybindings to both
- please check that the progress bar string
(progressBar.setString()/setStringPainted()) is painted correctly.
- is it possible to write an automated test for the fix?
Thanks,
Alexandr.
On 12/21/2015 11:47 AM, Avik Niyogi wrote:
+1
On 10/12/15 22:33, Alexey Ivanov wrote:
Hi Alexandr,
The updated code looks fine to me.
Thanks,
Alexey
On 10.12.2015 17:06, Alexander Scherbatiy wrote:
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8132119/webrev.04/
On 12/10/2015 2:39 PM, Alexey
Hi, Rajeev.
A few notes:
- the cast in the "if (o != (ComponentOrientation) e.getOldValue())"
is not necessary.
- Is it possible to cover all look and feels in the test?
- Why the test is for osx only?
On 22/12/15 12:54, Rajeev Chamyal wrote:
Hello All,
Please review the following fix for
Hi Rajeev,
There's a potential NullPointerException in this line of
BasicInternalFrameUI.java:
if(value.equals(Boolean.FALSE))
I suggest eliminating it using this construct:
if (Boolean.FALSE.equals(value))
This way the code is safer.
Can the test be simplified? Is it really
I am sorry for broadcasting, I meant to send the message privately but
apparently I forgot to remove swing-dev from addressee list.
Roger,
I'm talking about email message format. The text is usually wrapped to
the mail client window width, but if the text is placed in HTML
element, it does
The fix looks good to me.
Is it possible to write an automated test for the fix?
Thanks,
Alexandr.
On 12/21/2015 2:55 PM, Avik Niyogi wrote:
Hi All,
Kindly review the bug fix
Hi Rajeev,
One more comment:
You should call dispose() in finally block in main so that the frame is
closed automatically if the test fails.
Regards,
Alexey
On 23.12.2015 16:46, Alexey Ivanov wrote:
Hi Rajeev,
There's a potential NullPointerException in this line of
The fix looks good to me.
Thanks,
Alexandr.
On 12/21/2015 3:09 PM, Rajeev Chamyal wrote:
Hello All,
Please review the following fix for Jdk9:
Bug:
The fix looks good to me.
Thanks,
Alexandr.
On 12/14/2015 8:32 AM, Rajeev Chamyal wrote:
Hello All,
Please review the following fix for Jdk9:
Bug:
Hi,
Each webrev includes the text patch, follow the jdk.patch link in the
header.
Webrev is the normal mechanism for code reviews and provides several
different
views of the original and modifications.
Roger
On 12/23/15 8:50 AM, Alexey Ivanov wrote:
Hi Rajeev,
Could you please create
I think this version looks OK. Don't forget it needs a CCC ..
-phil.
On 11/24/2015 02:01 AM, Semyon Sadetsky wrote:
On 11/2/2015 11:09 PM, Sergey Bylokhov wrote:
On 29.10.15 21:30, Phil Race wrote:
We should specify what happens if you pass in to get(String)
a) null
b) an unrecognised
Hello Sergey,
Thanks for the review.
The issues is reproducible with mac Aqua LAF only with other LAF/platforms
issue is not reproducible.
I have updated webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/8078489/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
Hello Alexey,
Thanks for the review.
I have updated webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/4769772/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexey Ivanov
Sent: 23 December 2015 19:27
To: swing-dev@openjdk.java.net
Subject: Re: Review
Hello Alexandr,
The modal dialog can be application modal, document modal and toolkit modal.
1) Application-modal dialog box blocks all windows from the same
application, except windows from its child hierarchy
2) Document-modal dialog box blocks all windows from the same document,
16 matches
Mail list logo
