Re: RfR JDK-8145735, Tests api/javax_swing/JTabbedPane/AccessibleJTabbedPane/* are failing

2016-01-14 Thread Vivi An
+1, Thanks Vivi On 1/14/2016 4:02 AM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 1/14/2016 12:06 AM, Pete Brunet wrote: How does this look? http://cr.openjdk.java.net/~ptbrunet/JDK-8145735/webrev.01/ Pete On 1/13/16 7:16 AM, Alexander Scherbatiy wrot

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-14 Thread Sergey Bylokhov
Probably I missed something but why we need two tests? Note that the manual test is not marked as manual, which means that it will be run during the regular run?(even if -a option is provided to jtreg). Please check your other review requests for this issue. moreover on my system JProgressBarO

Re: RfR JDK-8145735, Tests api/javax_swing/JTabbedPane/AccessibleJTabbedPane/* are failing

2016-01-14 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 1/14/2016 12:06 AM, Pete Brunet wrote: How does this look? http://cr.openjdk.java.net/~ptbrunet/JDK-8145735/webrev.01/ Pete On 1/13/16 7:16 AM, Alexander Scherbatiy wrote: On 1/13/2016 1:12 AM, Pete Brunet wrote: Hi Alexandr, On 1/12/16

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-14 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 1/14/2016 1:11 PM, Avik Niyogi wrote: Hi All, Please find the changes as provided with incorporation of inputs: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.05/ With Regards

Re: JDK9 Review Request for JDK-7104635 HTMLEditorKit fails to write down some html files

2016-01-14 Thread prasanta sadhukhan
Fix looks good to me. Regards Prasanta On 11/26/2015 2:06 PM, Rajeev Chamyal wrote: Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-7104635 Webrev: http://cr.openjdk.java.net/~rchamyal/7104635/webrev.00/

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-14 Thread Avik Niyogi
Hi All, Please find the changes as provided with incorporation of inputs: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.05/ With Regards, Avik Niyogi > On 14-Jan-2016, at 3:18 pm, Alexander Scherbatiy > wrote: > > On 1/14/2016 8:18

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-14 Thread Alexander Scherbatiy
On 1/14/2016 8:18 AM, Avik Niyogi wrote: Hi All, Please find changes as provided with incorporation of inputs: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.04/ It is better to restore the graphics transform after the progress

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

2016-01-14 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 1/14/2016 9:02 AM, Sergey Bylokhov wrote: Looks fine. On 14/01/16 07:37, Avik Niyogi wrote: Hi All, Please find code changes incorporating changes as suggested by inputs provided: http://cr.openjdk.java.net/~aniyogi/8016665/webrev.02/ W