Hi,
Goods finding Sergey.
1. In file,
src/java.desktop/macosx/classes/com/apple/laf/AquaTableHeaderUI.java, call to
setText() and setBorder() should be made irrespective of whether table in null
or not. I have made this change.
2. The changes to SynthTableHeaderUI.java are
Reminder
From: Rajeev Chamyal
Sent: Monday, February 15, 2016 2:42 PM
To: Prem Balakrishnan; Alexander Scherbatiy
Cc: Sergey Bylokhov; Semyon Sadetsky; Ambarish Rapte; swing-dev@openjdk.java.net
Subject: RE: Review Request for 7126823 :
JInternalFrame.getNormalBounds() returns bad value
The fix looks good to me.
Thanks,
Alexandr.
On 17/02/16 19:20, Sergey Bylokhov wrote:
Looks fine.
On 15.02.16 18:17, Semyon Sadetsky wrote:
Please look at the updated webrev:
http://cr.openjdk.java.net/~ssadetsky/8081722/webrev.05/
Changes was made According to off-line discussion wit
Hi, Hello Ajit.
I am not sure that exclusion of the code is a correct fix here. For
example can you clarify should we call setText(or other setXXX) when the
table is null or not? Another question is: should we skip the code in
SynthTableHeaderUI.java or we can assume table==null as enabled
Looks good to me.
Regards,
Rajeev Chamyal
From: Ajit Ghaisas
Sent: 17 February 2016 16:51
To: Rajeev Chamyal; Sergey Bylokhov; Alexander Scherbatiy;
swing-dev@openjdk.java.net
Subject: RE: [9] Review fix for JDK-8020039 : SynthTableHeaderUI
refers to possibly null parameter in cell
Hi,
I have corrected formatting of test code and removed the additional
System.out.printlns.
Please review : http://cr.openjdk.java.net/~arapte/ajit/8020039/webrev.02/
Regards,
Ajit
From: Ajit Ghaisas
Sent: Tuesday, February 16, 2016 3:12 PM
To: Rajeev Chamyal; Sergey
