Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Sergey, I have tested the test cases as mentioned. 1) They are not related to the current fix 2) ScreenMenuBarInputTwice.java issue is not reproducible. 3) There is a test bug in ActionListenerCalledTwiceTest.java, hence a new test case called ScreenMenuBarInputTwice.java was created to

Re: RfR, JDK-8145228 , Java Access Bridge, getAccessibleStatesStringFromContext doesn't wrap the call to getAccessibleRole

Thanks Alexandr, I fixed that here: http://cr.openjdk.java.net/~ptbrunet/JDK-8145228/webrev.01/ Pete On 3/14/16 7:23 AM, Alexander Scherbatiy wrote: > > > The fix looks good to me. > > There is a small comment about code formatting. > I believe that according to the new Java Style Guidelines

Re: [9] Review request for 8146301: Enter key does not work in a deserialized JFileChooser

Does the test is passed on all platforms? On 17.03.16 17:37, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8146301 webrev: http://cr.openjdk.java.net/~ssadetsky/8146301/webrev.00/ This is a regression of JDK-8021253 in which explicit

Re: RfR, JDK-8145228 , Java Access Bridge, getAccessibleStatesStringFromContext doesn't wrap the call to getAccessibleRole

Hi Pete, >> http://cr.openjdk.java.net/~ptbrunet/JDK-8145228/webrev.01/ please consider using method reference instead of a lambda in: 1411 AccessibleRole role = InvocationUtils.invokeAndWait(() -> { 1412 return ac.getAccessibleRole(); 1413

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hi Alexander, The issue only applies for ScrollingTabbedPane and hence this fix. With Regards, Avik Niyogi > On 16-Mar-2016, at 4:51 pm, Alexander Scherbatiy > wrote: > > > Does the same issue affects the AquaTabbedPaneContrastUI? > > Thanks, > Alexandr. > >

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8132119/webrev.08/ - Public TextUIDrawing interface is added to the javax.swing.plaf package - TextUIDrawing methods description does not mention component properties to be more general - TextUIDrawing methods are

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

It can be made into a class method, but herein this case it is needed for that instance only and hence the need for instance method and referred with “self”. With Regards, Avik Niyogi > On 16-Mar-2016, at 11:55 pm, Alexander Scherbatiy > wrote: > > > Could the

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

I ran your changes (which included my fix) through jprt and all Solaris platforms failed as follows :- jdk/src/java.desktop/unix/native/libawt_xawt/awt/sun_awt_X11_GtkFileDialogPeer.c", line 37: error: typedef redeclared: GtkWindow (E_TYPEDEF_REDECLARED) cc: acomp failed for

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

On 17.03.2016 6:25, Semyon Sadetsky wrote: The awt_Desktop.c is missed in the webrev. Please see the updated one: http://cr.openjdk.java.net/~ssadetsky/8145547/webrev.02/ --Semyon On 3/17/2016 3:57 PM, Sergey Bylokhov wrote: On 16.03.16 20:52, Semyon Sadetsky wrote: Hi Phil, Thank for

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

The fix looks good to me. Thanks, Alexandr. On 21/01/16 07:49, Avik Niyogi wrote: Hi All, Please review my code change with inputs received: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.08/ With Regards, Avik Niyogi On

Re: [9] Review request for 8151015: JTextArea.insert() does not behave as expected with invalid position

The fix looks good to me. Just a small comment: if it is a new test it probably should not contain 1998 year in the copyright. Thanks, Alexandr. On 14/03/16 20:48, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8151015 webrev:

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

On 18.03.16 15:37, Semyon Sadetsky wrote: On 3/17/2016 2:46 PM, Sergey Bylokhov wrote: Small notes: - It will be good to move the code which reads the system properties to the static init block, otherwise we can be in trouble if these properties will be changed at runtime. I don't' see any

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hi Alexander, Thank you for the inputs. I agree with you and did feel the need for removing duplicate code as well. But as per an earlier review input, changes to the super call lay outing is not accepted. This was the only other feasible solution. Created redundant code in this process, but

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

I guess you need a separate CR for this, because JDK-8015748 was closed already. On 21.01.16 6:49, Avik Niyogi wrote: Hi All, Please review my code change with inputs received: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.08/ With Regards, Avik Niyogi On 21-Jan-2016, at 8:30 am, Avik

[9] Review request for 8146301: Enter key does not work in a deserialized JFileChooser

Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8146301 webrev: http://cr.openjdk.java.net/~ssadetsky/8146301/webrev.00/ This is a regression of JDK-8021253 in which explicit setting the default button was moved to the hierarchy listener but this listener

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

On 3/17/2016 10:57 PM, Phil Race wrote: I ran your changes (which included my fix) through jprt and all Solaris platforms failed as follows :- jdk/src/java.desktop/unix/native/libawt_xawt/awt/sun_awt_X11_GtkFileDialogPeer.c", line 37: error: typedef redeclared: GtkWindow

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Could the -(NSMutableString *) parseString: method be declared as class method instead of instance? Thanks, Alexandr. On 14/03/16 17:18, Sergey Bylokhov wrote: Hi, Avik. Can you please take a look to these two tests before fixing this bug: TEST:

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

On 16.03.16 20:52, Semyon Sadetsky wrote: Hi Phil, Thank for review. You will find my reply below in the text. The updated webrev is http://cr.openjdk.java.net/~ssadetsky/8145547/webrev.01/ On my system this version fails to build(Ubuntu 15.10 + gcc 5.2.1): ERROR: Build failed for target

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

This reminded me I had not yet tried the build myself. When I did I not get the error that Sergey did but I got this as well :- jdk9-client/jdk/src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c: In function ‘get_integer_property’:

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

The fix looks good to me. Just a small note: it is better to remove comment "527 //" since it does not have a description. Thanks, Alexandr. On 17/03/16 17:21, Avik Niyogi wrote: It can be made into a class method, but herein this case it is needed for that instance only and hence