Re: [9] Review request for 8142966 Wrong cursor position in text components on HiDPI display

On 6/1/2016 12:26 AM, Phil Race wrote: On 5/31/2016 1:36 PM, Alexandr Scherbatiy wrote: On 5/31/2016 10:54 PM, Phil Race wrote: This looks reasonable except I am not sure when gc would be null here :- 1062 private static FontRenderContext getFRCProperty(JComponent c) { 1063

Re: [9] Review request for 8142966 Wrong cursor position in text components on HiDPI display

On 5/31/2016 10:54 PM, Phil Race wrote: This looks reasonable except I am not sure when gc would be null here :- 1062 private static FontRenderContext getFRCProperty(JComponent c) { 1063 if (c != null) { 1064 1065 GraphicsConfiguration gc =

Re: [9] Review request for 8142966 Wrong cursor position in text components on HiDPI display

This looks reasonable except I am not sure when gc would be null here :- 1062 private static FontRenderContext getFRCProperty(JComponent c) { 1063 if (c != null) { 1064 1065 GraphicsConfiguration gc = c.getGraphicsConfiguration(); 1066 AffineTransform tx =

Re: [9] Review request for 8156217 Selected text is shifted on HiDPI display

I applied this and it is *much* better but there still seem to be some tiny quirks. When I drag the mouse to select text down and then up again, as I pass the original mouse click point vertically, repaint seem to jiggle vertically by a pixel. Perhaps a rounding issue in the repaint code's

Re: [9] Review request for 8151015: JTextArea.insert() does not behave as expected with invalid position

This one seems like it got lost in my inbox. I am OK with the fix but the opened test needs the GPL. -phil. On 04/07/2016 03:20 AM, Semyon Sadetsky wrote: Hi Phil, I have found one failed test. My fix adds extra element in the HTMLDocument after insert operation. Looks like the

[8] Review request for JI-9038899: [macosx]Memory leak in ScreenMenu

Hello, I created a patch for a bug I just logged through http://bugs.java.com/ (still under review with identifier JI-9038899). The com.apple.laf.ScreenMenu class keeps hard references to JMenuItems which have been removed from the JMenu. The patch contains a fix for the memory leak and a test

Re: 8158230: [macosx] ActionEvent is not fired for menu item with option apple.laf.useScreenMenuBar

The fix looks good to me. Thanks, Alexandr. On 5/31/2016 4:39 PM, Sergey Bylokhov wrote: Thanks. Looks fine. On 31.05.16 16:38, Avik Niyogi wrote: Hi Sergey, I ran the relevant test cases: ActionListenerCalledTwiceTest ScreenMenuBarInputTwice with different keyboard preferences and locales.

Re: 8158230: [macosx] ActionEvent is not fired for menu item with option apple.laf.useScreenMenuBar

Thanks. Looks fine. On 31.05.16 16:38, Avik Niyogi wrote: Hi Sergey, I ran the relevant test cases: ActionListenerCalledTwiceTest ScreenMenuBarInputTwice with different keyboard preferences and locales. Also tried different LAFs but found that only default (aqua) LAF is relevant for this case.

Re: 8158230: [macosx] ActionEvent is not fired for menu item with option apple.laf.useScreenMenuBar

Hi Sergey, I ran the relevant test cases: ActionListenerCalledTwiceTest ScreenMenuBarInputTwice with different keyboard preferences and locales. Also tried different LAFs but found that only default (aqua) LAF is relevant for this case. With Regards, Avik Niyogi > On 31-May-2016, at 7:05 pm,

Re: 8158230: [macosx] ActionEvent is not fired for menu item with option apple.laf.useScreenMenuBar

Hi, Avik. Please confirm that you run all tests for the previous regressions which were fixed in this code recently. (use different system locales). On 31.05.16 16:28, Avik Niyogi wrote: Hi All, Kindly review the fix for JDK9. *Bug: *https://bugs.openjdk.java.net/browse/JDK-8158230

8158230: [macosx] ActionEvent is not fired for menu item with option apple.laf.useScreenMenuBar

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8158230 Webrev: http://cr.openjdk.java.net/~aniyogi/8158230/webrev.00/ Issue: ActionEvent is not

Re: Review Request JDK-8152419 JColorChooser throws Exception

On 31/05/16 14:03, Prem Balakrishnan wrote: Hi Alexander, Please review the updated patch. http://cr.openjdk.java.net/~pkbalakr/8152419/webrev.01/ Math.max(getWidth() - this.insets.left - this.insets.right, getWidth()) can give

Re: Review Request JDK-8152419 JColorChooser throws Exception

Hi Alexander, Please review the updated patch. http://cr.openjdk.java.net/~pkbalakr/8152419/webrev.01/ Regards, Prem From: Alexander Scherbatiy Sent: Monday, May 30, 2016 9:42 PM To: Prem Balakrishnan; Sergey Bylokhov; swing-dev@openjdk.java.net Subject: Re: Review Request

Re: Review request for 8132771: [TEST_BUG][macosx] Test javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java fails for MacOSX

Hello Avik, The frame should be disposed in case of exception also. Regards, Rajeev Chamyal From: Avik Niyogi Sent: 31 May 2016 11:14 To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Review request for 8132771: [TEST_BUG][macosx] Test