Re: [9] Review request for JDK-[TEST_BUG] test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java: compilation failed

Hello Alexandr, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8158358/webrev.01/ Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 02 June 2016 01:20 To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net Subject: Re: [9] Review request for

Re: [9] Review request for JDK-[TEST_BUG] test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java: compilation failed

On 6/1/2016 10:35 PM, Rajeev Chamyal wrote: Hello All, Please review the following webrev Webrev : http://cr.openjdk.java.net/~rchamyal/8158358/webrev.00/ Bug : https://bugs.openjdk.java.net/browse/JDK-8158358 Fix : Fixed the

[9] Review request for JDK-[TEST_BUG] test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java: compilation failed

Hello All, Please review the following webrev Webrev : http://cr.openjdk.java.net/~rchamyal/8158358/webrev.00/ Bug : https://bugs.openjdk.java.net/browse/JDK-8158358 Fix : Fixed the compilation error. Regards, Rajeev Chamyal

Re: Review request for 8132771: [TEST_BUG][macosx] Test javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java fails for MacOSX

The fix looks good to me. Thanks, Alexandr. On 5/31/2016 10:58 AM, Avik Niyogi wrote: Hi All, Please review the code changes with inputs provided. http://cr.openjdk.java.net/~aniyogi/8132771/webrev.01/ With Regards, Avik Niyogi

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

The fix looks good to me. Thanks, Alexandr. On 6/1/2016 7:46 PM, Philip Race wrote: +1 -phil. On 6/1/16, 12:18 AM, Semyon Sadetsky wrote: Please the corrected webrev: http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.03/ Also the CCC request was updated. --Semyon On 5/31/2016

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

+1 -phil. On 6/1/16, 12:18 AM, Semyon Sadetsky wrote: Please the corrected webrev: http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.03/ Also the CCC request was updated. --Semyon On 5/31/2016 10:23 PM, Phil Race wrote: The {@code InputVerifier} also provides possibility to validate

Re: [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

On 6/1/2016 12:21 PM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug : https://bugs.openjdk.java.net/browse/JDK-8146319 Webrev : http://cr.openjdk.java.net/~rchamyal/8146319/webrev.00/ Issue:

Re: [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

Still looks good. --Semyon On 6/1/2016 1:20 PM, Rajeev Chamyal wrote: Hello Semyon, Thanks for the review. Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8146319/webrev.01/ Update: Updated test to use

Re: [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

Hello Semyon, Thanks for the review. Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8146319/webrev.01/ Update: Updated test to use File.createTempFile() for creating temp file. Regards, Rajeev Chamyal From: Semyon Sadetsky Sent: 01 June 2016 15:01 To:

Re: [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

Hi, The fix looks good. In the test you could use File.createTempFile() or better Files.createTempFile() --Semyon On 6/1/2016 12:21 PM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug : https://bugs.openjdk.java.net/browse/JDK-8146319 Webrev :

[9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

Hello All, Please review the following webrev. Bug : https://bugs.openjdk.java.net/browse/JDK-8146319 Webrev : http://cr.openjdk.java.net/~rchamyal/8146319/webrev.00/ Issue: JEditorPane::read method is not closing the InputStreamReader. Fix: closing the InputStreamReader in finally

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

Please the corrected webrev: http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.03/ Also the CCC request was updated. --Semyon On 5/31/2016 10:23 PM, Phil Race wrote: The {@code InputVerifier} also provides possibility to validate against "provides the possibility" "the target of the focus