Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

2016-10-26 Thread Avik Niyogi
Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. http://cr.openjdk.java.net/~aniyogi/8138771/webrev.04/ Thank you in advance. With Regards, Avik Niyogi > On 27-Oct-2016, at 2:33 am, Jim Gr

Re: [9] RFR JDK-8168657: [PIT] Still, on Windows test always fails: java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java

2016-10-26 Thread Prasanta Sadhukhan
What I meant to say is hidpi splashscreen support is not there in solaris (already told earlier too) http://mail.openjdk.java.net/pipermail/awt-dev/2016-March/010813.html and this http://hg.openjdk.java.net/jdk9/client/jdk/file/eeb8b31afed6/src/java.desktop/unix/native/libsplashscreen/splashscr

Re: [9] Review request for 8074883: Tab key should move to focused button in a button group

2016-10-26 Thread Semyon Sadetsky
Thank you, Alexander. Please review the updated webrev: http://cr.openjdk.java.net/~ssadetsky/8074883/webrev.01/ CCC request will be filed after the fix is approved. --Semyon On 10/25/2016 3:14 PM, Alexandr Scherbatiy wrote: On 10/19/2016 8:14 PM, Semyon Sadetsky wrote: Hello, Please revie

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-26 Thread Mandy Chung
Should the same change be applied to the .h files as well? Mandy > On Oct 26, 2016, at 7:24 PM, Pete Brunet wrote: > > Please review the latest update at > http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/ > > The change is to AccessBridgeCalls.c. The license has been changed from >

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-26 Thread Pete Brunet
Thanks Anirvan. Appreciate you taking the time to participate in this thread. On 10/26/16 11:27 PM, Anirvan Sarkar wrote: > Hi, > > If you replace the hex number with 'tip' then it will always point to > the latest version. > > Something > like > http://hg.openjdk.java.net/jdk9/client/jdk/file/

RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-26 Thread Anirvan Sarkar
Hi, If you replace the hex number with 'tip' then it will always point to the latest version. Something like http://hg.openjdk.java.net/jdk9/client/jdk/file/tip/ src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c Regards, Anirvan Sarkar On Thursday 27 October 2016, Pete Bru

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-26 Thread Pete Brunet
I found a comment from Mandy in the bug. That hex number can be replaced with "tip". I uploaded http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.04/ Pete On 10/26/16 11:05 PM, Pete Brunet wrote: > > > On 10/26/16 10:44 PM, Philip Race wrote: >> > >> 15 > href="http://hg.openjd

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-26 Thread Pete Brunet
On 10/26/16 10:44 PM, Philip Race wrote: > > > 15 href="http://hg.openjdk.java.net/jdk9/client/jdk/file/544828ab2a9b/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c";> > That URL is definitely not authoritative. > > I think you need to give a pointer to somethin

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-26 Thread Philip Race
> 15http://hg.openjdk.java.net/jdk9/client/jdk/file/544828ab2a9b/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c";> That URL is definitely not authoritative. I think you need to give a pointer to something more like http://hg.openjdk.java.net/jdk9/jdk9/jdk/src/jdk.acces

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-26 Thread Pete Brunet
Please review the latest update at http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/ The change is to AccessBridgeCalls.c. The license has been changed from GPL2 to BSD. This is because the file was originally unlicensed prior to being bundled into the JDK and the compiled .obj is link

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

2016-10-26 Thread Jim Graham
The "@return" tags should not start with "returns" in the text. Also, in the @return for getProperty(), insert a word "the" as "the property of the base image"... ...jim On 10/26/16 12:36 AM, Avik Niyogi wrote: Hi All, Please review the proposed specification for JDK9

Re: [9] RFR JDK-8168657: [PIT] Still, on Windows test always fails: java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java

2016-10-26 Thread Philip Race
Are you sure about that ? I can't think why it would not work on Solaris just as it works everywhere else. And when I run 'java -help' on Solaris it lists the option :- -splash: show splash screen with specified image -phil. On 10/26/16, 8:27 AM, Prasanta Sadhukhan wrote:

Re: [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

2016-10-26 Thread Semyon Sadetsky
On 10/26/2016 6:43 PM, Sergey Bylokhov wrote: On 25.10.16 18:46, Semyon Sadetsky wrote: I wonder why he should decide that the old code can be "simply replaced" by the new one? I suppose that at least he should read the specification of the new extended API. There is no notion that this api is

Re: [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

2016-10-26 Thread Sergey Bylokhov
On 25.10.16 18:46, Semyon Sadetsky wrote: I wonder why he should decide that the old code can be "simply replaced" by the new one? I suppose that at least he should read the specification of the new extended API. There is no notion that this api is replaced by the new one, there is a recommendati

Re: [9] RFR JDK-8168657: [PIT] Still, on Windows test always fails: java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java

2016-10-26 Thread Prasanta Sadhukhan
No, as I understand splashscreen support is not there for solaris. Regards Prasanta On 10/26/2016 8:55 PM, Sergey Bylokhov wrote: Should this test work on Solaris as well? On 26.10.16 10:19, Prasanta Sadhukhan wrote: Hi All, Please review a simple fix for splasscreen testissue where we need t

Re: [9] RFR JDK-8168657: [PIT] Still, on Windows test always fails: java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java

2016-10-26 Thread Sergey Bylokhov
Should this test work on Solaris as well? On 26.10.16 10:19, Prasanta Sadhukhan wrote: Hi All, Please review a simple fix for splasscreen testissue where we need to restrict this test from running on linux as this test uses linux enviroment variable GDK_SCALE so restricting to run only on linux

Re: [9] RFR JDK-8168657: [PIT] Still, on Windows test always fails: java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java

2016-10-26 Thread Rajeev Chamyal
Looks good to me. Regards, Rajeev Chamyal -Original Message- From: Prasanta Sadhukhan Sent: 26 October 2016 12:54 To: Rajeev Chamyal; Alexandr Scherbatiy; swing-dev@openjdk.java.net Subject: Re: [9] RFR JDK-8168657: [PIT] Still, on Windows test always fails: java/awt/SplashScreen/Mult

8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

2016-10-26 Thread Avik Niyogi
Hi All, Please review the proposed specification for JDK9 including inputs from reviver reviews. cr.openjdk.java.net/~aniyogi/8138771/webrev.03/ Thank you in advance. With Regards, Avik Niyogi

[9] RFR JDK-8048702: Deprecate obsolete classes in javax/swing/plaf/metal/MetalFileChooserUI.java

2016-10-26 Thread Prasanta Sadhukhan
Hi All, Please review a fix for the issue where this obsolete class needs to be deprecated: Bug: https://bugs.openjdk.java.net/browse/JDK-8048702 diff -r aae3690e53e3 src/java.desktop/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java --- a/src/java.desktop/share/classes/javax/swi

Re: [9] RFR JDK-8168657: [PIT] Still, on Windows test always fails: java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java

2016-10-26 Thread Prasanta Sadhukhan
Please review this. diff -r aae3690e53e3 test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java --- a/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java Thu Oct 20 14:21:46 2016 +0300 +++ b/test/java/awt/SplashScreen/Mult

[9] RFR JDK-8168657: [PIT] Still, on Windows test always fails: java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java

2016-10-26 Thread Prasanta Sadhukhan
Hi All, Please review a simple fix for splasscreen testissue where we need to restrict this test from running on linux as this test uses linux enviroment variable GDK_SCALE so restricting to run only on linux. Bug: https://bugs.openjdk.java.net/browse/JDK-8168657 diff -r aae3690e53e3 test/j

8168540: [TEST_BUG] On Unity, need a delay before screenshot taking to avoid animation

2016-10-26 Thread Avik Niyogi
Hi All, Kindly review the proposed fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8168540 Webrev: http://cr.openjdk.java.net/~aniyogi/8168540/webrev.00/ Issue: Animation be