Re: RFR:8168316: Suppress deprecation warnings for Applet classes in java.desktop

2016-11-02 Thread Prasanta Sadhukhan
Do we need the suppression in JavaSoundAudioClip.java as I could not find any mention of Applet in that class? In AppletViewer.java shouldn't we need to add "deprecation" to 45 @SuppressWarnings("serial") // JDK implementation class Do we still need this 160

Re: [9] Review request for 8139394: more detailed message for "Could not initialize shell library"

2016-11-02 Thread Semyon Sadetsky
On 02.11.2016 19:23, Sergey Bylokhov wrote: On 02.11.16 9:43, Semyon Sadetsky wrote: The path is not printed because there always several paths to look for the system module. But I did not get how filesystem read permission is related to the console output. This is not a console output this

Re: RFR:8168316: Suppress deprecation warnings for Applet classes in java.desktop

2016-11-02 Thread Sergey Bylokhov
On 20.10.16 1:14, Philip Race wrote: Well maybe but this isn't about adding deprecations it is just about of getting rid of warnings for uses of APIs that are already deprecated. ok. You are welcome to file a separate bug on that ... -phil. On 10/19/16, 2:59 PM, Sergey Bylokhov wrote: On

Re: [9] Review request for 8139394: more detailed message for "Could not initialize shell library"

2016-11-02 Thread Sergey Bylokhov
On 02.11.16 9:43, Semyon Sadetsky wrote: The path is not printed because there always several paths to look for the system module. But I did not get how filesystem read permission is related to the console output. This is not a console output this is an exception which can be handled. Really?

Re: [9] Review request for 8058742: Text size is twice bigger under GTK L on Gnome with HiDPI enabled

2016-11-02 Thread Semyon Sadetsky
On 11/1/2016 10:57 PM, Sergey Bylokhov wrote: On 05.10.16 10:35, Semyon Sadetsky wrote: Can you clarify, what does it mean "wrong", this why we cannot use it or what? If it is wrong then we can fix it, if it is correct why we cannot use it? It should be the same as getNativeScale(), because it

Re: [9] Review request for 8074883: Tab key should move to focused button in a button group

2016-11-02 Thread Semyon Sadetsky
On 11/1/2016 10:37 PM, Sergey Bylokhov wrote: On 28.10.16 11:20, Semyon Sadetsky wrote: probably it is possible to change the while loop to something? just to hide the usage of Enumeration? like Enumiration.asIterator().forEachRemaining()? I did not get why. What is wrong with Enumeration?

Re: [9] Review request for 8075918: The regression-swing case failed as the long Tab titles are not clipped with dots at the end with the special options"-client -Dswing.defaultlaf=javax.s

2016-11-02 Thread Semyon Sadetsky
On 11/1/2016 10:44 PM, Sergey Bylokhov wrote: On 28.10.16 12:35, Semyon Sadetsky wrote: Probably this clipping should be done in the 633 paintText(ss, g, tabPlacement, font, metrics, 634 tabIndex, clippedTitle, textRect, isSelected); ? It should be designed

Re: [9] Review request for 8168992 Add floating point implementation for new BasicGraphicsUtils text related methods use floating point API

2016-11-02 Thread Semyon Sadetsky
+1 --Semyon On 11/1/2016 5:13 PM, Sergey Bylokhov wrote: Looks fine. On 01.11.16 16:47, Alexandr Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8168992 webrev: http://cr.openjdk.java.net/~alexsch/8168992/webrev.00 The fix

Re: [9] Review request for 8139394: more detailed message for "Could not initialize shell library"

2016-11-02 Thread Semyon Sadetsky
On 10/28/2016 10:47 PM, Sergey Bylokhov wrote: On 28.10.16 12:56, Semyon Sadetsky wrote: If we unsure what information will be contained in the message is it necessary to provide it to the user? Or it will be enough to describe the problem in general? For example this message should not