Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

Hi Prasanta, Haven't you tested how the details header localization works after your fix with other L and platforms? --Semyon On 07/04/2017 11:42 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for a locale issue where it is seem FileChooser dialog is not showing the column

Re: [10] JDK-6919529: NPE from MultiUIDefaults.getUIError

Hi, Can somebody clarify when the "catch Error()" in the test is executed? Note that the test operates on Swing components on non-EDT. - prasanta.sadhuk...@oracle.com wrote: > one thing. In the test, it is missing > > @run main > > so add that when you check in. > > Regards > Prasanta

Re: [10][TESTBUG]: Review Request for JDK-8169958 : javax/swing/JSpinner/5012888: Spinner value should be more than 1

Looks fine. - srinivas.mandal...@oracle.com wrote: > Hi Sergey, > > I have modified the code as per the comments. > Updated Webrev: > http://cr.openjdk.java.net/~akolarkunnu/8169958/webrev.03/ > > > Thanks > Srinivas M > > > -Original Message- > From: Sergey Bylokhov > Sent:

Re: [10][TESTBUG]: Review Request for JDK-8169958 : javax/swing/JSpinner/5012888: Spinner value should be more than 1

Hi Sergey, I have modified the code as per the comments. Updated Webrev: http://cr.openjdk.java.net/~akolarkunnu/8169958/webrev.03/ Thanks Srinivas M -Original Message- From: Sergey Bylokhov Sent: Tuesday, July 4, 2017 12:08 AM To: Srinivas Mandalika

Re: [10] JDK-6919529: NPE from MultiUIDefaults.getUIError

one thing. In the test, it is missing @run main so add that when you check in. Regards Prasanta On 7/5/2017 2:35 PM, Prasanta Sadhukhan wrote: +1 Regards Prasanta On 7/5/2017 1:44 PM, Ajit Ghaisas wrote: +1 There is an additional space on line 28 in test. Please correct it before checking

Re: [10] JDK-6919529: NPE from MultiUIDefaults.getUIError

+1 Regards Prasanta On 7/5/2017 1:44 PM, Ajit Ghaisas wrote: +1 There is an additional space on line 28 in test. Please correct it before checking in. You do not need a new webrev just for that. Regards, Ajit -Original Message- From: Shashidhara Veerabhadraiah Sent: Wednesday, July

Re: [10] RFR JDK-8175968: The javax.swing.filechooser.FileSystemView constructor consumes memory by adding a PropertyChangeListener that is never removed.

I don't need the credit. Feel free to simply adjust your fix. Robin On Wed, Jul 5, 2017 at 7:42 AM, Prasanta Sadhukhan < prasanta.sadhuk...@oracle.com> wrote: > Ok. Will you mind preparing a patch for your thought on this fix for us to > credit you for the fix? > Regards > Prasanta > > On

Re: [10] JDK-6919529: NPE from MultiUIDefaults.getUIError

+1 There is an additional space on line 28 in test. Please correct it before checking in. You do not need a new webrev just for that. Regards, Ajit -Original Message- From: Shashidhara Veerabhadraiah Sent: Wednesday, July 05, 2017 11:04 AM To: Ajit Ghaisas;

[10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

Hi All, Please review a fix for a locale issue where it is seem FileChooser dialog is not showing the column heading in selected locale in "Detail view mode". This was because, even though the locale strings are present in properties resource file,