Re: [10] JDK-8178106: There is no error message pop up when clicking 'create folder' button

2017-07-27 Thread Shashidhara Veerabhadraiah
The test asks to create a folder for the test and the same shall be requested to delete so that the system gets back to the same state as before the test. Is not that is good? shashi -Original Message- From: Sergey Bylokhov Sent: Thursday, July 27, 2017 11:36 PM To: Shashidhara

Re: [10] JDK-8178106: There is no error message pop up when clicking 'create folder' button

2017-07-27 Thread Sergey Bylokhov
I guess it will be better to notify the user that the permissions should be restored. On 26.07.2017 23:27, Shashidhara Veerabhadraiah wrote: Here is the new Webrev with the requested changes: http://cr.openjdk.java.net/~pkbalakr/shashi/8178106/webrev.02/ Thanks and regards, Shashi

Re: [10] JDK-8058785: Nimbus disabled tooltip needs border

2017-07-27 Thread Sergey Bylokhov
Hi, Shashi. I assume that other components like menu items have the same border, right?(size and color). - shashidhara.veerabhadra...@oracle.com wrote: > > > Hi All, Please review a fix for the JDK-8058785 where the disabled tooltip does not draws the border and blends into the

Re: [10] RFR JDK-7190581: Nimbus: PgDn at the bottom causes scrolling

2017-07-27 Thread Semyon Sadetsky
Thanks. The fix looks good to me. --Semyon On 07/26/2017 11:08 PM, Prasanta Sadhukhan wrote: OK. Here's the webrev with modified testcase http://cr.openjdk.java.net/~psadhukhan/7190581/webrev.01/ Regards Prasanta On 7/26/2017 8:21 PM, Semyon Sadetsky wrote: Hi Prasanta, The bug was found

[10] JDK-8058785: Nimbus disabled tooltip needs border

2017-07-27 Thread Shashidhara Veerabhadraiah
Hi All, Please review a fix for the JDK-8058785 where the disabled tooltip does not draws the border and blends into the disabled button and looks bad. Below is the picture of current JDK output without the fix. Solution and fix: I have updated the skin.laf file to draw a border for

Re: [10] JDK-8178106: There is no error message pop up when clicking 'create folder' button

2017-07-27 Thread Shashidhara Veerabhadraiah
Here is the new Webrev with the requested changes: http://cr.openjdk.java.net/~pkbalakr/shashi/8178106/webrev.02/   Thanks and regards, Shashi   From: Sergey Bylokhov Sent: Wednesday, July 26, 2017 10:17 PM To: Prasanta Sadhukhan Cc:

Re: [10] RFR JDK-7190581: Nimbus: PgDn at the bottom causes scrolling

2017-07-27 Thread Prasanta Sadhukhan
OK. Here's the webrev with modified testcase http://cr.openjdk.java.net/~psadhukhan/7190581/webrev.01/ Regards Prasanta On 7/26/2017 8:21 PM, Semyon Sadetsky wrote: Hi Prasanta, The bug was found on Nimbus L but the provided reg test doesn't run on Nimbus. Can you modify the test to make