Hi all,
there is one more option:
4. Close the issue as "won't fix" and suggest the reporter to fix his code.
Option 3 may not break any existing application. But it may hide bugs
in applications because in my opinion setting a wrong selection
interval is a bug.
Just my 2 cents.
Best regards,
Hi All,
Thank you for your reviews.
I think we need to finalize on where to make changes, before going any further
. We have following few options
1. Change setSelectionInterval and addSelectionInterval to throw Exception:
Make change to these functions to throw IllegalArgumentException when t
On 12/7/17, 9:15 PM, Muneer Kolarkunnu wrote:
Hi Phil,
jdk/internal/util \ has already removed by task
https://bugs.openjdk.java.net/browse/JDK-8192958 .
Fixed 9 hours ago ? .. so not when I did this work !
Anyway it is redundant so I will not need to do this.
I think better to use group
Hi Phil,
jdk/internal/util \ has already removed by task
https://bugs.openjdk.java.net/browse/JDK-8192958 .
I think better to use group name "jdk_client_sanity" instead of
"sanity/client/SwingSet \" at line no:358.
Typo " commuonly" at line no: 355.
Regards,
Muneer
-Original Message-
+1
Regards
Prasanta
On 12/8/2017 1:15 AM, Phil Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8193211
Webrev: http://cr.openjdk.java.net/~prr/8193211/
adds jdk_swing_core and jdk_desktop_core test groups to jtreg
Also problem lists many (by no means all) of the known jtreg failures.
Bug: https://bugs.openjdk.java.net/browse/JDK-8189809
webrev: http://cr.openjdk.java.net/~prr/8189809/
This partially addresses a slow-down in Swing.
Swing now usually calls Font.getStringBounds() instead of
FontMetrics().stringWidth for text measurement.
The latter has a fast-path for latin-
Bug: https://bugs.openjdk.java.net/browse/JDK-8193211
Webrev: http://cr.openjdk.java.net/~prr/8193211/
adds jdk_swing_core and jdk_desktop_core test groups to jtreg
Also problem lists many (by no means all) of the known jtreg failures.
-phil
Hi Phil
Thank you for your time in understanding the issue and rephrasing the text. I
have created a new webrev, with the text you mentioned, and here it is:
http://cr.openjdk.java.net/~kaddepalli/8187936/webrev01/
Regards,
Krishna
From: Phil Race
Sent: Wednesday, December 6, 2017 1
Hi Sergey,
Per our conversation, I have done the following changes:
1. Found that the .class size increases by 1kb when streams are used, so
reverted the changes related to it.
2. Moved the "++nextIndex" into the conditional, so that there is no
logical change.
Here is the upda