Re: [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description

Hi, Pankaj. Can you please check other methods in this class since we update it anyway. For example "setInstalledLookAndFeels" has @throws NPE but "installLookAndFeel" has not. The test to prove that, is welcome as well. On 10/04/2018 03:57, Pankaj Bansal wrote: Hi All, Please review a very si

Re: [11]JDK-8200605: Create test for GridBagLayoutDemo

Hi, Vikrant. Thanks for the feedback, this failure was due to a bug in Mac, Component.getLocation() was giving an incorrect/inconsistent initial value when the component is located at (0,0). I have filed a bug for this issue: https://bugs.openjdk.java.net/browse/JDK-8201364 . I have added a

Re: RFR: 8201328: SynthParser should use Boolean.parseBoolean

On Mon, Apr 9, 2018 at 4:34 PM, Sergey Bylokhov wrote: > Looks fine. > BTW, I am curious can we implement equalsIgnoreCase via || and && instead > of conditional operations to speedup it or not. > Probably not worth too much effort optimizing. Hopefully we're not calling parseBoolean in a tight

Re: [11]JDK-8200605: Create test for GridBagLayoutDemo

Hi Sergey, Thanks for the feedback, this failure was due to a bug in Mac, Component.getLocation() was giving an incorrect/inconsistent initial value when the component is located at (0,0). I have filed a bug for this issue: https://bugs.openjdk.java.net/browse/JDK-8201364 . I have also updated

Re: [11][JDK-4842658] RFR: DefaultListModel and DefaultComboBoxModel should support addAll (Collection c)

Hi Sergey, > Please update the test to catch the difference between v00 and v01. Done. >Some comments about javadoc: > - "183 * " is unnecessary > - Do not use dots at the end of @param/@return tags Done. > - Not sure that the text below is necessary(it is duplicate description of > @

Re: [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description

Hi Pankaj, The change looks fine to me. Thanks, Krishna From: Pankaj Bansal Sent: Tuesday, April 10, 2018 4:27 PM To: swing-dev@openjdk.java.net Subject: [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description Hi All, Please re

[11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description

Hi All, Please review a very simple fix for documentation change enhancement: JDK-8153532: https://bugs.openjdk.java.net/browse/JDK-8153532 Webrev: http://cr.openjdk.java.net/~pbansal/8153532/webrev.00/ CSR: https://bugs.openjdk.java.net/browse/JDK-8201363 UIManager.setLookAndFeel (Stri

JOB | Permanent Java Developer (New York)

Hello, I'm working with an employer that is looking to hire for their New York office a Java developer with an interest in the digital currency market. Consequently I had hoped some members of this mailing list may like to discuss further; off-list. I can be reached using "JamesBTobin (AT) Gmail

Re: [11] JDK-8194873: right ALT key hotkeys no longer work in Swing components

Hello Andrej, Thanks for the quick review. Yes, it does not sense to apply || on same value. It was a typo. Thanks for pointing it out. Webrev: http://cr.openjdk.java.net/~pbansal/8194873/webrev.02/ Regards, Pankaj Bansal -Original Message- From: Andrej Golovnin [mailto:andrej.golov...

Re: [11] JDK-8194873: right ALT key hotkeys no longer work in Swing components

Hi Pankaj, > Webrev: > > http://cr.openjdk.java.net/~pbansal/8194873/webrev.01/ src/java.desktop/windows/native/libawt/windows/awt_Component.cpp 3540 BOOL altIsDown = ((modifiers & java_awt_event_InputEvent_ALT_DOWN_MASK) || 3541 (modifiers & java_awt_event_In

Re: [11] JDK-8194873: right ALT key hotkeys no longer work in Swing components

Hi Prasanta,