[14] RFR JDK-8233634:TESTBUG] Swing text test bug4278839.java fails on macos

2019-11-10 Thread Prasanta Sadhukhan
Hi All, Please review a fix for a test issue seen in mach5 macos system where the test fails intermittently. The test creates a textarea and populates with strings and test cursor movement between words by pressing RIGHT key to move right of each word to go to the end of textarea and then pr

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-10 Thread Pankaj Bansal
The fix look good to me. Some points about test case. 1.  No need for author tag. This is not followed now. 2.  The test case name should be something meaningful instead of bug***. 3.  You should not need the GridBagConstraints code anywhere to reproduce the issue.  You should remo

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-10 Thread Prasanta Sadhukhan
Fix looks ok to me. Regarding the test, dispose() should be called under EDT, just as you have done for createAndShowGUI().Also, I don't think createGridBagLayout() code is necessary to recreate the issue. Regards Prasanta On 08-Nov-19 3:56 PM, Tejpal Rebari wrote: Hi Prasanta , I have added a

Re: [14] RFR JDK-8233696:[TESTBUG]Some jtreg tests fail when CAPS_LOCK is ON

2019-11-10 Thread Jayathirth Rao
Hi Sergey, I tested with get and setLockingKeyState() and it is not supported in all platforms. I got UnsupportedOperationException in Linux and MacOS in our internal test CI system. Also there can be cases where user has set CAPS_LOCK on explicitly and in that case also test should pass or gra