Re: [14] RFR : JDK-4949105 : Access Bridge lacks html tags parsing

Seems OK to me, but I expect Sergey should review this to see if it addresses his concern.s -phil. On 10/31/19 4:57 AM, Ambarish Rapte wrote: Hi Sergey, Thanks for the review, Here is the updated webrev: http://cr.openjdk.java.net/~arapte/a11y/4949105/webrev.01/ Fixed both the review

Re: RFR: JDK-8234386: [macos] NPE was thrown at expanding Choice from maximized frame

Hi Sergey, > One small question about the test, is it necessary to check macOS only? Yes. Keyboard operations by robot are easy to reproduce the problem, but Keyboard don't work for Choice component in other platforms, such as Windows, Linux, Solaris, or AIX. So, I think mac only is

[13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

Hi All, Please review the following fix for jdk14. Bug: https://bugs.openjdk.java.net/browse/JDK-8234733 webrev: http://cr.openjdk.java.net/~pbansal/8234733/webrev00/ Issue: In GTKL, the spinner's up/down buttons are drawn in same way whether the button is pressed or not. We

Re: [14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cause Exception

+1 On 23/11/2019 00:03, Sergey Bylokhov wrote: Looks fine. On 11/21/19 3:00 am, Pankaj Bansal wrote: Hi Sergey, << Is it fine that we pass "-1" to the "adjustWidthHeight"? I am not sure that it is ready for the negative values(where it calculates proportions). Note that prepareImage()