Re: [13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

2019-12-03 Thread Prasanta Sadhukhan
Hi Pankaj, Some comments about the test: I guess since we are testing for Platform.isLinux() in the test, there's no need of "requires" tag. But, I think it's better to use |System.getProperty("os.name") so that this test can be run in standalone mode also(without using Platform class),

Re: [14] RFR JDK-8227607: Broken external links in java.desktop

2019-12-03 Thread Sergey Bylokhov
On 12/3/19 9:28 pm, Philip Race wrote: If not, can you please point to some examples how javadoc inlining is used? Doesn't this just mean copy the content into the JDK sources ? Right. -phil. Regards Prasanta On 04-Dec-19 10:45 AM, Sergey Bylokhov wrote: On 12/3/19 9:08 pm, Prasanta

Re: [14] RFR JDK-8227607: Broken external links in java.desktop

2019-12-03 Thread Philip Race
On 12/3/19, 9:23 PM, Prasanta Sadhukhan wrote: Can't we use the same page/link in the javadoc? We aren't going to point to a web archive which arguably is a copyright violation If not, can you please point to some examples how javadoc inlining is used? Doesn't this just mean copy the

Re: [14] RFR JDK-8227607: Broken external links in java.desktop

2019-12-03 Thread Prasanta Sadhukhan
Can't we use the same page/link in the javadoc? If not, can you please point to some examples how javadoc inlining is used? Regards Prasanta On 04-Dec-19 10:45 AM, Sergey Bylokhov wrote: On 12/3/19 9:08 pm, Prasanta Sadhukhan wrote: Hi Sergey, I could not find the page for

Re: [14] RFR JDK-8227607: Broken external links in java.desktop

2019-12-03 Thread Sergey Bylokhov
On 12/3/19 9:08 pm, Prasanta Sadhukhan wrote: Hi Sergey, I could not find the page for element_interface itself so how to get the information from there? I guess it is the same as you posted before:

Re: [14] RFR JDK-8227607: Broken external links in java.desktop

2019-12-03 Thread Prasanta Sadhukhan
Hi Sergey, I could not find the page for element_interface itself so how to get the information from there? Regards Prasanta On 04-Dec-19 7:31 AM, Sergey Bylokhov wrote: Hi, Prasanta. Probably we can inline some information from the element_interface.html to the JavaDoc itself? The

Re: [14] RFR JDK-8227607: Broken external links in java.desktop

2019-12-03 Thread Sergey Bylokhov
Hi, Prasanta. Probably we can inline some information from the element_interface.html to the JavaDoc itself? The JavaDoc already has some similar schemes. On 12/2/19 2:37 am, Prasanta Sadhukhan wrote: Hi All, Please review a doc-fix for removing some dead links from the specifications. These

Re: [13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

2019-12-03 Thread Pankaj Bansal
Hi Sergey, <<"this behavior happens in native spinner" means after our the fix or before the fix? I meant after the fix. In native, when we press the up/down button, there is change in rendering to show the pressed state. This is not being done in our code before the fix. After the fix, there