Re: [14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key

2020-01-12 Thread Pankaj Bansal
Hello Tejpal, I have few minor comments. You can fix them before pushing this fix. 1. Import individual packages instead of import javax.swing.*. 2. You don't need to create editor1 variable. 3. There should be space after comma editor1,editor2. 4. Rename variables JTextField_Focus_Status, LF

Re: [14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key

2020-01-12 Thread Sergey Bylokhov
Looks fine. On 1/12/20 10:32 pm, Tejpal Rebari wrote: Hi Sergey, On 13-Jan-2020, at 1:15 AM, Sergey Bylokhov mailto:sergey.bylok...@oracle.com>> wrote: Hi, Tejpal Small note that "editor2.getTextField().isFocusOwner()" should be called on EDT, it is a Swing component. I have modified the

Re: [14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key

2020-01-12 Thread Tejpal Rebari
Hi Sergey, > On 13-Jan-2020, at 1:15 AM, Sergey Bylokhov > wrote: > > Hi, Tejpal > > Small note that "editor2.getTextField().isFocusOwner()" should be called on > EDT, it is a Swing component. I have modified the test. webrev : http://cr.openjdk.java.net/~trebari/swing/8223788/webrev3/

Re: [14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key

2020-01-12 Thread Sergey Bylokhov
Hi, Tejpal Small note that "editor2.getTextField().isFocusOwner()" should be called on EDT, it is a Swing component. On 1/10/20 1:32 am, Tejpal Rebari wrote: Hi Sergey, I had removed the colorchooser and created a frame and added two spinner to it. Then noticed that the issue is reproducible