Re: [15] RFR JDK-8216329: Cannot resize CheckBoxItemMenu in Synth L&F with setHorizontalTextPosition

2020-01-23 Thread Sergey Bylokhov
Hi, Pankaj. The updateCheckIcon() was a private method in the public class from the javax.swing.plaf.basic package you cannot simply make it protected. Can you please provide some more details why the call to updateCheckIcon() break the resize? On 1/23/20 3:05 am, Pankaj Bansal wrote: Hi All,

[15] RFR JDK-8216329: Cannot resize CheckBoxItemMenu in Synth L&F with setHorizontalTextPosition

2020-01-23 Thread Pankaj Bansal
Hi All, Please review the following fix for jdk15. Bug: https://bugs.openjdk.java.net/browse/JDK-8216329 webrev: http://cr.openjdk.java.net/~pbansal/8216329/webrev00/ Issue: The JCheckBoxMenuItem is not being resized properly when setHorizontalTextPosition is called on it. This resu

Re: [15] Review Request: 8237746 Fixing compiler warnings in src/demo/share/jfc

2020-01-23 Thread Marc Hoffmann
Hi Sergey, thanks for sponsoring this patch! I successfully applied the webrev patch on current JDK head (57807:7bae17e00566). The build runs without warnings on the demo code :) But I noticed a minor glitch: I inserted a tab in src/demo/share/jfc/SwingSet2/DirectionPanel.java Line 97 where on