Re: Remove System.out.println from ImageIcon.loadImage

Looks good to me. From: Volodin, Vladislav Sent: Saturday, February 22, 2020 4:38 AM To: Jason Mehrens Cc: swing-dev@openjdk.java.net Subject: Re: Remove System.out.println from ImageIcon.loadImage Hello Jason and everyone else, here is my webrev that m

Re: [15] RFR JDK-8231042: [macos] JFileChooser creates new folder on ESC

Hi Sergey, Thanks for the review. << It would be good to filter out the test on non-mac systems by the "@requires" tag. I added the filter in main method, so if someone is running this as standalone test, even then the test is filtered out. But yes, adding the tag is useful when using jtreg to

Re: [15] RFR JDK-8231042: [macos] JFileChooser creates new folder on ESC

Hi, Pankaj. It would be good to filter out the test on non-mac systems by the "@requires" tag. On 2/25/20 8:43 am, Pankaj Bansal wrote: Hi All, Please review the following fix for jdk15. Bug: https://bugs.openjdk.java.net/browse/JDK-8231042 webrev: http://cr.openjdk.java.net/~pbansal/823

Re: [15] RFR JDK-8239902: Remove direct usage of JSlider, JProgressBar classes in CAccessible class

Looks fine. On 2/27/20 2:45 am, Pankaj Bansal wrote: Hi All, Please review the following fix for jdk15. Bug: https://bugs.openjdk.java.net/browse/JDK-8239902 webrev: http://cr.openjdk.java.net/~pbansal/8239902/webrev00/ Issue: In class CAccessible, the JSlider and JProgressBar class are

[15] RFR JDK-8239902: Remove direct usage of JSlider, JProgressBar classes in CAccessible class

Hi All, Please review the following fix for jdk15. Bug: https://bugs.openjdk.java.net/browse/JDK-8239902 webrev: http://cr.openjdk.java.net/~pbansal/8239902/webrev00/ Issue: In class CAccessible, the JSlider and JProgressBar class are being used directly, as it is adding changeListe