Re: RFR: 8241233 Typo in problem listing of UIDefaultKeySizeTest.java

2020-03-18 Thread Jayathirth D v
Looks good to me. Thanks, Jay > On 19-Mar-2020, at 7:09 AM, Philip Race wrote: > > This is a bit of an oops but the fix > https://bugs.openjdk.java.net/browse/JDK-8241229 > included the "jdk/" parent directory in the path name of the file to be > excluded. > > bug:

RFR: 8241233 Typo in problem listing of UIDefaultKeySizeTest.java

2020-03-18 Thread Philip Race
This is a bit of an oops but the fix https://bugs.openjdk.java.net/browse/JDK-8241229 included the "jdk/" parent directory in the path name of the file to be excluded. bug: https://bugs.openjdk.java.net/browse/JDK-8241233 fix: diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt

Re: RFR: 8241229: Problem list jdk/javax/swing/UIDefaults/8146330/UIDefaultKeySizeTest.java

2020-03-18 Thread Sergey Bylokhov
On 3/18/20 2:54 pm, Philip Race wrote: On 3/18/20, 2:52 PM, Sergey Bylokhov wrote: On 3/18/20 2:41 pm, Philip Race wrote: That is one possible solution that I mentioned, but I am not sure it is the right one. Needs investigating by the RE. It is an ok thing, the L might be unsupported on

Re: RFR: 8241229: Problem list jdk/javax/swing/UIDefaults/8146330/UIDefaultKeySizeTest.java

2020-03-18 Thread Alexey Ivanov
Hi Phil, On 18/03/2020 21:54, Philip Race wrote: On 3/18/20, 2:52 PM, Sergey Bylokhov wrote: On 3/18/20 2:41 pm, Philip Race wrote: That is one possible solution that I mentioned, but I am not sure it is the right one. Needs investigating by the RE. It is an ok thing, the L might be

Re: RFR 8241078: OOM error parsing HTML with large Tag text

2020-03-18 Thread Alexey Ivanov
Hi Prasanta, Looks good to me too. On 18/03/2020 21:59, Sergey Bylokhov wrote: Looks fine. On 3/17/20 8:54 pm, Prasanta Sadhukhan wrote: Hi Sergey, Test updated http://cr.openjdk.java.net/~psadhukhan/8241078/webrev.1/ Regards Prasanta On 17-Mar-20 11:48 PM, Sergey Bylokhov wrote: HI,

Re: RFR JDK-8226230:Test javax/swing/JInternalFrame/8020708/bug8020708.java fails on Ubuntu

2020-03-18 Thread Sergey Bylokhov
Looks fine. On 3/18/20 6:25 am, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where this test fails in ubuntu citing " Close mnemonic does not work in [The CDE/Motif Look and Feel - com.sun.java.swing.plaf.motif.MotifLookAndFeel]" Issue was in the test where subsequent

Re: RFR 8241078: OOM error parsing HTML with large Tag text

2020-03-18 Thread Sergey Bylokhov
Looks fine. On 3/17/20 8:54 pm, Prasanta Sadhukhan wrote: Hi Sergey, Test updated http://cr.openjdk.java.net/~psadhukhan/8241078/webrev.1/ Regards Prasanta On 17-Mar-20 11:48 PM, Sergey Bylokhov wrote: HI, Prasanta. I suggest to limit memory in the test by the "-mx", otherwise the test

Re: RFR: 8241229: Problem list jdk/javax/swing/UIDefaults/8146330/UIDefaultKeySizeTest.java

2020-03-18 Thread Sergey Bylokhov
On 3/18/20 2:41 pm, Philip Race wrote: That is one possible solution that I mentioned, but I am not sure it is the right one. Needs investigating by the RE. It is an ok thing, the L might be unsupported on some specific platform even if returned in the installed L list. Other possible thing is

Re: RFR: 8241229: Problem list jdk/javax/swing/UIDefaults/8146330/UIDefaultKeySizeTest.java

2020-03-18 Thread Philip Race
On 3/18/20, 2:52 PM, Sergey Bylokhov wrote: On 3/18/20 2:41 pm, Philip Race wrote: That is one possible solution that I mentioned, but I am not sure it is the right one. Needs investigating by the RE. It is an ok thing, the L might be unsupported on some specific platform even if returned

Re: RFR: 8241229: Problem list jdk/javax/swing/UIDefaults/8146330/UIDefaultKeySizeTest.java

2020-03-18 Thread Philip Race
That is one possible solution that I mentioned, but I am not sure it is the right one. Needs investigating by the RE. Meanwhile this is about the problem list so it does not fail tomorrow. -phil. On 3/18/20, 2:32 PM, Sergey Bylokhov wrote: I guess that bug easy to fix, just need to add

Re: RFR: 8241229: Problem list jdk/javax/swing/UIDefaults/8146330/UIDefaultKeySizeTest.java

2020-03-18 Thread Sergey Bylokhov
I guess that bug easy to fix, just need to add headful keyword to the test. On 3/18/20 2:28 pm, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8241229 We only need to problem list on linux & solaris : diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt ---

RFR: 8241229: Problem list jdk/javax/swing/UIDefaults/8146330/UIDefaultKeySizeTest.java

2020-03-18 Thread Philip Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8241229 We only need to problem list on linux & solaris : diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt +++ b/test/jdk/ProblemList.txt @@ -808,6 +808,7 @@

RFR JDK-8226230:Test javax/swing/JInternalFrame/8020708/bug8020708.java fails on Ubuntu

2020-03-18 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue where this test fails in ubuntu citing " Close mnemonic does not work in [The CDE/Motif Look and Feel - com.sun.java.swing.plaf.motif.MotifLookAndFeel]" Issue was in the test where subsequent frame with JInternalFrame were created almost