Re: RFR: 8238085 PIT: javax/swing/JSpinner/8223788/JSpinnerButtonFocusTest.java fails on mac

Hi Sergey, > On 07-May-2020, at 3:11 AM, Sergey Bylokhov > wrote: > > Hi, Tejpal. > > Please confirm that the update test still fail before the fix of JDK-8223788. Yes I verified that the test fails without the fix of JDK-8223788. > > On 5/6/20 11:38 am, Tejpal Rebari wrote: >> Issue : The

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports - (client/desktop)

Sergey/Shura, thank you for the reviews. I reverted the Jemmy changes, and found some additional Sun Studio cleanups. New webrev here: webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/client/open/webrev/ incremental: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webr

Re: RFR JDK-8242410: JEditorPane with test/html type and zero margins is not shown

On 4/22/20 2:35 am, Prasanta Sadhukhan wrote: I think since this fix is more about margin, it should be placed in more appropriate class related to borders/margin so I have placed my fix in BasicBorders and not in BasicTextUI. Does it mean that the next line in the test: pane.setMargin(new

Re: RFR: 8238085 PIT: javax/swing/JSpinner/8223788/JSpinnerButtonFocusTest.java fails on mac

Hi, Tejpal. Please confirm that the update test still fail before the fix of JDK-8223788. On 5/6/20 11:38 am, Tejpal Rebari wrote: Issue : The test JSpinnerButtonFocusTest fails in nightly testing on Mac OS  platform. What was the root cause of the failure? Fix : Reduced the number of keyP

Re: RFR JDK-8238824: [macos] javax/swing/JSpinner/4840869/bug4840869.java fails on macos

Hi, Prasanta. The fix looks fine, but can we improve the test and check all L&Fs? The same installListeners is overridden in the SynthSpinnerUI, and it will be good to check that it works as well. On 5/6/20 1:02 am, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue in macOS

RFR: 8238085 PIT: javax/swing/JSpinner/8223788/JSpinnerButtonFocusTest.java fails on mac

Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8238085 Fix : http://cr.openjdk.java.net/~trebari/swing/8238085/webrev00/

Re: RFR: 8229856 [macos] Opening a menu on a JTextField can clear the text selection

Hi Prasanta, > On 06-May-2020, at 5:11 PM, Prasanta Sadhukhan > wrote: > > Looks good to me. But one question, do you require showPopupMenu() on > mouseReleased() too? > It doesn’t have any effect. I just kept it because it was there in submitted test [JBS]. Thanks and regards Tejpal

Re: RFR: 8229856 [macos] Opening a menu on a JTextField can clear the text selection

Looks good to me. But one question, do you require showPopupMenu() on mouseReleased() too? Regards Prasanta On 06-May-20 9:43 AM, Tejpal Rebari wrote: Hi Prasanta, On 22-Apr-2020, at 1:59 PM, Prasanta Sadhukhan > wrote: Hi Tejpal, Does it need to be t

Re: RFR JDK-8067986: Test javax/swing/JComboBox/ConsumedKeyTest/ConsumedKeyTest.java fails

ping? On 27-Apr-20 9:32 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that ComboBox is consuming Enter key without taking action on it. The test was introduced by JDK-8058193 where the "Escape" and "Enter" key problem for ComboBox was fixed for mac,

Re: RFR JDK-8242410: JEditorPane with test/html type and zero margins is not shown

ping? On 22-Apr-20 3:05 PM, Prasanta Sadhukhan wrote: The regression caused by change in this method was because the rootView layout was changed in those fix(es), but this code is only changing the preferredSize height but I can understand the scepticism. I think since this fix is more about

RFR JDK-8238824: [macos] javax/swing/JSpinner/4840869/bug4840869.java fails on macos

Hi All, Please review a fix for an issue in macOS where it is seen that JSpinner keeps spinning while JOptionPane is shown on ChangeListener. This is continuation of JDK-4840869 fix where it was fixed for BasicSpinnerUI but it still fails in macOS as AquaSpinnerUI has overridden the fixed metho