Re: RFR: 8199529 : javax/swing/text/Utilities/8142966/SwingFontMetricsTest.java fails on windows

2020-05-18 Thread Philip Race
On 5/18/20, 9:53 PM, Sergey Bylokhov wrote: On 5/17/20 8:27 pm, Philip Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8199529 webrev : http://cr.openjdk.java.net/~prr/8199529/ The problem is that the test assumes LCD AA is set on the graphics when in fact Swing sets that hint jus

Re: RFR: 8199529 : javax/swing/text/Utilities/8142966/SwingFontMetricsTest.java fails on windows

2020-05-18 Thread Sergey Bylokhov
On 5/17/20 8:27 pm, Philip Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8199529 webrev : http://cr.openjdk.java.net/~prr/8199529/ The problem is that the test assumes LCD AA is set on the graphics when in fact Swing sets that hint just before rendering test and reverts it afterwards

Re: RFR: 8233559 [TESTBUG] TestNimbusOverride.java is failing on macos

2020-05-18 Thread Pankaj Bansal

Re: RFR: 8233559 [TESTBUG] TestNimbusOverride.java is failing on macos

2020-05-18 Thread Pankaj Bansal
I am not very sure if we should be removing tests from the ProblemList on basis of individual test runs. The test may be failing because of some other test and we should find the reason for the same. One quick question, is the test passing continuously now in nightly builds? Regards, Pankaj

Re: RFR: 8233559 [TESTBUG] TestNimbusOverride.java is failing on macos

2020-05-18 Thread Prasanta Sadhukhan
Looks good to me. Regards Prasanta On 18-May-20 3:41 PM, Tejpal Rebari wrote: Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233559 Webrev : http://cr.openjdk.java.net/~trebari/swing/8233559/webrev00/ This test was added to the prob

RFR: 8233559 [TESTBUG] TestNimbusOverride.java is failing on macos

2020-05-18 Thread Tejpal Rebari
Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233559 Webrev : http://cr.openjdk.java.net/~trebari/swing/8233559/webrev00/

Re: RFR: 8245165: Update bug id for javax/swing/text/StyledEditorKit/4506788/bug4506788.java in ProblemList

2020-05-18 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 18-May-20 3:24 PM, Jayathirth D v wrote: Hello All, Please review the following fix in JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-8245165 Webrev : http://cr.openjdk.java.net/~jdv/8245165/webrev.00/ Fixing copy paste error in ProblemList. Thanks, Jay

RFR: 8245165: Update bug id for javax/swing/text/StyledEditorKit/4506788/bug4506788.java in ProblemList

2020-05-18 Thread Jayathirth D v
Hello All, Please review the following fix in JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-8245165 Webrev : http://cr.openjdk.java.net/~jdv/8245165/webrev.00/ Fixing copy paste er