Re: [15] RFR : 8249278 : Revert JDK-8226253 which breaks the spec of AccessibleState.SHOWING for JList

Hello Phil, Thanks for the review and correcting the mail group, Please take a look at the updated webrev with C years also backed out: http://cr.openjdk.java.net/~arapte/a11y/8249278/webrev.1 Regards, Ambarish. From: Philip Race Sent: Wednesday, July 15, 2020 2:00 AM To: Ambarish

Re: RFR: 8249251: [dark_mode ubuntu 20.04] The selected menu is not highlighted in GTKLookAndFeel

On 14.07.2020 12:06, Pankaj Bansal wrote: Hi Sergey, Thanks for the review. Please see my comments inline. Following the new webrev webrev: http://cr.openjdk.java.net/~pbansal/8249251/webrev02/ Looks fine. On 14/07/20 12:43 PM,

Re: [15] RFR : 8249278 : Revert JDK-8226253

adding swing-dev which is the correct list for this Swing change. It looks like a faithful backout of https://bugs.openjdk.java.net/browse/JDK-8226253 https://hg.openjdk.java.net/jdk/jdk/rev/3ea8a0c5c264 except that the (c) year is remaining 2020 .. which I think just indicates the silliness of

Re: RFR: 8249251: [dark_mode ubuntu 20.04] The selected menu is not highlighted in GTKLookAndFeel

Hi Sergey, Thanks for the review. Please see my comments inline. Following the new webrev webrev: http://cr.openjdk.java.net/~pbansal/8249251/webrev02/ On 14/07/20 12:43 PM, Sergey Bylokhov wrote: Hi, Pankaj. A few notes about the

Re: RFR JDK-8245785: javax.swing.JTabbedPane cannot be deserialized

On 13-Jul-20 8:07 PM, Philip Race wrote: The regression test needs some clean up. It seems to be a copy+paste of the submitter's test case including the comment in German which can be removed. Also IMO all the English comments are stating the obvious and don't need to be there. And use

Re: RFR: 8249251: [dark_mode ubuntu 20.04] The selected menu is not highlighted in GTKLookAndFeel

Hi, Pankaj. A few notes about the fix and test: - The usage of textarea selection as a temporal solution is fine, but did you notice that mouse over effect over JButtons in the SwingSet use correct "light color"? Did you tried to check can we use it for menu as well? - The test should not