Re: RFR: 8247753: UIManager.getSytemLookAndFeelClassName() returns wrong value on Fedora 32

Looks ok to me. One observation is, in testcase you can remove line71 linux check as we already did the check in l54. Regards Prasanta On 04-Aug-20 11:12 PM, Pankaj Bansal wrote: Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8247753

Re: RFR JDK-8250811: Address reliance on default constructors in the javax.swing.plaf.multi APIs

I guess since it is mentioned in the coding guidelines, we should follow that. We should try changing the event package and others, if time permits to match coding guidelines. But having said that, I am open to follow whatever you leads decide. Regards Prasanta On 05-Aug-20 8:17 AM, Sergey

Re: RFR JDK-8250811: Address reliance on default constructors in the javax.swing.plaf.multi APIs

On 04.08.2020 14:05, Philip Race wrote: Section 6.4 of the 23 year old coding guidelines https://www.oracle.com/technetwork/java/codeconventions-150003.pdf appear to suggest {} for empty methods. However I know this only because I went to look. I would have guessed the opposite .. and prefer

[16] RFR 8136363: Nimbus-LaF: background color cleared when setting component name of JToolBar

Hello, Could you review a fix for jdk16, please? Webrev: http://cr.openjdk.java.net/~dmarkov/8136363/webrev/ Bug: https://bugs.openjdk.java.net/browse/JDK-8136363 Problem Description: Nimbus-LaF: background color cleared when setting component name of JToolbar Fix: The

possible swing bug

Dear Madam or Sir, at https://stackoverflow.com/questions/62906739/java-swing-hebrew-font-scaling-problem-with-high-dpi-screen-scaling/62906773#62906773 I describe a possible bug with Java Swing. Do you have any idea what I could do about that problem? With kind regards, Birke Heeren Birke

Re: RFR JDK-8250811: Address reliance on default constructors in the javax.swing.plaf.multi APIs

Section 6.4 of the 23 year old coding guidelines https://www.oracle.com/technetwork/java/codeconventions-150003.pdf appear to suggest {} for empty methods. However I know this only because I went to look. I would have guessed the opposite .. and prefer that opposite. -phil. On 8/3/20, 11:44

Re: RFR JDK-6709913: BasicComboBoxUI.isPopupVisible returns NullPointerException

Looks fine. On 04.08.2020 02:56, Prasanta Sadhukhan wrote: OK. Please find modified http://cr.openjdk.java.net/~psadhukhan/6709913/webrev.1/ Regards Prasanta On 04-Aug-20 12:22 PM, Sergey Bylokhov wrote: Hi, Prasanta. I suggest making the change in the isPopupVisible shorter:     return

RFR: 8247753: UIManager.getSytemLookAndFeelClassName() returns wrong value on Fedora 32

Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8247753 webrev: http://cr.openjdk.java.net/~pbansal/8247753/webrev00 Bug: UIManager.getSytemLookAndFeelClassName() returns wrong value on

Re: RFR JDK-6709913: BasicComboBoxUI.isPopupVisible returns NullPointerException

OK. Please find modified http://cr.openjdk.java.net/~psadhukhan/6709913/webrev.1/ Regards Prasanta On 04-Aug-20 12:22 PM, Sergey Bylokhov wrote: Hi, Prasanta. I suggest making the change in the isPopupVisible shorter:     return popup != null && popup.isVisible(); On 29.07.2020 23:18,

Re: RFR JDK-6709913: BasicComboBoxUI.isPopupVisible returns NullPointerException

Hi, Prasanta. I suggest making the change in the isPopupVisible shorter: return popup != null && popup.isVisible(); On 29.07.2020 23:18, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue whereby javax.swing.plaf.basic.BasicComboBoxUI.isPopupVisible returns

Re: RFR JDK-8250811: Address reliance on default constructors in the javax.swing.plaf.multi APIs

On 04-Aug-20 12:01 PM, Sergey Bylokhov wrote: Hi, Prasanta. I think a good place for a constructor is after the declaration of the fields and before the methods. BTW I am not sure about the "one line" "{}" type of brackets, do we use it somewhere? For example in some classes like a

Re: RFR JDK-8250811: Address reliance on default constructors in the javax.swing.plaf.multi APIs

Hi, Prasanta. I think a good place for a constructor is after the declaration of the fields and before the methods. BTW I am not sure about the "one line" "{}" type of brackets, do we use it somewhere? For example in some classes like a java.awt.Canvas uses brackets on different lines. On

Re: RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

Hi Phil, I have updated the path of the test. Updated webrev : http://cr.openjdk.java.net/~trebari/swing/8249674/webrev02/ Thanks Tejpal > On 01-Aug-2020, at 9:41 PM, Philip Race wrote: > > We've been trying to get away from using

Re: RFR: 8239137: JAWS does not always announce the value of JSliders in JColorChooser

Hello Sergey, I have created the CSR. Please have a look. https://bugs.openjdk.java.net/browse/JDK-8251002 Regards, Pankaj On 28/07/20 6:08 AM, Sergey Bylokhov wrote: Looks fine. Please note you will need a CSR for this change. On 19.07.2020 11:28, Pankaj Bansal wrote: Hi All, Please