Integrated: 8233562: [TESTBUG] Swing StyledEditorKit test bug4506788.java fails on MacOS

2020-11-02 Thread Jayathirth D V
On Tue, 3 Nov 2020 06:09:51 GMT, Jayathirth D V wrote: > This issue is related to not giving permission for terminal to control things > in System Preferences -> Security & privacy -> Privacy -> Accessibility. > > I have verified the test in our CI and removed it from problemlist. There are >

Re: RFR: 8233562: [TESTBUG] Swing StyledEditorKit test bug4506788.java fails on MacOS [v2]

2020-11-02 Thread Jayathirth D V
> This issue is related to not giving permission for terminal to control things > in System Preferences -> Security & privacy -> Privacy -> Accessibility. > > I have verified the test in our CI and removed it from problemlist. There are > small tweaks in test also. Jayathirth D V has updated

Integrated: 8233561: [TESTBUG] Swing text test bug8014863.java fails on macos

2020-11-02 Thread Jayathirth D V
On Tue, 3 Nov 2020 05:48:13 GMT, Jayathirth D V wrote: > This issue is related to not giving permission for terminal to control things > in System Preferences -> Security & privacy -> Privacy -> Accessibility. > > I have verified the test in our CI and removed it from problemlist. There are >

Re: RFR: 8233562: [TESTBUG] Swing StyledEditorKit test bug4506788.java fails on MacOS

2020-11-02 Thread Prasanta Sadhukhan
On Tue, 3 Nov 2020 06:09:51 GMT, Jayathirth D V wrote: > This issue is related to not giving permission for terminal to control things > in System Preferences -> Security & privacy -> Privacy -> Accessibility. > > I have verified the test in our CI and removed it from problemlist. There are >

Re: RFR: 8233561: [TESTBUG] Swing text test bug8014863.java fails on macos

2020-11-02 Thread Prasanta Sadhukhan
On Tue, 3 Nov 2020 05:48:13 GMT, Jayathirth D V wrote: > This issue is related to not giving permission for terminal to control things > in System Preferences -> Security & privacy -> Privacy -> Accessibility. > > I have verified the test in our CI and removed it from problemlist. There are >

RFR: 8233562: [TESTBUG] Swing StyledEditorKit test bug4506788.java fails on MacOS

2020-11-02 Thread Jayathirth D V
This issue is related to not giving permission for terminal to control things in System Preferences -> Security & privacy -> Privacy -> Accessibility. I have verified the test in our CI and removed it from problemlist. There are small tweaks in test also. - Commit messages: -

RFR: 8233561: [TESTBUG] Swing text test bug8014863.java fails on macos

2020-11-02 Thread Jayathirth D V
This issue is related to not giving permission for terminal to control things in System Preferences -> Security & privacy -> Privacy -> Accessibility. I have verified the test in our CI and removed it from problemlist. There are small tweaks in test also. - Commit messages: -

Integrated: 8196089: javax/swing/Action/8133039/bug8133039.java fails

2020-11-02 Thread Prasanta Sadhukhan
On Thu, 29 Oct 2020 12:11:33 GMT, Prasanta Sadhukhan wrote: > Please review a test fix for an issue seen to be failing on mach5 systems due > to timing issue. > Adjusted the autoDelay time and moved the frame to center of screen. > Mach5 job has been run for several iterations in all

Re: RFR: 8196089: javax/swing/Action/8133039/bug8133039.java fails

2020-11-02 Thread Jayathirth D V
On Mon, 2 Nov 2020 12:50:33 GMT, Prasanta Sadhukhan wrote: >> any comment on this review? > > ping? Looks like this is also related to giving permission to terminal in System Preferences -> Security & Privacy -> Privacy -> Accessibility. If we dont give permission the test fails.

Re: RFR: 8196089: javax/swing/Action/8133039/bug8133039.java fails

2020-11-02 Thread Jayathirth D V
On Thu, 29 Oct 2020 12:11:33 GMT, Prasanta Sadhukhan wrote: > Please review a test fix for an issue seen to be failing on mach5 systems due > to timing issue. > Adjusted the autoDelay time and moved the frame to center of screen. > Mach5 job has been run for several iterations in all

Re: RFR: 7190978: javax/swing/JComponent/7154030/bug7154030.java fails on mac

2020-11-02 Thread Phil Race
On Mon, 2 Nov 2020 12:50:22 GMT, Prasanta Sadhukhan wrote: >> Then please double-check that the test will pass after the fix on HiDPI >> screen. Not sure that -Dsun.java2d.uiScale=1 affects such usecase. > > Since mach5 systems are mostly macmini, where it initially failed, and the >

Re: RFR: 7190978: javax/swing/JComponent/7154030/bug7154030.java fails on mac

2020-11-02 Thread Prasanta Sadhukhan
On Mon, 2 Nov 2020 12:19:06 GMT, Sergey Bylokhov wrote: >> It was reported in macmini (probably connect to hidpi screen) and iMac (I >> guess having hidpi screen). >> Also, I have seen mach5 job failing on windows too. >> I have posted failing mach5 jobs in JBS. > > Then please double-check

Integrated: 6816284: Notepad class should be public

2020-11-02 Thread Sergey Bylokhov
On Sun, 1 Nov 2020 01:30:46 GMT, Sergey Bylokhov wrote: > The main class in the Notepad demo made public This pull request has now been integrated. Changeset: ceab9f32 Author:Sergey Bylokhov URL: https://git.openjdk.java.net/jdk/commit/ceab9f32 Stats: 2 lines in 1 file changed:

Integrated: 7124397: [macosx] JSpinner serialiazation - deserialization issue

2020-11-02 Thread Sergey Bylokhov
On Sun, 1 Nov 2020 23:12:10 GMT, Sergey Bylokhov wrote: > The serialization was broken because different listeners are leaked in the > case of compound components. > That listeners also caused memory leaks which were fixed by a few fixes here > and there, and in jdk16 the serialization start

Re: RFR: 7190978: javax/swing/JComponent/7154030/bug7154030.java fails on mac

2020-11-02 Thread Sergey Bylokhov
On Sat, 31 Oct 2020 11:06:52 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/JComponent/7154030/bug7154030.java line 55: >> >>> 53: * @build Util >>> 54: * @build ExtendedRobot >>> 55: * @run main/othervm -Dsun.java2d.uiScale=1 bug7154030 >> >> The "sun.java2d.uiScale" does not

Re: RFR: 8251177: [macosx] The text "big" is truncated

2020-11-02 Thread Sergey Bylokhov
On Mon, 2 Nov 2020 12:11:34 GMT, Pankaj Bansal wrote: > > I meant to limit the font size in the tab-pane. > > ok, just for clarification, you mean this should be fixed as product bug not > test issue? We should limit the font size in AquaJTabbedPaneUI, so that the > text is not truncated?

Re: RFR: 7124397: [macosx] JSpinner serialiazation - deserialization issue [v2]

2020-11-02 Thread Pankaj Bansal
On Mon, 2 Nov 2020 11:56:12 GMT, Sergey Bylokhov wrote: >> The serialization was broken because different listeners are leaked in the >> case of compound components. >> That listeners also caused memory leaks which were fixed by a few fixes here >> and there, and in jdk16 the serialization

Re: RFR: 7124397: [macosx] JSpinner serialiazation - deserialization issue [v2]

2020-11-02 Thread Sergey Bylokhov
> The serialization was broken because different listeners are leaked in the > case of compound components. > That listeners also caused memory leaks which were fixed by a few fixes here > and there, and in jdk16 the serialization start to work fine. But I would > like to contribute the test

Re: RFR: 8251177: [macosx] The text "big" is truncated

2020-11-02 Thread Sergey Bylokhov
On Mon, 2 Nov 2020 10:49:00 GMT, Pankaj Bansal wrote: >> Probably it is better to limit the size of the font? > >> Probably it is better to limit the size of the font? > > Ok, I have reduced the font size. Now the text size if such that it is bigger > than other texts, but text would fit

Re: RFR: 6816284: Notepad class should be public

2020-11-02 Thread Pankaj Bansal
On Sun, 1 Nov 2020 01:30:46 GMT, Sergey Bylokhov wrote: > The main class in the Notepad demo made public Marked as reviewed by pbansal (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/980

Re: RFR: 7124397: [macosx] JSpinner serialiazation - deserialization issue

2020-11-02 Thread Pankaj Bansal
On Sun, 1 Nov 2020 23:12:10 GMT, Sergey Bylokhov wrote: > The serialization was broken because different listeners are leaked in the > case of compound components. > That listeners also caused memory leaks which were fixed by a few fixes here > and there, and in jdk16 the serialization start

Re: RFR: 8251177: [macosx] The text "big" is truncated

2020-11-02 Thread Pankaj Bansal
On Sun, 1 Nov 2020 23:58:04 GMT, Sergey Bylokhov wrote: > Probably it is better to limit the size of the font? Ok, I have reduced the font size. Now the text size if such that it is bigger than other texts, but text would fit within the tab height and text is not truncated. -

Integrated: 8233637: [TESTBUG] Swing ActionListenerCalledTwiceTest.java fails on macos

2020-11-02 Thread Prasanta Sadhukhan
On Thu, 29 Oct 2020 09:21:04 GMT, Prasanta Sadhukhan wrote: > Please review a test fix for a test issue seen to be failing on mach5 macos > systems due to timing issue. > Modified the test to added delay() after frame is made visible and moved the > frame to centre of screen to be consistent

Integrated: 8233641: [TESTBUG] JMenuItem test bug4171437.java fails on macos

2020-11-02 Thread Prasanta Sadhukhan
On Thu, 29 Oct 2020 05:09:24 GMT, Prasanta Sadhukhan wrote: > Please review a test fix for a test issue seen to be failing on mach5 macos > systems due to timing issue. > Modified the test to modify setAutoDelay() time, added delay() after frame is > made visible and moved the frame to centre

Re: RFR: 8233637: [TESTBUG] Swing ActionListenerCalledTwiceTest.java fails on macos

2020-11-02 Thread Jayathirth D V
On Thu, 29 Oct 2020 09:21:04 GMT, Prasanta Sadhukhan wrote: > Please review a test fix for a test issue seen to be failing on mach5 macos > systems due to timing issue. > Modified the test to added delay() after frame is made visible and moved the > frame to centre of screen to be consistent

Re: RFR: 8233637: [TESTBUG] Swing ActionListenerCalledTwiceTest.java fails on macos

2020-11-02 Thread Jayathirth D V
On Mon, 2 Nov 2020 03:39:31 GMT, Jayathirth D V wrote: >> Please ask @jayathirthrao, who was able to reproduce this bug on the local >> system, about approval. > > I tested with or without fix in my local system with all the settings that we > do for jtreg tests but still it fails in my

Re: RFR: 8233641: [TESTBUG] JMenuItem test bug4171437.java fails on macos

2020-11-02 Thread Jayathirth D V
On Thu, 29 Oct 2020 05:09:24 GMT, Prasanta Sadhukhan wrote: > Please review a test fix for a test issue seen to be failing on mach5 macos > systems due to timing issue. > Modified the test to modify setAutoDelay() time, added delay() after frame is > made visible and moved the frame to centre

Re: RFR: 8233641: [TESTBUG] JMenuItem test bug4171437.java fails on macos

2020-11-02 Thread Jayathirth D V
On Mon, 2 Nov 2020 03:39:18 GMT, Jayathirth D V wrote: >> Please ask @jayathirthrao, who was able to reproduce this bug on the local >> system, about approval. > > I tested with or without fix in my local system with all the settings that we > do for jtreg tests but still it fails in my

Re: RFR: 8255215: Unsupported 'valign' attribute for 'tr' tag used in j.s.t.h.HTMLDocument

2020-11-02 Thread Sergey Bylokhov
On Mon, 2 Nov 2020 08:18:44 GMT, Prasanta Sadhukhan wrote: > Since HTML4 support has been dropped from javadoc by JDK-8187793. > HTMLDocument.java containing the valign attribute in the table element, > `valign="top"` > needs to be replaced with `style="vertical-align:top" Marked as reviewed

RFR: 8255215: Unsupported 'valign' attribute for 'tr' tag used in j.s.t.h.HTMLDocument

2020-11-02 Thread Prasanta Sadhukhan
Since HTML4 support has been dropped from javadoc by JDK-8187793. HTMLDocument.java containing the valign attribute in the table element, `valign="top"` needs to be replaced with `style="vertical-align:top" - Commit messages: - 8255215: Unsupported 'valign' attribute for 'tr' tag