I think this statement is over-constraining the UI behavior.
What the password field displays does not have to be text in the ordinary sense
of the word. It could be a series of large dots. It is really up to the UI.
Also, the sentence is turned around. It should not start with the “text
On Thu, 3 Jun 2021 01:23:25 GMT, Sergey Bylokhov wrote:
>> I do not like the phrase "Although the text displayed in", the "text" is not
>> displayed in the JPasswordField per se, please suggest something else.
>
> "The text entered in {@code JPasswordField} displays that something was typed
>
On Thu, 3 Jun 2021 01:02:56 GMT, Sergey Bylokhov wrote:
>> Another way of phrasing it would be
>>
>> The text displayed in {@code JPasswordField} shows you that something was
>> typed but does not show the original characters.
>>
>> Note "that something" not "something that" and the rest of
On Thu, 3 Jun 2021 00:57:02 GMT, Phil Race wrote:
>> So in case that wasn't clear, please change it to ny version
>
> Another way of phrasing it would be
>
> The text displayed in {@code JPasswordField} shows you that something was
> typed but does not show the original characters.
>
> Note
On Thu, 3 Jun 2021 00:46:04 GMT, Phil Race wrote:
>> The previous text you refer to is presumably
>> "where the view indicates something was typed,"
>>
>> that is fine. Your text is trying to say something else AND you added the
>> word that which means you are referring to the specific thing
On Thu, 3 Jun 2021 00:45:40 GMT, Phil Race wrote:
>> The "something was typed" text is used already in the description of the
>> JPasswordField, in the first sentence.
>>
>> Not sure that the word "text" in the "Although the text displayed" is the
>> correct one. It is not necessary a "text"
On Thu, 3 Jun 2021 00:31:22 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/share/classes/javax/swing/JPasswordField.java line 64:
>>
>>> 62: *
>>> 63: * Warning: The text entered in {@code JPasswordField}
>>> displays
>>> 64: * something that was typed and does not show the original
On Thu, 3 Jun 2021 00:16:28 GMT, Phil Race wrote:
>> Some useful documentation was added to the JPasswordField.
>
> src/java.desktop/share/classes/javax/swing/JPasswordField.java line 64:
>
>> 62: *
>> 63: * Warning: The text entered in {@code JPasswordField}
>> displays
>> 64: * something
On Wed, 2 Jun 2021 01:14:39 GMT, Sergey Bylokhov wrote:
> Some useful documentation was added to the JPasswordField.
src/java.desktop/share/classes/javax/swing/JPasswordField.java line 64:
> 62: *
> 63: * Warning: The text entered in {@code JPasswordField}
> displays
> 64: * something
On Wed, 2 Jun 2021 01:14:39 GMT, Sergey Bylokhov wrote:
> Some useful documentation was added to the JPasswordField.
The CSR is filed: https://bugs.openjdk.java.net/browse/JDK-8268149
Please take a look.
-
PR: https://git.openjdk.java.net/jdk/pull/4296
On Fri, 21 May 2021 01:52:27 GMT, Weijun Wang wrote:
> The code change refactors classes that have a `SuppressWarnings("removal")`
> annotation that covers more than 50KB of code. The big annotation is often
> quite faraway from the actual deprecated API usage it is suppressing, and
> with
> The code change refactors classes that have a `SuppressWarnings("removal")`
> annotation that covers more than 50KB of code. The big annotation is often
> quite faraway from the actual deprecated API usage it is suppressing, and
> with the annotation covering too big a portion it's easy to
On Wed, 2 Jun 2021 01:14:39 GMT, Sergey Bylokhov wrote:
> Some useful documentation was added to the JPasswordField.
Marked as reviewed by azvegint (Reviewer).
src/java.desktop/share/classes/javax/swing/JPasswordField.java line 68:
> 66: * handling confidential information such as the
On Fri, 21 May 2021 20:37:30 GMT, Weijun Wang wrote:
>> The code change refactors classes that have a `SuppressWarnings("removal")`
>> annotation that covers more than 50KB of code. The big annotation is often
>> quite faraway from the actual deprecated API usage it is suppressing, and
>>
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
>
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP,
On Wed, 2 Jun 2021 01:14:39 GMT, Sergey Bylokhov wrote:
> Some useful documentation was added to the JPasswordField.
Marked as reviewed by trebari (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/4296
17 matches
Mail list logo
