> Added check for the icon class type
> Added check if file or folder we are testing against exists and
> accessible
> Removed test from problem list
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Mark test as headful
On Wed, 30 Jun 2021 19:27:25 GMT, Phil Race wrote:
> I am a bit surprised the tests for this are not already headful
Fixed.
-
PR: https://git.openjdk.java.net/jdk17/pull/178
On Wed, 30 Jun 2021 19:19:24 GMT, Alexander Zuev wrote:
>>> No, the native code will fail to load the icon
>> So what call will fail? Is the "sf.getIcon()" return null? in what line of
>> code?
>
> Yes, from my remote debugging it happens in sf.getIcon() but the
> circumstances are quite rare
On Wed, 30 Jun 2021 04:51:04 GMT, Sergey Bylokhov wrote:
>>> * but what happens if the file cannot be read? We will call the "sf =
>>> ShellFolder.getShellFolder" and then we call "sf.getIcon()" and it returns
>>> what? As far as I understand it always return MultiResolutionIconImage, no?
>>>
On Wed, 30 Jun 2021 04:43:20 GMT, Sergey Bylokhov wrote:
> Not in this case, you cannot change the public signature.
Well, it is a change in API and should be done within the same process as any
API change. But it definitely can be done in the future major release.
-
PR:
On Wed, 30 Jun 2021 04:45:45 GMT, Sergey Bylokhov wrote:
> Even now, on Windows it is necessary to check is the returned object
> ImageIcon or not.
Yes but since API states that returned type is an Icon it should be done
anyways - because we might wrap up Icon in ImageIcon locally but we
On Wed, 30 Jun 2021 04:40:40 GMT, Sergey Bylokhov wrote:
> Why not use the "getDocument().getLength()"?
We can surely do that. Fixed.
-
PR: https://git.openjdk.java.net/jdk17/pull/127
> 8268775: Password is being converted to String in AccessibleJPasswordField
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Use getDocumnt().getLength() instead of requesting password as an array of
chars and counting its length
