Re: Swing dev>[11] Review request for JDK-8189253: [macos] JPopupMenu is inadvertently shown when using setComponentPopupMenu

/~mhalder/8189253/webrev.00/ <http://cr.openjdk.java.net/~mhalder/8189253/webrev.00/> Regards, Manajit > On 12-Jan-2018, at 11:04 AM, Manajit Halder wrote: > > Hi Semyon, > > Thank you for the clarification. I will try to fix the problem in the native > code. > > Th

Re: swing-dev Digest, Vol 135, Issue 14

Looks good. Regards, Manajit > > From: Krishna Addepalli > > Subject: Re: [12] RFR: JDK-8206343: There is a typo in the java > documentation of javax.swing.JScrollBar. > Date: 16 July 2018 at 2:05:54 PM IST > To: swing-dev@openjdk.java.net

Re: Swing dev>[12] Review request for JDK-8189253: [macos] JPopupMenu is inadvertently shown when using setComponentPopupMenu

d fix). Will your fix work if the parent with popup menu and the child are created on different screens? I have tried my fix with a Frame with PopupMenu and a Dialog on different screens, and it works. Thanks, Dmitry On 31 Oct 2018, at 16:41, Manajit Halder <mailto:manajit.hal...@oracle.com

Re: swing-dev Digest, Vol 142, Issue 10

Looks good to me. Regards, Manajit > > From: Philip Race mailto:philip.r...@oracle.com>> > Subject: Re: [13] JDK-8190361: Incorrect version info in > jaccessinspector.exe and jaccesswalker.exe > Date: 14 February 2019 at 10:10:11 PM IST > To: Shashidhara Veerabhadraiah

[13] Review request for JDK-8216971: [macosx swing] For JCheckBoxMenuItem actionPerformed() is called twice, when apple.laf.useScreenMenuBar=true and modifier is InputEvent.META

Hi All, Please review the fix for JDK13. Bug: https://bugs.openjdk.java.net/browse/JDK-8216971 Webrev: http://cr.openjdk.java.net/~mhalder/8216971/webrev.00/ Fix: actionPerformed() was

Re: [13] Review request for JDK-8216971: [macosx swing] For JCheckBoxMenuItem actionPerformed() is called twice, when apple.laf.useScreenMenuBar=true and modifier is InputEvent.

should not be delivered again to the application. Or, it should be that the > key event is not recognised and hence delivered to the application. > > Can you check why in this case, we are getting the key event as well as the > handleAction from the OS? > > Thanks, >

Re: [13] Review request for JDK-8216971: [macosx swing] For JCheckBoxMenuItem actionPerformed() is called twice, when apple.laf.useScreenMenuBar=true and modifier is InputEvent.

; Hi Manajit, > > Thanks for the clarification. I think you should add some more comments > around the statement at line86, to explain in more detail, about why to > ignore this call. > > Thanks, > Krishna > >> On 11-Mar-2019, at 2:25 PM, Manajit Halder > <mai

Re: [13] Review request for JDK-8216971: [macosx swing] For JCheckBoxMenuItem actionPerformed() is called twice, when apple.laf.useScreenMenuBar=true and modifier is InputEvent.

k to me. >> >> Thanks, >> Krishna >> >>> On 12-Mar-2019, at 3:36 PM, Manajit Halder >> <mailto:manajit.hal...@oracle.com>> wrote: >>> >>> Lines 74 to 82 explains why we need to ignore this call. This method should >>> b

Re: [13] Review request for JDK-8216971: [macosx swing] For JCheckBoxMenuItem actionPerformed() is called twice, when apple.laf.useScreenMenuBar=true and modifier is InputEvent.

Sadhukhan > wrote: > > I guess l94-111 indentation in CMenuItem.m and l69 Robot robot = new Robot(); > in testcase > is still not fixed. > Regards > Prasanta > On 15-Mar-19 4:51 PM, Manajit Halder wrote: >> Thanks Prasanta, >> >> I have corrected the

Re: [13] Review request for JDK-8216971: [macosx swing] For JCheckBoxMenuItem actionPerformed() is called twice, when apple.laf.useScreenMenuBar=true and modifier is InputEvent.

971/webrev.03/> Regards, Manajit > On 18-Mar-2019, at 4:25 PM, Prasanta Sadhukhan > wrote: > > Still > 74 } finally { > in testcase not fixed. Please fix it before pushing...No need to send webrev. > > Regards > Prasanta > On 18-Mar-19 4:12 PM, Manajit

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Avik, Changes looks good to me. Regards, Manajit > On 21-Mar-2016, at 4:16 pm, Rajeev Chamyal wrote: > > Test code looks good to me. > > Regards, > Rajeev Chamyal > > From: Avik Niyogi > Sent: 21 March 2016 14:02 > To: Manajit Halder; Alexan

Re: Review Request of 8152492: [macosx swing] double key event actions when using Mac menubar

Hi Avik, Changes looks good to me. Regards, Manajit > On 20-Apr-2016, at 11:37 am, Avik Niyogi wrote: > > Hi All, > I have added some comments and made some minor tweaks as per the inputs > received. > Please review my code changes as available at this link below: > > http://cr.openjdk.java.

Swing dev>[10] Review request for JDK-8189253: [macos] JPopupMenu is inadvertently shown when using setComponentPopupMenu

Hi All, Kindly review the following Swing fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8189253 Webrev: http://cr.openjdk.java.net/~mhalder/8189253/webrev.00/ Cause: Issue

Re: Swing dev>[10] Review request for JDK-8189253: [macos] JPopupMenu is inadvertently shown when using setComponentPopupMenu

-Dec-2017, at 9:55 PM, semyon.sadet...@oracle.com wrote: > > Hi Manajit, > > Can you provide information which fix caused the regression? > > --Semyon > > On 12/8/17 5:53 AM, Manajit Halder wrote: >> Hi All, >> >> Kindly review the following Swing fix. &

Re: Swing dev>[10] Review request for JDK-8189253: [macos] JPopupMenu is inadvertently shown when using setComponentPopupMenu

t; --Semyon > On 12/25/2017 02:42 AM, Manajit Halder wrote: >> Hi Semyon, >> >> Regression is cause by JDK-8080729 >> <https://bugs.openjdk.java.net/browse/JDK-8080729>. The fix can’t be >> reversed since it is the choice between addChildWindow or orderWindow. Went

Re: Swing dev>[10] Review request for JDK-8189253: [macos] JPopupMenu is inadvertently shown when using setComponentPopupMenu

mponent with the left button pressed and then the right button is > immediately pressed. The popup is triggered by the same logic despite it > isn't configured for the component. > --Semyon > > On 01/04/2018 10:22 AM, Manajit Halder wrote: >> Hi Semyon, >> >&g

Re: Swing dev>[10] Review request for JDK-8189253: [macos] JPopupMenu is inadvertently shown when using setComponentPopupMenu

limited to Mac platform only while you change > updates generic code. Why mouse provided by Apple matters here? > --Semyon > > On 01/08/2018 01:40 AM, Manajit Halder wrote: >> Hi Semyon, >> >> I could not reproduce the behaviour on Mac as on Mac this operation is not &

Re: Swing dev>[10] Review request for JDK-8189253: [macos] JPopupMenu is inadvertently shown when using setComponentPopupMenu

th the mouse whatever he wants nevertheless UI should not be broken. This > is just an indication the issue you are trying to fix may be a generic one. > > --Semyon > > On 01/10/2018 05:21 AM, Manajit Halder wrote: >> Hi Semyon, >> >> I could reproduce the behaviou

Re: swing-dev Digest, Vol 131, Issue 17

Looks good to me. Regards, Manajit > > From: Krishna Addepalli > > Subject: Re: [11][JDK-8195095]Images are not scaled correctly in > JEditorPane > Date: 7 March 2018 at 9:48:44 PM IST > To: Semyon Sadetsky >, Prasanta S