Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2020-09-17 Thread Stuart Marks
On Fri, 11 Sep 2020 15:17:58 GMT, Bradford Wetmore wrote: >> Ok, sorry for the distraction. > > Our local Santuario maintainer says: > > In general, changes to Apache Santuario should also be made at Apache so we > stay in sync. Hi @doom369, I hope we didn't end up wasting too much of your tim

[9] Review Request: 8047025 Fix raw and unchecked lint warnings in generated nimbus files

2014-07-02 Thread Stuart Marks
Hi all, Please review this change for 8047025, "Fix raw and unchecked lint warnings in generated nimbus files." Webrev: http://cr.openjdk.java.net/~smarks/reviews/8047025/webrev.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8047025 Although this change modifies only a few lines

Re: [9] Review Request: 8047025 Fix raw and unchecked lint warnings in generated nimbus files

2014-07-07 Thread Stuart Marks
Hi Henry, Thanks for taking a look at this. I'd appreciate additional review from one of the Swing developers, particularly about the issue of testing Nimbus. s'marks On 7/2/14 4:47 PM, Henry Jen wrote: Looks good to me. Cheers, Henry On 07/02/2014 03:31 PM, Stuart Marks wrot

Re: [9] Review Request: 8047025 Fix raw and unchecked lint warnings in generated nimbus files

2014-07-08 Thread Stuart Marks
s" from the L&F drop down menu, then go through the various tabs in the demo. That should exercise all the commonly used elements of Nimbus. Note that SwingSet2 is in the 'closed' sources so if you don't build those regularly pick up Swingset from a promoted build. -phil. O

RFR(s): 8186851 fix misspellings of "dependent" and "independent" in the JDK repo

2017-08-28 Thread Stuart Marks
Hi all, I was irked by some misspellings so I decided to create a quick fix. Webrev: http://cr.openjdk.java.net/~smarks/reviews/8186851/webrev.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8186851 Most of the changes are in core libs and in Swing, so I'm posting to both lists. Th