hg: jdk7/swing/jdk: 6625450: javax.swing.border.TitledBorder.getBaseline() doesn't throw IAE when width is < 0

2008-05-07 Thread sergey . malenkov
Changeset: c25ed95b96a8 Author:malenkov Date: 2008-05-07 16:08 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/c25ed95b96a8 6625450: javax.swing.border.TitledBorder.getBaseline() doesn't throw IAE when width is < 0 Summary: necessary check is added Reviewed-by: peterz, ale

hg: jdk7/swing/jdk: 6348456: BasicColorChooserUI ignores JColorChooser selection model changes

2008-05-07 Thread sergey . malenkov
Changeset: 56cae54e668c Author:malenkov Date: 2008-05-07 21:54 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/56cae54e668c 6348456: BasicColorChooserUI ignores JColorChooser selection model changes Summary: Some methods are moved from AbstractColorChooserPanel to BasicCol

hg: jdk7/swing/jdk: 4935607: RFE: LTP: Should be possible to set the TRANSIENT attribute of propertiies to FALSE

2008-05-07 Thread sergey . malenkov
Changeset: 5bcff22d837d Author:malenkov Date: 2008-05-07 23:20 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/5bcff22d837d 4935607: RFE: LTP: Should be possible to set the TRANSIENT attribute of propertiies to FALSE Summary: Add the Transient annotation and support it (JS

hg: jdk7/swing/jdk: 6668273: Example given in java.beans.EventHandler shows incorrect order of parameters

2008-05-23 Thread sergey . malenkov
Changeset: e0951cd6e7b9 Author:malenkov Date: 2008-05-23 20:14 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/e0951cd6e7b9 6668273: Example given in java.beans.EventHandler shows incorrect order of parameters Summary: Very simple misprint Reviewed-by: peterz, loneid ! sr

hg: jdk7/swing/jdk: 6708550: LTP: XMLEncoder does not encode instances of the File class

2008-06-18 Thread sergey . malenkov
Changeset: ec9c8e73ae53 Author:malenkov Date: 2008-06-18 19:15 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/ec9c8e73ae53 6708550: LTP: XMLEncoder does not encode instances of the File class Reviewed-by: peterz, loneid ! src/share/classes/java/io/File.java + test/java/be

hg: jdk7/swing/jdk: 4114658: DOC: Unspecified behaviour for java.beans.PropertyEditorSupport

2008-06-19 Thread sergey . malenkov
Changeset: fa7147a26cd2 Author:malenkov Date: 2008-06-19 18:03 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/fa7147a26cd2 4114658: DOC: Unspecified behaviour for java.beans.PropertyEditorSupport Reviewed-by: peterz, loneid ! src/share/classes/java/beans/PropertyEditor.ja

hg: jdk7/swing/jdk: 6718964: Swing border tests should be open source

2008-06-26 Thread sergey . malenkov
Changeset: 282c86389114 Author:malenkov Date: 2008-06-26 15:11 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/282c86389114 6718964: Swing border tests should be open source Reviewed-by: peterz + test/javax/swing/border/Test4120351.java + test/javax/swing/border/Test412472

hg: jdk7/swing/jdk: 6718965: Swing color chooser tests should be open source

2008-06-26 Thread sergey . malenkov
Changeset: 581440ba714a Author:malenkov Date: 2008-06-26 15:39 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/581440ba714a 6718965: Swing color chooser tests should be open source Reviewed-by: peterz + test/javax/swing/JColorChooser/Test4165217.java + test/javax/swing/JCo

hg: jdk7/swing/jdk: 4916852: RFE: LTP: BorderLayout Persistence Delegate should use 1.5 API

2008-07-08 Thread sergey . malenkov
Changeset: d5e658be14f7 Author:malenkov Date: 2008-07-08 16:40 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/d5e658be14f7 4916852: RFE: LTP: BorderLayout Persistence Delegate should use 1.5 API Reviewed-by: peterz, loneid ! src/share/classes/java/beans/MetaData.java + te

hg: jdk7/swing/jdk: 6351692: catch(Throwable) in java.beans.MetaData preventing thread shutdown

2008-07-09 Thread sergey . malenkov
Changeset: f98824b5fe08 Author:malenkov Date: 2008-07-09 15:25 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/f98824b5fe08 6351692: catch(Throwable) in java.beans.MetaData preventing thread shutdown Reviewed-by: peterz, loneid ! src/share/classes/java/beans/DefaultPersist

hg: jdk7/swing/jdk: 4994637: LTP: java.beans.java_util_Map_PersistenceDelegate: ConcurrentModificationException

2008-07-09 Thread sergey . malenkov
Changeset: ccdfb79c9864 Author:malenkov Date: 2008-07-09 19:29 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/ccdfb79c9864 4994637: LTP: java.beans.java_util_Map_PersistenceDelegate: ConcurrentModificationException Reviewed-by: peterz, loneid ! src/share/classes/java/bea

hg: jdk7/swing/jdk: 6552812: Add HSL tab to JColorChooser

2008-07-18 Thread sergey . malenkov
Changeset: f7585c3756ee Author:malenkov Date: 2008-07-18 18:26 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/f7585c3756ee 6552812: Add HSL tab to JColorChooser Reviewed-by: peterz, avu ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties ! sr

hg: jdk7/swing/jdk: 4778988: CompoundBorder.isBorderOpaque() has incorrect documentation.

2008-07-24 Thread sergey . malenkov
Changeset: ef591cd4c463 Author:malenkov Date: 2008-07-24 14:51 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/ef591cd4c463 4778988: CompoundBorder.isBorderOpaque() has incorrect documentation. Reviewed-by: peterz, rupashka ! src/share/classes/javax/swing/border/CompoundBo

hg: jdk7/swing/jdk: 6707406: BasicColorChooserUI tests throw NPE while getColorSelectionModel if isPropertyChanged() returns true

2008-07-24 Thread sergey . malenkov
Changeset: 91722ce41508 Author:malenkov Date: 2008-07-24 17:30 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/91722ce41508 6707406: BasicColorChooserUI tests throw NPE while getColorSelectionModel if isPropertyChanged() returns true Reviewed-by: peterz, rupashka ! src/sh

hg: jdk7/swing/jdk: 6630275: The spec on VetoableChangeSupport.fireVetoableChange should be updated

2008-07-25 Thread sergey . malenkov
Changeset: 1c4449ef03ce Author:malenkov Date: 2008-07-25 21:00 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/1c4449ef03ce 6630275: The spec on VetoableChangeSupport.fireVetoableChange should be updated Reviewed-by: peterz, rupashka ! src/share/classes/java/beans/Property

hg: jdk7/swing/jdk: 5026703: RFE: DOC: Are PropertyChangeSupport & VetoableChangeSupport Thread-Safe? --Docs Should Say

2008-09-01 Thread sergey . malenkov
Changeset: 71df74bef5ba Author:malenkov Date: 2008-09-01 17:36 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/71df74bef5ba 5026703: RFE: DOC: Are PropertyChangeSupport & VetoableChangeSupport Thread-Safe? --Docs Should Say Reviewed-by: peterz, rupashka ! src/share/classe

hg: jdk7/swing/jdk: 6397609: DOC: De-register API required for PropertyEditorManager and/or doc change

2008-09-03 Thread sergey . malenkov
Changeset: 9765266e5aea Author:malenkov Date: 2008-09-03 21:00 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/9765266e5aea 6397609: DOC: De-register API required for PropertyEditorManager and/or doc change Reviewed-by: peterz, rupashka + src/share/classes/com/sun/beans/W

hg: jdk7/swing/jdk: 4864117: RFE: Make XMLDecoder API more reusable

2008-12-22 Thread sergey . malenkov
Changeset: 50a9a4db3500 Author:malenkov Date: 2008-12-22 17:42 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/50a9a4db3500 4864117: RFE: Make XMLDecoder API more reusable Reviewed-by: peterz, loneid - src/share/classes/com/sun/beans/ObjectHandler.java + src/share/classes/

hg: jdk7/swing/jdk: 6736248: EnumEditor bug. Class check incorrect

2008-12-25 Thread sergey . malenkov
Changeset: 2b8a0d8b5cbb Author:malenkov Date: 2008-12-25 20:43 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/2b8a0d8b5cbb 6736248: EnumEditor bug. Class check incorrect Reviewed-by: rupashka, alexp ! src/share/classes/sun/beans/editors/EnumEditor.java + test/java/beans/P

hg: jdk7/swing/jdk: 4222508: JColorChooser ignores setEnabled() function call

2009-01-23 Thread sergey . malenkov
Changeset: f650e6e22c16 Author:malenkov Date: 2009-01-23 18:31 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/f650e6e22c16 4222508: JColorChooser ignores setEnabled() function call Reviewed-by: peterz, rupashka ! src/share/classes/javax/swing/colorchooser/AbstractColorCho

hg: jdk7/swing/jdk: 6788531: java.beans.Statement imposes excessive access control

2009-01-29 Thread sergey . malenkov
Changeset: e02f2d591cd5 Author:malenkov Date: 2009-01-29 15:34 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/e02f2d591cd5 6788531: java.beans.Statement imposes excessive access control Reviewed-by: peterz, rupashka ! src/share/classes/com/sun/beans/finder/MethodFinder.ja

hg: jdk7/swing/jdk: 4769844: classes in java.beans that are serializable but don't define serialVersionUID

2009-02-05 Thread sergey . malenkov
Changeset: 62a84e564a8c Author:malenkov Date: 2009-02-05 14:48 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/62a84e564a8c 4769844: classes in java.beans that are serializable but don't define serialVersionUID Reviewed-by: peterz, rupashka ! src/share/classes/java/beans/

hg: jdk7/swing/jdk: 6669869: Beans.isDesignTime() and other queries should be per-AppContext

2009-02-05 Thread sergey . malenkov
Changeset: 27dabbdfdcac Author:malenkov Date: 2009-02-05 17:00 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/27dabbdfdcac 6669869: Beans.isDesignTime() and other queries should be per-AppContext Reviewed-by: peterz, rupashka ! src/share/classes/java/beans/Beans.java + te

hg: jdk7/swing/jdk: 6852574: EnumPersistenceDelegate fails to persist instances with blocks

2009-06-24 Thread sergey . malenkov
Changeset: b75fc6019d5f Author:malenkov Date: 2009-06-24 13:59 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/b75fc6019d5f 6852574: EnumPersistenceDelegate fails to persist instances with blocks Reviewed-by: peterz ! src/share/classes/java/beans/MetaData.java + test/java/

hg: jdk7/swing/jdk: 6737700: api/javax_swing/table/DefaultTableCellRenderer/index.html#getset:DefaultTableCellRenderer

2009-06-24 Thread sergey . malenkov
Changeset: 404a13b063f9 Author:malenkov Date: 2009-06-24 17:45 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/404a13b063f9 6737700: api/javax_swing/table/DefaultTableCellRenderer/index.html#getset:DefaultTableCellRenderer Reviewed-by: alexp ! src/share/classes/javax/swin

hg: jdk7/swing/jdk: 6848364: javax/swing/border/Test4856008.java regression test fails due to BorderedComponent package not found

2009-06-25 Thread sergey . malenkov
Changeset: ae9e74a17059 Author:malenkov Date: 2009-06-25 18:50 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/ae9e74a17059 6848364: javax/swing/border/Test4856008.java regression test fails due to BorderedComponent package not found Reviewed-by: alexp ! test/javax/swing/

hg: jdk7/swing/jdk: 6557223: Resize cursor stays after fast outline-resize of JInternalFrame with JScrollPane

2009-06-26 Thread sergey . malenkov
Changeset: e60d3354ab9f Author:malenkov Date: 2009-06-26 16:30 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/e60d3354ab9f 6557223: Resize cursor stays after fast outline-resize of JInternalFrame with JScrollPane Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/b

hg: jdk7/swing/jdk: 6679840: provide a way to choose v-synced BufferStrategy

2009-06-26 Thread sergey . malenkov
Changeset: 1b40ddc3688c Author:malenkov Date: 2009-06-26 16:58 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/1b40ddc3688c 6679840: provide a way to choose v-synced BufferStrategy Reviewed-by: peterz ! src/share/classes/com/sun/java/swing/SwingUtilities3.java ! src/share/

hg: jdk7/swing/jdk: 6742850: Antialiasing for GTK L&F should be turned on by default if there is no embedded bitmap.

2009-06-26 Thread sergey . malenkov
Changeset: 800082d9b8df Author:malenkov Date: 2009-06-26 17:15 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/800082d9b8df 6742850: Antialiasing for GTK L&F should be turned on by default if there is no embedded bitmap. Reviewed-by: peterz ! src/share/classes/com/sun/jav

hg: jdk7/swing/jdk: 6380849: RFE: Automatic discovery of PersistanceDelegates

2009-07-02 Thread sergey . malenkov
Changeset: bccc4d5e8d6a Author:malenkov Date: 2009-07-02 19:48 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/bccc4d5e8d6a 6380849: RFE: Automatic discovery of PersistanceDelegates Reviewed-by: rupashka, alexp + src/share/classes/com/sun/beans/finder/BeanInfoFinder.java +

hg: jdk7/swing/jdk: 6329581: RFE: LTP: java.beans.XMLEncoder does not manage ClassLoader.

2009-07-03 Thread sergey . malenkov
Changeset: 7720d6c079ca Author:malenkov Date: 2009-07-03 16:56 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/7720d6c079ca 6329581: RFE: LTP: java.beans.XMLEncoder does not manage ClassLoader. Reviewed-by: rupashka, alexp ! src/share/classes/java/beans/Encoder.java ! src/

hg: jdk7/swing/jdk: 6723447: Introspector doesn't check return type for indexed property setters

2009-07-06 Thread sergey . malenkov
Changeset: ef20a15b3569 Author:malenkov Date: 2009-07-06 14:32 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/ef20a15b3569 6723447: Introspector doesn't check return type for indexed property setters Reviewed-by: rupashka ! src/share/classes/java/beans/IndexedPropertyDesc

hg: jdk7/swing/jdk: 6505027: terminateEditOnFocusLost making problems for table in JDesktopPane

2009-07-16 Thread sergey . malenkov
Changeset: f727cac13697 Author:malenkov Date: 2009-07-16 20:12 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/f727cac13697 6505027: terminateEditOnFocusLost making problems for table in JDesktopPane Reviewed-by: alexp ! src/share/classes/javax/swing/JInternalFrame.java +

hg: jdk7/swing/jdk: 6802868: JInternalFrame is not maximized when maximized parent frame.

2009-07-22 Thread sergey . malenkov
Changeset: 125eff6f653f Author:malenkov Date: 2009-07-22 12:21 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/125eff6f653f 6802868: JInternalFrame is not maximized when maximized parent frame. Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/basic/BasicDesktopIc

hg: jdk7/swing/jdk: 6864297: Right-to-left oriented JScrollPane is aligned to the wrong direction while resizing the container

2009-07-28 Thread sergey . malenkov
Changeset: 0ab4157789d9 Author:malenkov Date: 2009-07-28 13:10 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/0ab4157789d9 6864297: Right-to-left oriented JScrollPane is aligned to the wrong direction while resizing the container Reviewed-by: peterz ! src/share/classes/j

hg: jdk7/swing/jdk: 6865565: Test failed: /test/closed/javax/swing/JInternalFrame/6325652/bug6325652.java

2009-07-31 Thread sergey . malenkov
Changeset: 389cecd0ca18 Author:malenkov Date: 2009-07-31 16:27 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/389cecd0ca18 6865565: Test failed: /test/closed/javax/swing/JInternalFrame/6325652/bug6325652.java Reviewed-by: peterz + test/javax/swing/JInternalFrame/Test6325

hg: jdk7/swing/jdk: 6868189: Nested enum class with custom BeanInfo fails

2009-08-07 Thread sergey . malenkov
Changeset: 082ffa4c6749 Author:malenkov Date: 2009-08-07 19:06 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/082ffa4c6749 6868189: Nested enum class with custom BeanInfo fails Reviewed-by: peterz ! src/share/classes/com/sun/beans/finder/BeanInfoFinder.java + test/java/be

hg: jdk7/swing/jdk: 6868185: 2 JCK api/java_beans/Introspector/ tests fails starting from jdk7 b66

2009-09-08 Thread sergey . malenkov
Changeset: d73a741a7ea1 Author:malenkov Date: 2009-09-08 14:08 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/d73a741a7ea1 6868185: 2 JCK api/java_beans/Introspector/ tests fails starting from jdk7 b66 Reviewed-by: peterz ! src/share/classes/com/sun/beans/finder/BeanInfoF

Re: The method XMLEncoder.writeObject(TreePath) goes into infinite recursion

2009-10-26 Thread Sergey Malenkov
Hi Pavel, Thank you for your report. The 6423060 CR is already exist: PIT: java/beans/MetaData/6402062/TestTreePath.java test fails on cinnabar and RHAS3 platforms. http://bugs.sun.com/view_bug.do?bug_id=6423060 The problem was in the java.beans.ReflectionUtils class, that was refactored in J

Re: The method XMLEncoder.writeObject(TreePath) goes into infinite recursion

2009-10-27 Thread Sergey Malenkov
, that this bug won't be repaired in JDK 6 or is it possible to put new/refactored code (finder package mentioned) to JDK 6 too? Pavel Sergey Malenkov wrote: Hi Pavel, Thank you for your report. The 6423060 CR is already exist: PIT: java/beans/MetaData/6402062/TestTreePath.java test fai

hg: jdk7/swing/jdk: 5102804: Memory leak in Introspector.getBeanInfo(Class) for custom BeanInfo: Class param

2009-11-27 Thread sergey . malenkov
Changeset: 76b887e939d4 Author:malenkov Date: 2009-11-27 15:24 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/76b887e939d4 5102804: Memory leak in Introspector.getBeanInfo(Class) for custom BeanInfo: Class param Reviewed-by: peterz ! src/share/classes/com/sun/beans/WeakC

hg: jdk7/swing/jdk: 6905515: Test failed: java/beans/XMLEncoder/6329581/Test6329581.java

2009-11-30 Thread sergey . malenkov
Changeset: efab4331ec26 Author:malenkov Date: 2009-11-30 18:26 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/efab4331ec26 6905515: Test failed: java/beans/XMLEncoder/6329581/Test6329581.java Reviewed-by: peterz ! test/java/beans/XMLEncoder/6329581/Test6329581.java

hg: jdk7/swing/jdk: 6905516: Test failed: java/beans/EventHandler/Test6788531.java

2009-11-30 Thread sergey . malenkov
Changeset: 31fac6705b41 Author:malenkov Date: 2009-11-30 18:30 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/31fac6705b41 6905516: Test failed: java/beans/EventHandler/Test6788531.java Reviewed-by: peterz ! test/java/beans/EventHandler/Test6788531.java

hg: jdk7/swing/jdk: 4638075: DOC: Doc for java.beans.PropertyDescriptor.getPropertyType() is incorrect.

2009-12-09 Thread sergey . malenkov
Changeset: 931cfd3ba5b6 Author:malenkov Date: 2009-12-09 11:34 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/931cfd3ba5b6 4638075: DOC: Doc for java.beans.PropertyDescriptor.getPropertyType() is incorrect. Reviewed-by: gsm ! src/share/classes/java/beans/IndexedPropertyD

hg: jdk7/swing/jdk: 6905574: DOC: Introspector's javadoc contains wrong statement

2009-12-09 Thread sergey . malenkov
Changeset: d72275039339 Author:malenkov Date: 2009-12-09 11:38 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/d72275039339 6905574: DOC: Introspector's javadoc contains wrong statement Reviewed-by: gsm ! src/share/classes/java/beans/Introspector.java

hg: jdk7/swing/jdk: 4922835: DOC: Statement javadoc should indicate that target and methodName cannot be null

2010-01-21 Thread sergey . malenkov
Changeset: 9c5a24050392 Author:malenkov Date: 2010-01-21 21:45 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/9c5a24050392 4922835: DOC: Statement javadoc should indicate that target and methodName cannot be null Reviewed-by: peterz ! src/share/classes/java/beans/Express

hg: jdk7/swing/jdk: 4968536: DOC: Javadoc for java.beans.Encoder.getPersistenceDelegate is incomplete

2010-01-21 Thread sergey . malenkov
Changeset: eba0ff97a252 Author:malenkov Date: 2010-01-21 21:53 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/eba0ff97a252 4968536: DOC: Javadoc for java.beans.Encoder.getPersistenceDelegate is incomplete Reviewed-by: peterz ! src/share/classes/java/beans/Encoder.java

hg: jdk7/swing/jdk: 6412286: DOC: LTP: Unspecified NPE in java.beans.DefaultPersistenceDelegate.instantiate method

2010-01-28 Thread sergey . malenkov
Changeset: 4eb3a8c95c24 Author:malenkov Date: 2010-01-28 20:49 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/4eb3a8c95c24 6412286: DOC: LTP: Unspecified NPE in java.beans.DefaultPersistenceDelegate.instantiate method Reviewed-by: peterz ! src/share/classes/java/beans/De

hg: jdk7/swing/jdk: 6921057: REGRESSION: persistence delegate issue on Windows and Linux against 5.u23b03/6u17b11

2010-02-04 Thread sergey . malenkov
Changeset: 3913691b3021 Author:malenkov Date: 2010-02-05 10:36 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/3913691b3021 6921057: REGRESSION: persistence delegate issue on Windows and Linux against 5.u23b03/6u17b11 Reviewed-by: peterz, art ! src/share/classes/java/bean

hg: jdk7/swing/jdk: 4498236: RFE: Provide a toString method for PropertyChangeEvent and other classes

2010-02-18 Thread sergey . malenkov
Changeset: e8340332745e Author:malenkov Date: 2010-02-18 17:46 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/e8340332745e 4498236: RFE: Provide a toString method for PropertyChangeEvent and other classes Reviewed-by: peterz ! src/share/classes/java/beans/BeanDescriptor.

hg: jdk7/swing/jdk: 6921644: XMLEncoder generates invalid XML

2010-03-04 Thread sergey . malenkov
Changeset: 0622086d82ac Author:malenkov Date: 2010-03-04 21:17 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/0622086d82ac 6921644: XMLEncoder generates invalid XML Reviewed-by: peterz ! src/share/classes/java/beans/XMLEncoder.java + test/java/beans/XMLEncoder/Test5023550

hg: jdk7/swing/jdk: 6707226: java.beans.Statement & java.beans.Expression miss one important usecase

2010-03-11 Thread sergey . malenkov
Changeset: ce3770eadf85 Author:malenkov Date: 2010-03-11 17:39 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/ce3770eadf85 6707226: java.beans.Statement & java.beans.Expression miss one important usecase Reviewed-by: rupashka ! src/share/classes/java/beans/Expression.java

hg: jdk7/swing/jdk: 6479191: LTP: XMLEncoder does not update initialized property of GridBagConstraints type

2010-05-20 Thread sergey . malenkov
Changeset: a71c27e3ec4a Author:malenkov Date: 2010-05-20 18:44 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/a71c27e3ec4a 6479191: LTP: XMLEncoder does not update initialized property of GridBagConstraints type Reviewed-by: rupashka ! src/share/classes/java/beans/Defaul

hg: jdk7/swing/jdk: 5066685: BorderFactory lacks SoftBevelBorder support

2010-06-15 Thread sergey . malenkov
Changeset: 7a3d8fc0d2cd Author:malenkov Date: 2010-06-15 17:39 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/7a3d8fc0d2cd 5066685: BorderFactory lacks SoftBevelBorder support Reviewed-by: alexp ! src/share/classes/javax/swing/BorderFactory.java

hg: jdk7/swing/jdk: 6707234: Method returned by Introspector.internalFindMethod not necessarily most specific

2010-06-22 Thread sergey . malenkov
Changeset: 69ddf06e616a Author:malenkov Date: 2010-06-22 12:06 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/69ddf06e616a 6707234: Method returned by Introspector.internalFindMethod not necessarily most specific Reviewed-by: peterz ! src/share/classes/com/sun/beans/find

hg: jdk7/swing/jdk: 4129681: Cannot get a title border to display its label as disabled

2010-07-01 Thread sergey . malenkov
Changeset: d062afbe2107 Author:malenkov Date: 2010-07-01 18:09 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/d062afbe2107 4129681: Cannot get a title border to display its label as disabled Reviewed-by: alexp, rupashka ! src/share/classes/javax/swing/border/TitledBorder.

hg: jdk7/swing/jdk: 6959266: test javax/swing/JInternalFrame/6725409/bug6725409.java should be modified

2010-07-01 Thread sergey . malenkov
Changeset: 46306a419ba3 Author:malenkov Date: 2010-07-01 18:47 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/46306a419ba3 6959266: test javax/swing/JInternalFrame/6725409/bug6725409.java should be modified Reviewed-by: alexp ! test/javax/swing/JInternalFrame/6725409/bug

hg: jdk7/swing/jdk: 6894597: test/closed/javax/swing/JPopupMenu/6495920/bug6495920.java fails

2010-07-09 Thread sergey . malenkov
Changeset: d0bcc9aa5a7a Author:malenkov Date: 2010-07-09 19:42 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/d0bcc9aa5a7a 6894597: test/closed/javax/swing/JPopupMenu/6495920/bug6495920.java fails Reviewed-by: alexp, peterz + test/javax/swing/JPopupMenu/6495920/bug6495920

hg: jdk7/swing/jdk: 6963811: Deadlock-prone locking changes in Introspector

2010-07-09 Thread sergey . malenkov
Changeset: 3dc686ecb4cd Author:malenkov Date: 2010-07-09 22:07 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/3dc686ecb4cd 6963811: Deadlock-prone locking changes in Introspector Reviewed-by: peterz, rupashka ! src/share/classes/com/sun/beans/finder/InstanceFinder.java !

hg: jdk7/swing/jdk: 6199676: REGRESSION: ColorChooser loses preview when change LandF in Java5

2010-07-30 Thread sergey . malenkov
Changeset: 951e46d93af0 Author:malenkov Date: 2010-07-30 19:21 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/951e46d93af0 6199676: REGRESSION: ColorChooser loses preview when change LandF in Java5 Reviewed-by: alexp, peterz ! src/share/classes/javax/swing/plaf/basic/Basi

hg: jdk7/swing/jdk: 6972468: Security manager should be used for tests in java/beans/XMLEncoder

2010-07-30 Thread sergey . malenkov
Changeset: f40de306ab66 Author:malenkov Date: 2010-07-30 19:40 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/f40de306ab66 6972468: Security manager should be used for tests in java/beans/XMLEncoder Reviewed-by: peterz ! test/java/beans/XMLEncoder/Test4631471.java ! test/

swing-dev@openjdk.java.net

2010-08-10 Thread sergey . malenkov
Changeset: d0e314d59f84 Author:malenkov Date: 2010-08-10 19:29 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/d0e314d59f84 6960267: JTable.getRowHeight() returns value different from the specified default (16.0) with GTK L&F Reviewed-by: peterz ! src/share/classes/javax/

hg: jdk7/swing/jdk: 6915566: Closed swing tests failing with assert errors when run with -ea -esa

2010-09-10 Thread sergey . malenkov
Changeset: 4fea9ea1661d Author:malenkov Date: 2010-09-10 20:48 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/4fea9ea1661d 6915566: Closed swing tests failing with assert errors when run with -ea -esa Reviewed-by: art, peterz ! src/share/classes/com/sun/java/swing/SwingUt

hg: jdk7/swing/jdk: 6978482: MetalBorders.ToolBarBorder should specify that its getBorderInsets impl accepts only JToolBar inst

2010-09-14 Thread sergey . malenkov
Changeset: 7fc59f27318c Author:malenkov Date: 2010-09-14 19:12 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/7fc59f27318c 6978482: MetalBorders.ToolBarBorder should specify that its getBorderInsets impl accepts only JToolBar inst Reviewed-by: alexp ! src/share/classes/c

hg: jdk7/swing/jdk: 6635395: javax.swing.JDialog constructors should specify IAE throwing if invalid owners passed

2010-09-14 Thread sergey . malenkov
Changeset: 2ffd71748740 Author:malenkov Date: 2010-09-14 21:22 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/2ffd71748740 6635395: javax.swing.JDialog constructors should specify IAE throwing if invalid owners passed Reviewed-by: alexp ! src/share/classes/javax/swing/JD

hg: jdk7/swing/jdk: 6977726: JColorChooser.getPreviewPanel() returnes null starting from jdk7 b105.

2010-09-14 Thread sergey . malenkov
Changeset: 49650448c3c7 Author:malenkov Date: 2010-09-14 22:05 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/49650448c3c7 6977726: JColorChooser.getPreviewPanel() returnes null starting from jdk7 b105. Reviewed-by: alexp ! src/share/classes/javax/swing/JColorChooser.java

hg: jdk7/swing/jdk: 6741392: libmawt.so crash at Java_com_sun_java_swing_plaf_gtk_GTKEngine_nativeFinishPainting+0x4f

2010-09-15 Thread sergey . malenkov
Changeset: bf89c7fc48fd Author:malenkov Date: 2010-09-16 09:07 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/bf89c7fc48fd 6741392: libmawt.so crash at Java_com_sun_java_swing_plaf_gtk_GTKEngine_nativeFinishPainting+0x4f Reviewed-by: peterz ! src/solaris/native/sun/awt/g

hg: jdk7/swing/jdk: 6976577: JCK7 api/java_beans/EventSetDescriptor/descriptions.html#Ctor1 fails since jdk7 b102

2010-09-27 Thread sergey . malenkov
Changeset: 278c8daa3075 Author:malenkov Date: 2010-09-27 13:38 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/278c8daa3075 6976577: JCK7 api/java_beans/EventSetDescriptor/descriptions.html#Ctor1 fails since jdk7 b102 Reviewed-by: peterz ! src/share/classes/java/beans/Eve

hg: jdk7/swing/jdk: 6986450: javax/swing/JTable/Test6888156.java test is failing against jdk7 just on windows

2010-09-27 Thread sergey . malenkov
Changeset: 0ca4ae74cf44 Author:malenkov Date: 2010-09-27 21:07 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/0ca4ae74cf44 6986450: javax/swing/JTable/Test6888156.java test is failing against jdk7 just on windows Reviewed-by: alexp ! test/javax/swing/JTable/Test6888156.j

hg: jdk7/swing/jdk: 6982753: javax/swing/JTextArea/6940863/bug6940863.java should be modified

2010-09-30 Thread sergey . malenkov
Changeset: 990bbd005f28 Author:malenkov Date: 2010-09-30 20:21 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/990bbd005f28 6982753: javax/swing/JTextArea/6940863/bug6940863.java should be modified Reviewed-by: alexp ! test/javax/swing/JTextArea/6940863/bug6940863.java

hg: jdk7/swing/jdk: 6603635: links to tutorials broken in JTable API doc

2010-10-13 Thread sergey . malenkov
Changeset: 23fd99021d35 Author:malenkov Date: 2010-10-13 15:18 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/23fd99021d35 6603635: links to tutorials broken in JTable API doc Reviewed-by: alexp ! src/share/classes/javax/swing/JTable.java

hg: jdk7/swing/jdk: 4358979: javax.swing.border should have a DashedBorder

2010-10-21 Thread sergey . malenkov
Changeset: 64f599571511 Author:malenkov Date: 2010-10-21 20:41 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/64f599571511 4358979: javax.swing.border should have a DashedBorder Reviewed-by: flar, alexp ! src/share/classes/java/awt/BasicStroke.java ! src/share/classes/jav

hg: jdk7/swing/jdk: 6447751: Bean Customizer should be detectable by reflection name alone

2010-11-17 Thread sergey . malenkov
Changeset: e6932dbf30d8 Author:malenkov Date: 2010-11-17 22:17 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/e6932dbf30d8 6447751: Bean Customizer should be detectable by reflection name alone Reviewed-by: peterz ! src/share/classes/java/beans/Introspector.java + test/ja

hg: jdk7/swing/jdk: 6999033: Methods BorderFactory.createSoftBevelBorder() don't return SoftBevelBorder instances

2010-11-29 Thread sergey . malenkov
Changeset: 602dfe45c227 Author:malenkov Date: 2010-11-29 20:38 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/602dfe45c227 6999033: Methods BorderFactory.createSoftBevelBorder() don't return SoftBevelBorder instances Reviewed-by: alexp ! src/share/classes/javax/swing/Bor

hg: jdk7/swing/jdk: 6981576: TitledBorder.getBorder() returns null in java build 1.7.0-ea-b107

2010-11-29 Thread sergey . malenkov
Changeset: 3d92a0fbf5cb Author:malenkov Date: 2010-11-29 21:20 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/3d92a0fbf5cb 6981576: TitledBorder.getBorder() returns null in java build 1.7.0-ea-b107 Reviewed-by: alexp ! src/share/classes/javax/swing/border/TitledBorder.jav

hg: jdk7/swing/jdk: 7001484: DOC: Method javax.swing.border.StrokeBorder.getBorderInsets() should specify how it converts float

2011-01-31 Thread sergey . malenkov
Changeset: 457f6b2cc155 Author:malenkov Date: 2011-01-31 21:22 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/457f6b2cc155 7001484: DOC: Method javax.swing.border.StrokeBorder.getBorderInsets() should specify how it converts float Reviewed-by: alexp ! src/share/classes/j

hg: jdk7/swing/jdk: 7001118: DOC: javax.swing.border.StrokeBorder.paintBorder() doesn't throw NPE in all specified cases

2011-01-31 Thread sergey . malenkov
Changeset: 020b4695370c Author:malenkov Date: 2011-01-31 21:31 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/020b4695370c 7001118: DOC: javax.swing.border.StrokeBorder.paintBorder() doesn't throw NPE in all specified cases Reviewed-by: alexp ! src/share/classes/javax/sw

hg: jdk7/swing/jdk: 6999045: DOC: Unclear spec for BevelBorder constructor and BorderFactory factory method (colors switching)

2011-01-31 Thread sergey . malenkov
Changeset: 07bea0d4e454 Author:malenkov Date: 2011-01-31 21:49 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/07bea0d4e454 6999045: DOC: Unclear spec for BevelBorder constructor and BorderFactory factory method (colors switching) Reviewed-by: alexp ! src/share/classes/ja

hg: jdk7/swing/jdk: 6980124: closed/javax/swing/plaf/synth/SynthPainter/unitTest/UnitTest.java fails

2011-02-16 Thread sergey . malenkov
Changeset: f326139e7fda Author:malenkov Date: 2011-02-16 18:32 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/f326139e7fda 6980124: closed/javax/swing/plaf/synth/SynthPainter/unitTest/UnitTest.java fails Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/synth/SynthG

hg: jdk7/swing/jdk: 7021517: java.beans code comments have issues with HTML4 compliance

2011-03-17 Thread sergey . malenkov
Changeset: c53260a00454 Author:malenkov Date: 2011-03-17 18:22 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/c53260a00454 7021517: java.beans code comments have issues with HTML4 compliance Reviewed-by: rupashka ! src/share/classes/java/beans/DefaultPersistenceDelegate.

hg: jdk7/swing/jdk: 6825739: jdk regression test failing on linux: java/lang/reflect/Method/InheritedMethods.java

2011-03-24 Thread sergey . malenkov
Changeset: cc4c80d4e85a Author:malenkov Date: 2011-03-24 21:45 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/cc4c80d4e85a 6825739: jdk regression test failing on linux: java/lang/reflect/Method/InheritedMethods.java Reviewed-by: rupashka ! test/java/lang/reflect/Method/

hg: jdk7/swing/jdk: 7025987: Nimbus L&F increases insets unexpectedly

2011-04-04 Thread sergey . malenkov
Changeset: 8e21bec188ae Author:malenkov Date: 2011-04-04 19:55 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/8e21bec188ae 7025987: Nimbus L&F increases insets unexpectedly Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/nimbus/LoweredBorder.java ! test/javax/swin

hg: jdk7/swing/jdk: 7034614: The insets of TitledBorder vary, will be modified by another method, in JDK7

2011-04-18 Thread sergey . malenkov
Changeset: 096242335b89 Author:malenkov Date: 2011-04-18 15:58 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/096242335b89 7034614: The insets of TitledBorder vary, will be modified by another method, in JDK7 Reviewed-by: rupashka ! src/share/classes/javax/swing/border/T

hg: jdk7/swing/jdk: 7027043: (doc) Confusing typo at java/beans/VetoableChangeSupport.java

2011-04-26 Thread sergey . malenkov
Changeset: 9faa309e852b Author:malenkov Date: 2011-03-16 18:48 +0300 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/9faa309e852b 7027043: (doc) Confusing typo at java/beans/VetoableChangeSupport.java Reviewed-by: rupashka ! src/share/classes/java/beans/VetoableChangeSupport.jav

hg: jdk8/swing/jdk: 7057459: Regression: Performance degradation with java.beans.XMLEncoder

2011-08-05 Thread sergey . malenkov
Changeset: 494e61ff0eac Author:malenkov Date: 2011-08-05 16:15 +0400 URL: http://hg.openjdk.java.net/jdk8/swing/jdk/rev/494e61ff0eac 7057459: Regression: Performance degradation with java.beans.XMLEncoder Reviewed-by: rupashka ! src/share/classes/java/beans/Encoder.java

hg: jdk8/swing/jdk: 7064279: Introspector.getBeanInfo() should release some resources in timely manner

2011-09-02 Thread sergey . malenkov
Changeset: 850db915b8ef Author:malenkov Date: 2011-09-02 13:21 +0400 URL: http://hg.openjdk.java.net/jdk8/swing/jdk/rev/850db915b8ef 7064279: Introspector.getBeanInfo() should release some resources in timely manner Reviewed-by: art, alexp ! src/share/classes/java/beans/Beans.java

hg: jdk8/swing/jdk: 7087876: java/beans/PropertyDescriptor.html#createPropertyEditor() throws RE if editor cannot be created

2011-09-19 Thread sergey . malenkov
Changeset: 4617872da687 Author:malenkov Date: 2011-09-19 16:11 +0400 URL: http://hg.openjdk.java.net/jdk8/swing/jdk/rev/4617872da687 7087876: java/beans/PropertyDescriptor.html#createPropertyEditor() throws RE if editor cannot be created Reviewed-by: rupashka ! src/share/classes/j

hg: jdk8/swing/jdk: 7092744: XMLEncoder fails to encode and breaks backward compatibility

2011-10-27 Thread sergey . malenkov
Changeset: 5880a716f277 Author:malenkov Date: 2011-10-27 19:51 +0400 URL: http://hg.openjdk.java.net/jdk8/swing/jdk/rev/5880a716f277 7092744: XMLEncoder fails to encode and breaks backward compatibility Reviewed-by: rupashka ! src/share/classes/com/sun/beans/finder/AbstractFinder.j

hg: jdk8/swing/jdk: 7087429: Constructor of java.beans.PropertyChangeEvent should declare thrown NPE for null source

2011-10-31 Thread sergey . malenkov
Changeset: 9270a13fe24d Author:malenkov Date: 2011-10-31 20:01 +0400 URL: http://hg.openjdk.java.net/jdk8/swing/jdk/rev/9270a13fe24d 7087429: Constructor of java.beans.PropertyChangeEvent should declare thrown NPE for null source Reviewed-by: rupashka ! src/share/classes/java/bean

Re: CFV: New Swing group Lead: Pavel Porvatov

2012-06-20 Thread Sergey Malenkov
Vote: YES Congratulations! SAM On 08.06.2012 17:19, Artem Ananiev wrote: Hi, Swing group, as many of you know, Alexander Potochkin, who has been a Swing group Lead for last several years, has moved to another position at Oracle. Although he is still involved to Swing development (thanks, Alex!

[8] Review request for 8003400: JTree scrolling problem when using large model

2013-01-16 Thread Sergey Malenkov
Hello, Could you please review the following fix: bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003400 fix: http://cr.openjdk.java.net/~malenkov/8003400.0/ JTree with the large model calculates widths for visible rows only. The problem is that the horizontal scroll bar appears after

Re: [8] Review request for 8003400: JTree scrolling problem when using large model

2013-01-16 Thread Sergey Malenkov
Hello, This is the second version, in which the automatic test is stabilized. I've added a lock to ensure that JavaTest does not close the window before the test is finished. Thanks, SAM On 16.01.2013 17:29, Sergey Malenkov wrote: Hello, Could you please review the following fix

Re: [8] Review request for 8003400: JTree scrolling problem when using large model

2013-01-16 Thread Sergey Malenkov
16.01.2013 19:55, Sergey Bylokhov wrote: Looks like in the updateCachedPreferredSize we should add size of scrollbar not a rowSize, since they can be different. In this case new invokeLater is not necessary. Also it would be good to dispose the frame in the test. 16.01.2013 19:16, Sergey Malenkov wro

[8] Review request for 6817933: Setting the background of an HTML Widget changes the native Windows JFileChooser

2013-01-21 Thread Sergey Malenkov
Hello, Could you please review the following fix: bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6817933 fix: http://cr.openjdk.java.net/~malenkov/6817933.0/ The styleSheet property of the HTMLEditorKit class have a static behavior. It must be non-static because of JavaBeans spec. The

Re: [8] Review request for 6817933: Setting the background of an HTML Widget changes the native Windows JFileChooser

2013-01-22 Thread Sergey Malenkov
375 * HTML elements. By default the resource specified by 376 * DEFAULT_CSS gets loaded, and is*shared* by all HTMLEditorKit 377 * instances. 378 */ " What does it mean: "shared"? 21.01.2013 14:40, Sergey Malenkov wrote: Hello, Could you please review the foll

Re: [8] Review request for 8003400: JTree scrolling problem when using large model

2013-01-23 Thread Sergey Malenkov
SwingUtilities.getUnwrappedParent() method to get the first non JLayer parent. Does it have sense to skip JLayer components to get the JViewport in this fix too? Thanks, Alexandr. On 1/16/2013 9:46 PM, Sergey Malenkov wrote: Hi Sergey, > Looks like in the updateCachedPreferredSize we should add >

Approved: [Accessibility]Focus unable to traverse in the menubar

2013-02-05 Thread Sergey Malenkov
Hi Frank, I approve. Thanks, SAM On 23.01.2013 7:00, Frank Ding wrote: Hi Alexandr. Thanks. To swing-dev, seems I still need anther member review before committing. Is there anybody who would like to review it? Best regards, Frank On 1/22/2013 10:54 PM, Alexander Scherbatiy wrote: On 1

Re: [8] Review request for 7173873 JFrame.setDefaultCloseOperation(EXIT_ON_CLOSE) will never lead to SE if EXIT_ON_CLOSE is already set

2013-02-12 Thread Sergey Malenkov
Hi Alexander, The fix looks good. Thanks, SAM On 08.02.2013 19:44, Alexander Scherbatiy wrote: bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7173873 webrev: http://cr.openjdk.java.net/~alexsch/7173873/webrev.00 The fix checks the EXIT_ON_CLOSE operation by system security manager e

Approved: 7189299 DefaultButtonModel instance keeps stale listeners of JButton in case of multiple SwingUtilities.updateComponentTreeUI() calls

2013-02-13 Thread Sergey Malenkov
The fix looks like a hack, but it is acceptable in this case. Thanks, SAM On 29.01.2013 9:31, Frank Ding wrote: Hi Alexandr, Please review my 9th attempt @ http://cr.openjdk.java.net/~dingxmin/7189299/webrev.09/ The revision also passed test LoadingWebPageToJEditorPane. Thanks && Best

Approved: [8] Request for review: 7184945 [macosx] NPE in AquaComboBoxUI since jdk7u6b17, jdk8b47

2013-02-22 Thread Sergey Malenkov
The fix looks good. Is it possible to create a test for NPE? Thanks, SAM

  1   2   >