Re: RFR: 8264428: Cleanup usages of StringBuffer in java.desktop

2021-04-01 Thread Aleksey Shipilev
On Thu, 1 Apr 2021 12:48:52 GMT, Andrey Turbanov wrote: >> Looks like this change goes beyond of simple replacement of StringBuffer >> with StringBuilder. Please update the description of the bug and PR >> description. > > I've updated PR description, but I don't have rights to update JIRA.

Re: RFR: 8264428: Replace uses of StringBuffer with StringBuilder in java.desktop

2021-03-30 Thread Aleksey Shipilev
On Mon, 29 Mar 2021 20:50:14 GMT, Andrey Turbanov wrote: > Found by IntelliJ IDEA inspection `Java | Java language level migration aids > | Java 5 | 'StringBuffer' may be 'StringBuilder'` > As suggested in > https://github.com/openjdk/jdk/pull/1507#issuecomment-757369003 I've created >

Integrated: 8263977: GTK L: Cleanup duplicate checks in GTKStyle and GTKLookAndFeel

2021-03-23 Thread Aleksey Shipilev
On Mon, 22 Mar 2021 15:40:41 GMT, Aleksey Shipilev wrote: > SonarCloud reports a few minor problems in GTKStyle and GTKLookAndFeel: > Correct one of the identical sub-expressions on both sides of operator "||". This pull request has now been integrated. Changeset: df01b15b Au

Re: RFR: 8263977: GTK L: Cleanup duplicate checks in GTKStyle and GTKLookAndFeel [v2]

2021-03-22 Thread Aleksey Shipilev
> SonarCloud reports a few minor problems in GTKStyle and GTKLookAndFeel: > Correct one of the identical sub-expressions on both sides of operator "||". Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: U

RFR: 8263977: GTK L: Cleanup duplicate checks in GTKStyle and GTKLookAndFeel

2021-03-22 Thread Aleksey Shipilev
SonarCloud reports a few minor problems in GTKStyle and GTKLookAndFeel: Correct one of the identical sub-expressions on both sides of operator "||". - Commit messages: - 8263977: GTK L: Cleanup duplicate checks in GTKStyle and GTKLookAndFeel Changes:

Re: RFR: 4916923: In MetalRootPaneUI, MetalRootLayout does not correctly calculate minimumsize

2020-11-19 Thread Aleksey Shipilev
On Wed, 11 Nov 2020 06:12:28 GMT, Sergey Bylokhov wrote: > The typo in the MetalRootLayout is fixed. The tpWidth was replaced by the > tpHeight for height calculation. Seems like a simple bug. Looks good! - Marked as reviewed by shade (Reviewer). PR:

Re: RFR: 8198400: Test javax/swing/SwingUtilities/6797139/bug6797139.java fails in mach5 [v2]

2020-10-19 Thread Aleksey Shipilev
On Mon, 19 Oct 2020 04:31:27 GMT, Prasanta Sadhukhan wrote: >> Please review a test fix for an issue seen failing in mach5 testing although >> it is not reproducible locally. >> The issue seems to stem from the fact that the test was been run as headless >> test although it requires to create