Re: RFR: 8249548: backward focus traversal gets stuck in button group

2020-08-08 Thread Pankaj Bansal
Gentle ping, any reviewers? Regards, Pankaj On 30/07/20 3:34 PM, Pankaj Bansal wrote: ping, any reviewers? Regards, Pankaj On 26/07/20 4:24 PM, Pankaj Bansal wrote: Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8249548 webrev: http

Re: RFR 8249838: javax.swing.JLayeredPane has used valueOf twice in example code in documentation

2020-08-05 Thread Pankaj Bansal
Looks good to me -Pankaj On 06/08/20 9:21 AM, Prasanta Sadhukhan wrote: Hi All, Please review a doc fix where details section of JLayeredPane has used valueOf twice as a typo Bug: https://bugs.openjdk.java.net/browse/JDK-8249838 hg diff

Re: RFR: 8247753: UIManager.getSytemLookAndFeelClassName() returns wrong value on Fedora 32

2020-08-05 Thread Pankaj Bansal
  ? gnome : null; + } -phil. On 8/4/20, 10:16 PM, Prasanta Sadhukhan wrote: Looks ok to me. One observation is, in testcase you can remove line71 linux check as we already did the check in l54. Regards Prasanta On 04-Aug-20 11:12 PM, Pankaj Bansal wrote: Hi All,

RFR: 8251166: Add automated testcases for changes done in JDK-8214112

2020-08-05 Thread Pankaj Bansal
Hi All, Please review this test only fix for jdk16 bug: https://bugs.openjdk.java.net/browse/JDK-8251166 webrev: http://cr.openjdk.java.net/~pbansal/8251166/webrev00/ UnderJDK-8214112

Re: RFR: 8247753: UIManager.getSytemLookAndFeelClassName() returns wrong value on Fedora 32

2020-08-05 Thread Pankaj Bansal
vation is, in testcase you can remove line71 linux check as we already did the check in l54. Regards Prasanta On 04-Aug-20 11:12 PM, Pankaj Bansal wrote: Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8247753 webrev: http://cr.openjdk.java.net/~pbansal/8

RFR: 8247753: UIManager.getSytemLookAndFeelClassName() returns wrong value on Fedora 32

2020-08-04 Thread Pankaj Bansal
okAndFeel/SystemLookAndFeelTest.java. The test fails on Fedora 32 without fix and passes with the fix. I have run the required mach5 tests and this fix is not breaking anything. Link in JBS. Regards, Pankaj Bansal

Re: RFR: 8239137: JAWS does not always announce the value of JSliders in JColorChooser

2020-08-04 Thread Pankaj Bansal
Hello Sergey, I have created the CSR. Please have a look. https://bugs.openjdk.java.net/browse/JDK-8251002 Regards, Pankaj On 28/07/20 6:08 AM, Sergey Bylokhov wrote: Looks fine. Please note you will need a CSR for this change. On 19.07.2020 11:28, Pankaj Bansal wrote: Hi All, Please

Re: RFR: 8233635: [TESTBUG] ProgressMonitorEscapeKeyPress.java fails on macos

2020-07-31 Thread Pankaj Bansal
mach5 running this test on osx10.15. Did you verify in osx10.15? Regards Prasanta On 21-May-20 10:08 AM, Pankaj Bansal wrote: Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233635 Patch: diff -r dd652a1b2a39 test/jdk/ProblemList.txt

Re: RFR: 8249548: backward focus traversal gets stuck in button group

2020-07-30 Thread Pankaj Bansal
ping, any reviewers? Regards, Pankaj On 26/07/20 4:24 PM, Pankaj Bansal wrote: Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8249548 webrev: http://cr.openjdk.java.net/~pbansal/8249548/webrev00/ <http://cr.openjdk.java.net/%7Epban

RFR: 8249548: backward focus traversal gets stuck in button group

2020-07-26 Thread Pankaj Bansal
Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8249548 webrev: http://cr.openjdk.java.net/~pbansal/8249548/webrev00/ Issue: If few ToggleButtons are added to button group, the

RFR: 8239137: JAWS does not always announce the value of JSliders in JColorChooser

2020-07-19 Thread Pankaj Bansal
Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8239137 webrev: http://cr.openjdk.java.net/~pbansal/8239137/webrev02/ Issue: The JAWS does not announce the value of JSlider in

Re: RFR: Nimbus L Fix for 8041701 is causing some Nimbus tests to fail

2020-07-17 Thread Pankaj Bansal
Looks ok to me -Pankaj On 17/07/20 6:46 PM, Tejpal Rebari wrote: Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8249619 Webrev : http://cr.openjdk.java.net/~trebari/swing/8249619/webrev00/

Re: RFR: 8249251: [dark_mode ubuntu 20.04] The selected menu is not highlighted in GTKLookAndFeel

2020-07-14 Thread Pankaj Bansal
menu.getLocationOnScreen();   rect = menu.getBounds();    });    robot.waitForIdle();    robot.delay(500);    You need to wait and then read the bounds, otherwise the test may fail(It sometimes fail on my local run for that reason) Done. Regards, Pankaj On 13.07.2020 11:30, Pan

Re: RFR: 8249251: [dark_mode ubuntu 20.04] The selected menu is not highlighted in GTKLookAndFeel

2020-07-13 Thread Pankaj Bansal
urs. And I think we do have a bug already on the subject of re-doing this properly by reading the CSS ?? -phil. On 7/13/20, 11:30 AM, Pankaj Bansal wrote: Hi All, Please review the following fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8249251 webrev: http://cr.openjdk.java.

RFR: 8249251: [dark_mode ubuntu 20.04] The selected menu is not highlighted in GTKLookAndFeel

2020-07-13 Thread Pankaj Bansal
Hi All, Please review the following fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8249251 webrev: http://cr.openjdk.java.net/~pbansal/8249251/webrev01/ Issue: In Ubuntu 20.04 in dark mode, the selected Menu is not

Re: RFR: 8041705 Bugs in DefaultTreeCellRenderer.updateUI()

2020-07-08 Thread Pankaj Bansal
Looks good to me -Pankaj On 07/07/20 10:53 AM, Tejpal Rebari wrote: On 02-Jul-2020, at 2:44 PM, Tejpal Rebari <mailto:tejpal.reb...@oracle.com>> wrote: Hi Pankaj, Thanks for the review. On 02-Jul-2020, at 2:05 PM, Pankaj Bansal mailto:pankaj.b.ban...@oracle.com>> wrote:

Re: RFR: 8041705 Bugs in DefaultTreeCellRenderer.updateUI()

2020-07-02 Thread Pankaj Bansal
Hello Tejpal, Few comments about the test 1. Remove all wild imports 2. Why do you need to create "lf" variable? Just call setLookAndFeel with L name 3. Dispose the frame in EDT thread in finally block 4. I am not able to understand the use of Robot in your program. Regards, Pankaj On

Re: RFR: 8197560: test javax/swing/JTree/8003400/Test8003400.java fails

2020-06-30 Thread Pankaj Bansal
ug tag is not necessary. On 6/26/20 12:01 pm, Pankaj Bansal wrote: Hi Sergey/Prasanta, I have made changes to the test to work on all platforms. I have also made changes to run it on all installed look and feels on the platforms. The test is passing on all L on all platforms. Link in the JBS. webrev

Re: RFR: 8197560: test javax/swing/JTree/8003400/Test8003400.java fails

2020-06-26 Thread Pankaj Bansal
Hi Sergey/Prasanta, I have made changes to the test to work on all platforms. I have also made changes to run it on all installed look and feels on the platforms. The test is passing on all L on all platforms. Link in the JBS. webrev: http://cr.openjdk.java.net/~pbansal/8197560/webrev01/

RFR: 8197560: test javax/swing/JTree/8003400/Test8003400.java fails

2020-06-25 Thread Pankaj Bansal
Hi All, Please review the following test only fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8197560 webrev: http://cr.openjdk.java.net/~pbansal/8197560/webrev00/ The test fails intermittently on Windows and always on

Re: RFR 8248187: javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails with String is not properly drawn

2020-06-25 Thread Pankaj Bansal
ok, looks good to me Pankaj On 25/06/20 4:48 PM, Prasanta Sadhukhan wrote: It is intentional as this is a headless test so nothing is being shown but to get a feel of why it fails when it fails, I have added the bufferedimage save. Regards Prasanta On 25-Jun-20 11:39 AM, Pankaj Bansal

Re: RFR 8248187: javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails with String is not properly drawn

2020-06-25 Thread Pankaj Bansal
Hello Prasanta, I see that you have saved the image before throwing a exception. Is this intentional or you were using it for debugging and forgot to remove it? Regards, Pankaj On 24/06/20 8:29 PM, Prasanta Sadhukhan wrote: Hi All, Please review a test only fix for an issue seen in

Re: RFR: 8246263: jdk is not yet ready for new Copyright line.

2020-06-01 Thread Pankaj Bansal
Looks good to me -Pankaj On 01/06/20 9:51 PM, Philip Race wrote: Urgent review needed  and fix to be pushed to jdk/jdk Apparently although we will "soon" be asked not to include the sentence " All rights reserved." in the copyright line of files this can't happen until various Oracle

Re: RFR: 8196094: [TESTBUG] Test javax/swing/JFileChooser/8002077/bug8002077.java fails

2020-06-01 Thread Pankaj Bansal
also modify invokeLater to invokeAndWait() to be more deterministic. Regards Prasanta On 30-May-20 11:25 PM, Pankaj Bansal wrote: Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8196094 webrev: http://cr.openjdk.java.net/~pbansal

RFR: 8198623: java/awt/KeyboardFocusmanager/TypeAhead/EnqueueWithDialogButtonTest/EnqueueWithDialogButtonTest.java fails on mac

2020-05-31 Thread Pankaj Bansal
Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8198623 webrev: http://cr.openjdk.java.net/~pbansal/8198623/webrev00/ These tests were added to the ProblemList as they were

RFR: 8196094: [TESTBUG] Test javax/swing/JFileChooser/8002077/bug8002077.java fails

2020-05-30 Thread Pankaj Bansal
Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8196094 webrev: http://cr.openjdk.java.net/~pbansal/8196094/webrev00 This test was added to the ProblemList as it was failing

RFR: 8245968: javax/swing/JTable/7124218/SelectEditTableCell.java is added to ProblemList twice

2020-05-27 Thread Pankaj Bansal
Hi All, Please review the following fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8245968 Patch: diff -r 083deccc617e test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt  Wed May 27 18:02:49 2020 +0530 +++ b/test/jdk/ProblemList.txt  Thu May 28 09:57:25 2020 +0530 @@

RFR: 8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS

2020-05-26 Thread Pankaj Bansal
Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233551 webrev: http://cr.openjdk.java.net/~pbansal/8233551/webrev00/ This test was added to the ProblemList as it was

FR: 8233566: [TESTBUG] KeyboardFocusManager tests failing on MacoS

2020-05-25 Thread Pankaj Bansal
Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233566 webrev: http://cr.openjdk.java.net/~pbansal/8233566/webrev/ These tests were added to the ProblemList as they were

RFR: 8233647: [TESTBUG] JColorChooser/Test8051548.java is failing on macos

2020-05-23 Thread Pankaj Bansal
Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233647 Patch: diff -r 0842c9b1bde9 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt  Sat May 23 13:27:09 2020 +0530 +++ b/test/jdk/ProblemList.txt  Sat May 23 18:18:37 2020 +0530

Re: RFR: 8233550: [TESTBUG] JTree tests fail regularly on MacOS

2020-05-22 Thread Pankaj Bansal
Hello Prasanta, Thanks for the review. I have made the suggested changes. webrev: http://cr.openjdk.java.net/~pbansal/8233550/webrev01/ Regards, Pankaj On 22/05/20 1:44 PM, Prasanta Sadhukhan wrote: I guess just to ensure these

Re: RFR: 8233559 [TESTBUG] TestNimbusOverride.java is failing on macos

2020-05-22 Thread Pankaj Bansal
v01/> Tested again in internal build and test system on all platforms and it is green. Links are in JBS Thanks and regards Tejpal On 19-May-2020, at 1:39 PM, Tejpal Rebari <mailto:tejpal.reb...@oracle.com>> wrote: Hi Pankaj, On 19-May-2020, at 9:52 AM, Pankaj Bansal mailto:pankaj.b.ba

RFR: 8233550: [TESTBUG] JTree tests fail regularly on MacOS

2020-05-22 Thread Pankaj Bansal
Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233550 Patch: diff -r dd652a1b2a39 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt  Sat May 09 09:49:08 2020 +0530 +++ b/test/jdk/ProblemList.txt  Fri May 22 12:59:08 2020 +0530

RFR: 8233552: [TESTBUG] JTable Test bug7068740.java fails on MacOS

2020-05-21 Thread Pankaj Bansal
Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233552 Patch: diff -r dd652a1b2a39 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt  Sat May 09 09:49:08 2020 +0530 +++ b/test/jdk/ProblemList.txt  Thu May 21 18:43:16 2020

Re: RFR: 8233635: [TESTBUG] ProgressMonitorEscapeKeyPress.java fails on macos

2020-05-21 Thread Pankaj Bansal
mach5 running this test on osx10.15. Did you verify in osx10.15? Regards Prasanta On 21-May-20 10:08 AM, Pankaj Bansal wrote: Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233635 Patch: diff -r dd652a1b2a39 test/jdk

RFR: 8233635: [TESTBUG] ProgressMonitorEscapeKeyPress.java fails on macos

2020-05-20 Thread Pankaj Bansal
Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233635 Patch: diff -r dd652a1b2a39 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt  Sat May 09 09:49:08 2020 +0530 +++ b/test/jdk/ProblemList.txt  Thu May 21 09:59:56 2020

Re: RFR: 8233559 [TESTBUG] TestNimbusOverride.java is failing on macos

2020-05-18 Thread Pankaj Bansal
<builds? Actually I meant to ask if you have tried to run the test in group with other tests. The test may be passing when run as individual test, but may again start failing when run in nightly after removing from ProblemList. On 18/05/20 10:48 PM, Pankaj Bansal wrote: I am not very s

Re: RFR: 8233559 [TESTBUG] TestNimbusOverride.java is failing on macos

2020-05-18 Thread Pankaj Bansal
I am not very sure if we should be removing tests from the ProblemList on basis of individual test runs. The test may be failing because of some other test and we should find the reason for the same. One quick question, is the test passing continuously now in nightly builds? Regards, Pankaj

Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue

2020-04-28 Thread Pankaj Bansal
lue is changed using textfield.  Also, this will be again changed a lot once we add support for changing the value via textfield change using the step/count. Regards, Pankaj On 16/04/20 4:48 PM, Sergey Bylokhov wrote: On 4/7/20 9:18 am, Pankaj Bansal wrote: << Probably I missed

Re: RFR JDK-8242526: PIT: javax/swing/JInternalFrame/8020708/bug8020708.java fails in mach5 ubuntu system

2020-04-13 Thread Pankaj Bansal
Look good to me -Pankaj On 11/04/20 9:46 PM, Prasanta Sadhukhan wrote: On 11-Apr-20 8:08 PM, Sergey Bylokhov wrote: Hi, Prasanta. Not sure that "waitForIdle()" should be removed at line 107, it waits till the moment the window became visible, and w/o it the Util.getCenterPoint may return

Re: RFR: 8152332 [macosx] JFileChooser cannot be serialized on Mac OS X

2020-04-12 Thread Pankaj Bansal
Looks good to me. One minor nit, don’t we need to add the current bug id to the test? -Pankaj -Original Message- From: Sergey Bylokhov Sent: Monday, March 16, 2020 2:06 PM To: Swing-Dev Subject: RFR: 8152332 [macosx] JFileChooser cannot be serialized on Mac OS X Hello. Please review

Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue

2020-04-07 Thread Pankaj Bansal
too many changes for this? Number base, expectedNewValue, newMinimum, newMaximum; int currentStep, positeveCount, negativeCount; I expected that we will have only one new "count" field, probably all changes are needed, I'll check closely. On 4/7/20 9:01 am, Pankaj Bansal wrote: > I t

Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue

2020-04-07 Thread Pankaj Bansal
ansal/8220811/webrev02/ Regards, Pankaj -Original Message- From: Volodin, Vladislav Sent: Sunday, March 15, 2020 2:03 AM To: Pankaj Bansal Cc: swing-dev@openjdk.java.net; Jason Mehrens ; Sergey Bylokhov ; Alexey Ivanov Subject: Re: [15] RFR JDK-8220811: SpinnerNumberModel floating po

Re: RFR: 8241228 Test jdk/javax/swing/UIDefaults/8146330/UIDefaultKeySizeTest.java is failing

2020-03-31 Thread Pankaj Bansal
Look good to me. On 30/03/20 11:22 AM, Tejpal Rebari wrote: Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8241228 Fix : http://cr.openjdk.java.net/~trebari/swing/8241228/webrev00/

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-22 Thread Pankaj Bansal
Ok, looks good to me.   -Pankaj   From: Prasanta Sadhukhan Sent: Monday, March 23, 2020 10:54 AM To: Pankaj Bansal ; swing-dev@openjdk.java.net Subject: Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java   I prefer it not to be deleted as we can still

Re: RFR JDK-8239312 [macos] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

2020-03-22 Thread Pankaj Bansal
Hello Prasanta,   If I am not wrong, now this test will be ignored on all versions of osx and since it is only meant for Mac, basically this will never be run after this change. Can’t we just delete the test?   Regards, Pankaj   From: Prasanta Sadhukhan Sent: Sunday, March 22, 2020 12:20

Re: RFR JDK-8236635: JTabbedPane preferred size calculation is wrong for SCROLL_TAB_LAYOUT

2020-03-16 Thread Pankaj Bansal
Looks good to me -Pankaj On 13/03/20 10:09 PM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen the frame height is different in ubuntu19.10 when it contains JTabbedPane with SCROLL_TAB_LAYOUT policy compared to WRAP_TAB_LAYOUT policy. Bug:

Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue

2020-03-14 Thread Pankaj Bansal
equals(Double.NaN)); //prints false Regards, Pankaj -Original Message- From: Jason Mehrens Sent: Saturday, March 14, 2020 8:09 PM To: Pankaj Bansal ; Sergey Bylokhov ; Alexey Ivanov ; Volodin, Vladislav Cc: swing-dev@openjdk.java.net Subject: Re: [15] RFR JDK-8220811: SpinnerNumberModel fl

Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue

2020-03-14 Thread Pankaj Bansal
lokhov Sent: Wednesday, March 11, 2020 5:33 AM To: Pankaj Bansal ; Alexey Ivanov ; Volodin, Vladislav Cc: swing-dev@openjdk.java.net Subject: Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue On 3/10/20 5:34 am, Pankaj Bansal wrote: > Hello Sergey/Vlad/Alexey, >

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

2020-03-13 Thread Pankaj Bansal
Looks good to me though the webrev02 was also good enough and easy to read as second case is anyway going to fail if first case fails. You can push webrev03 as well. Regards, Pankaj From: Tejpal Rebari Sent: Friday, March 13, 2020 4:31 PM To: Jayathirth D v Cc:

Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue

2020-03-10 Thread Pankaj Bansal
Hello Sergey/Vlad/Alexey, Sorry, I could not reply to this earlier. I have one doubt about this approach. Won't the calculation of stepCount itself suffer from floating point issue? I mean the user will pass min, max, stepsize, then wont the calculation of steps required to go from min to max

Re: RFR: 8240633 Memory leaks in the implementations of FileChooserUI

2020-03-10 Thread Pankaj Bansal
Hello Sergey, The changes look fine. Regards, Pankaj On 08/03/20 3:50 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-8240633 Fix: http://cr.openjdk.java.net/~serb/8240633/webrev.00 Our tests in mach5 for JFileChooser

Re: RFR: 8233584: [Win LAF] When navigating the contents of the file list changes in Win LAF

2020-03-09 Thread Pankaj Bansal
Hello Bhawesh, The product change looks good. As discussed in the internal review for moving the test to open from closed repo, please change the test name to a meaningful name and change the copyright year. Also, please follow max 80 characters per line convention. Regards, Pankaj

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

2020-03-09 Thread Pankaj Bansal
. Regards, Pankaj From: Tejpal Rebari Sent: Monday, March 9, 2020 5:33 AM To: Pankaj Bansal ; Sergey Bylokhov Cc: swing-dev@openjdk.java.net Subject: Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet() Hello Pankaj and Sergey, I have updated

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

2020-03-05 Thread Pankaj Bansal
Hello Tejpal, I think you need to iterate over the full "tables" array instead of just using the tables[0] as is being done in entrySet function in same class. Also, you need to create a copy of the key set like entrySet function instead of returning the original handle. Also, please follow

Re: [15] RFR JDK-8231042: [macos] JFileChooser creates new folder on ESC

2020-02-27 Thread Pankaj Bansal
when using jtreg to stop the test from running altogether. I have added the tag "@requires". Please have a look. webrev: http://cr.openjdk.java.net/~pbansal/8231042/webrev01/ Regards, Pankaj -Original Message- From: Sergey Bylokhov Sent: Thursday, February 27, 2020 4:32 PM To:

[15] RFR JDK-8239902: Remove direct usage of JSlider, JProgressBar classes in CAccessible class

2020-02-27 Thread Pankaj Bansal
not affect the functionality. This can be verified by running the JSliderDemo and JProgressBarDemo attached in JBS. Regards, Pankaj Bansal

[15] RFR JDK-8231042: [macos] JFileChooser creates new folder on ESC

2020-02-25 Thread Pankaj Bansal
create NewFolder Action for a Cancelled JOptionPane. I this case, no folder should be created. Regards, Pankaj Bansal

Re: RFR : JDK-8239334:Tab Size does not work correctly in JTextArea with setLineWrap on

2020-02-19 Thread Pankaj Bansal
Hello Prasanta, The fix looks good. I have couple of minor comments about the test. There is an indentation issue at line 59 You have imported classes like JScrollPane, JTextArea and while using them, you have used full path like javax.swing.JScrollPane, javax.swing.JTextArea etc. Regards,

Re: [15] RFR JDK-8216329: Cannot resize CheckBoxItemMenu in Synth L with setHorizontalTextPosition

2020-02-18 Thread Pankaj Bansal
: Prasanta Sadhukhan Sent: Tuesday, February 18, 2020 3:40 PM To: Pankaj Bansal ; swing-dev@openjdk.java.net Subject: Re: [15] RFR JDK-8216329: Cannot resize CheckBoxItemMenu in Synth L with setHorizontalTextPosition Looks ok to me. Only thing I have some doubt is "propertyChangeListener&quo

Re: [15] RFR JDK-8238985: [TESTBUG] The arrow image is blue instead of green

2020-02-17 Thread Pankaj Bansal
Hi Prasanta, Thanks for the review. Yes, I meant that only. Regards, Pankaj From: Prasanta Sadhukhan Sent: Tuesday, February 18, 2020 12:49 PM To: Pankaj Bansal ; swing-dev@openjdk.java.net Subject: Re: [15] RFR JDK-8238985: [TESTBUG] The arrow image is blue instead of green

[15] RFR JDK-8238985: [TESTBUG] The arrow image is blue instead of green

2020-02-17 Thread Pankaj Bansal
ld have been updated later when blue image was used. Fix is to update instruction that blue arrow image will be shown. Regards, Pankaj Bansal

[15] RFR JDK-8153090: TAB key cannot change input focus after the radio button in the Color Selection dialog

2020-02-16 Thread Pankaj Bansal
works fine for JColorChooser. The fix can be verified by running SwingSet2 demo and using the JColorChooser demo. I have tested this on Windows, Mac and Linux. Regards, Pankaj Bansal

Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue

2020-02-11 Thread Pankaj Bansal
a+b*c. Regards, Pankaj -Original Message- From: Sergey Bylokhov Sent: Wednesday, February 12, 2020 1:09 PM To: Pankaj Bansal ; swing-dev@openjdk.java.net Subject: Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue > I am not able to find any issue with this

Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue

2020-02-11 Thread Pankaj Bansal
SpinnerNumberModel. So they will use primitive floats directly and run into these issues. As I suggested earlier, either we should remove constructors with primitive double or add constructor for primitive float. Regards, Pankaj Bansal -Original Message- From: Sergey Bylokhov Sent: Wednesday,

Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue

2020-02-11 Thread Pankaj Bansal
lue, int minimum, int maximum, int stepSize) Regards, Pankaj -Original Message- From: Sergey Bylokhov Sent: Tuesday, February 11, 2020 7:47 AM To: Pankaj Bansal ; swing-dev@openjdk.java.net Subject: Re: [15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue Hi, Pankaj.

[15] RFR JDK-8220811: SpinnerNumberModel floating point rounding issue

2020-02-07 Thread Pankaj Bansal
will need CSR, I will get to it after the review is completed here. Regards, Pankaj Bansal

Re: [15] RFR JDK-8216329: Cannot resize CheckBoxItemMenu in Synth L with setHorizontalTextPosition

2020-02-05 Thread Pankaj Bansal
Hello Vlad, Thanks for the review. <mailto:vladislav.volo...@sap.com] Sent: Wednesday, February 5, 2020 6:56 PM To: Pankaj Bansal Cc: swing-dev@openjdk.java.net Subject: RE: [15] RFR JDK-8216329: Cannot resize CheckBoxItemMenu in Synth L with setHorizontalTextPosition Hello Pankaj,

Re: [15] RFR JDK-8216329: Cannot resize CheckBoxItemMenu in Synth L with setHorizontalTextPosition

2020-02-05 Thread Pankaj Bansal
Hello Sergey, << ok. <http://cr.openjdk.java.net/~pbansal/8216329/webrev02/ Regards, Pankaj -Original Message- From: Sergey Bylokhov Sent: Thursday, January 30, 2020 5:59 AM To: Pankaj Bansal ; swing-dev@openjdk.java.net Subject: Re: [15] RFR JDK-8216329: Cann

Re: [15] RFR JDK-8216329: Cannot resize CheckBoxItemMenu in Synth L with setHorizontalTextPosition

2020-01-29 Thread Pankaj Bansal
is not possible to reproduce JDK-8152981 even if the test is modified in some way? < [15] RFR JDK-8216329: Cannot resize CheckBoxItemMenu in Synth L with setHorizontalTextPosition On 1/28/20 4:33 pm, Sergey Bylokhov wrote: > On 1/27/20 7:15 am, Pankaj Bansal wrote: >> << It is not a

Re: [15] RFR JDK-8216329: Cannot resize CheckBoxItemMenu in Synth L with setHorizontalTextPosition

2020-01-29 Thread Pankaj Bansal
1/27/20 7:15 am, Pankaj Bansal wrote: >> << It is not a big issue, but for such a fix we will need a proper >> specification and CSR, it is like adding a new method to the public class. >> It is preferable to try to fix it in some other way first. >> I did not reali

Re: [15] RFR JDK-8216329: Cannot resize CheckBoxItemMenu in Synth L with setHorizontalTextPosition

2020-01-27 Thread Pankaj Bansal
Hello Sergey, <http://cr.openjdk.java.net/~pbansal/8216329/webrev01/ [1] https://bugs.openjdk.java.net/browse/JDK-8152981 Regards, Pankaj -Original Message- From: Sergey Bylokhov Sent: Monday, January 27, 2020 1:15 PM To: Pankaj Bansal; swing-dev@openjdk.java.net Subject: Re: [15]

Re: [15] RFR JDK-8216329: Cannot resize CheckBoxItemMenu in Synth L with setHorizontalTextPosition

2020-01-26 Thread Pankaj Bansal
52981/webrev.00/ Regards, Pankaj -Original Message- From: Sergey Bylokhov Sent: Friday, January 24, 2020 5:55 AM To: Pankaj Bansal; swing-dev@openjdk.java.net Subject: Re: [15] RFR JDK-8216329: Cannot resize CheckBoxItemMenu in Synth L with setHorizontalTextPosition

[15] RFR JDK-8216329: Cannot resize CheckBoxItemMenu in Synth L with setHorizontalTextPosition

2020-01-23 Thread Pankaj Bansal
for [1] to Windows L specific code. This fixes the current issue. I have run the tests that was added for [1]. All works fine. [1] https://bugs.openjdk.java.net/browse/JDK-8152981 Regards, Pankaj Bansal

Re: [14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key

2020-01-12 Thread Pankaj Bansal
Hello Tejpal, I have few minor comments. You can fix them before pushing this fix. 1. Import individual packages instead of import javax.swing.*. 2. You don't need to create editor1 variable. 3. There should be space after comma editor1,editor2. 4. Rename variables JTextField_Focus_Status, LF

[15] RFR JDK-8224475: JTextPane does not show images in HTML rendering

2020-01-01 Thread Pankaj Bansal
Adding proper subject missed in initial mail by mistake. -Pankaj From: Pankaj Bansal Sent: Thursday, January 2, 2020 12:34 PM To: swing-dev@openjdk.java.net Subject: Hi All, Please review the following test only fix for jdk15. Bug: https://bugs.openjdk.java.net/browse/JDK

(no subject)

2020-01-01 Thread Pankaj Bansal
://bugs.openjdk.java.net/browse/JDK-8218674 [5] https://bugs.openjdk.java.net/browse/JDK-8230235 Regards, Pankaj Bansal

Re: [15] RFR JDK-8222759: com.sun.java.swing.plaf.gtk.GTKLookAndFeel Unneccessary casts to GTKStyleFactory

2019-12-22 Thread Pankaj Bansal
Hi Jay,   I have done the changes you suggested. webrev: http://cr.openjdk.java.net/~pbansal/8222759/webrev01/   Regards, Pankaj   From: Jayathirth D v Sent: Monday, December 23, 2019 12:08 PM To: Pankaj Bansal Cc: swing-dev@openjdk.java.net Subject: Re: [15] RFR JDK-8222759

[15] RFR JDK-8222759: com.sun.java.swing.plaf.gtk.GTKLookAndFeel Unneccessary casts to GTKStyleFactory

2019-12-19 Thread Pankaj Bansal
Regards, Pankaj Bansal

Re: [13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

2019-12-18 Thread Pankaj Bansal
Hi Phil, I have made the change you suggested. Please have a look. webrev: http://cr.openjdk.java.net/~pbansal/8234733/webrev03/ Regards, Pankaj From: Phil Race Sent: Wednesday, December 18, 2019 12:20 AM To: Pankaj Bansal; Prasanta Sadhukhan Cc: swing-dev@openjdk.java.net Subject

Re: [15] RFR JDK-8235744: PIT: test/jdk/javax/swing/text/html/TestJLabelWithHTMLText.java times out in linux-x64

2019-12-11 Thread Pankaj Bansal
approved, so it does not interfere with JDK 14 final testing. Can't this be tested with a file: URL ? What are other similar tests using ? -phil. On 12/11/19 2:45 AM, Pankaj Bansal wrote: Hi All, Please review the following test only fix for jdk15. Bug: https://bugs.openjdk.java.net/brows

[15] RFR JDK-8235744: PIT: test/jdk/javax/swing/text/html/TestJLabelWithHTMLText.java times out in linux-x64

2019-12-11 Thread Pankaj Bansal
verified that after making this change, the test passes with the fix done in https://bugs.openjdk.java.net/browse/JDK-8230235 and fails without the fix. Testing: I have run this on local machines on network which required proxy to access internet. I have also ran a mach5 job and it is working fine. Regards, Pankaj Bansal

Re: [14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key

2019-12-05 Thread Pankaj Bansal
Looks good to me Regards, Pankaj From: Prasanta Sadhukhan Sent: Thursday, December 5, 2019 3:38 PM To: Tejpal Rebari; swing-dev@openjdk.java.net Subject: Re: [14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key +1 but you need to

Re: [13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

2019-12-05 Thread Pankaj Bansal
Hello Prasanta, I have made the changes suggested by you. webrev: http://cr.openjdk.java.net/~pbansal/8234733/webrev02/ Regards, Pankaj Bansal From: Prasanta Sadhukhan Sent: Wednesday, December 4, 2019 12:58 PM To: Pankaj Bansal; Philip Race Cc: swing-dev@openjdk.java.net Subject

Re: [13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

2019-12-03 Thread Pankaj Bansal
x. After the fix, there is a change in rendering to show pressed state of button. Regards, Pankaj -Original Message- From: Sergey Bylokhov Sent: Tuesday, December 3, 2019 4:05 AM To: Pankaj Bansal; Philip Race; Prasanta Sadhukhan Cc: swing-dev@openjdk.java.net Subject: Re: [13] RFR JDK-8

Re: [13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

2019-12-02 Thread Pankaj Bansal
so we probably need a regression test, even manual, for this. Regards Prasanta On 25-Nov-19 4:13 PM, Pankaj Bansal wrote: Hi All, Please review the following fix for jdk14. Bug: https://bugs.openjdk.java.net/browse/JDK-8234733 webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epban

[13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

2019-11-25 Thread Pankaj Bansal
is attached in the JBS) and it has to be verified manually. I have verified this on Ubuntu 18.04, 19.04, 19.10 and OEL 7.5. The issue is solved on all platforms. Regards, Pankaj Bansal

Re: [14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cause Exception

2019-11-21 Thread Pankaj Bansal
lso made the formatting changes Alexey had asked for. Webrev: http://cr.openjdk.java.net/~pbansal/8230235/webrev04/ Regards, Pankaj -Original Message- From: Sergey Bylokhov Sent: Thursday, November 21, 2019 1:54 PM To: Pankaj Bansal; Alexey Ivanov; swing-dev Subject: Re: [14] RFR J

Re: [14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cause Exception

2019-11-18 Thread Pankaj Bansal
webrev: http://cr.openjdk.java.net/~pbansal/8230235/webrev03/ Regards, Pankaj -Original Message- From: Alexey Ivanov Sent: Monday, November 18, 2019 6:22 PM To: Pankaj Bansal; Sergey Bylokhov; swing-dev Subject: Re: [14] RFR JDK-8230235 - Rendering HTML with empty img att

Re: [14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cause Exception

2019-11-18 Thread Pankaj Bansal
ag from the test as it is headless test. I > added it by mistake earlier. I wonder whether the test runs correctly in headless environment. You're creating a Swing component. No, you don't show it on the screen, but still… Regards, Alexey On 18/11/2019 11:50, Pankaj Bansal wrote: > Hi Sergey/

Re: [14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cause Exception

2019-11-18 Thread Pankaj Bansal
{ This will not be needed now as we are using the local variable. < tag should not be closed as in XML. I mean should be <http://cr.openjdk.java.net/~pbansal/8230235/webrev02/ Regards, Pankaj -Original Message- From: Alexey Ivanov Sent: Wednesday, November 13, 2019 1:28 AM To: S

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-11 Thread Pankaj Bansal
Looks good to me   -Pankaj   From: Prasanta Sadhukhan Sent: Tuesday, November 12, 2019 11:30 AM To: Tejpal Rebari; Pankaj Bansal Cc: swing-dev@openjdk.java.net Subject: Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()   Please remove ununsed

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-10 Thread Pankaj Bansal
The fix look good to me. Some points about test case. 1.  No need for author tag. This is not followed now. 2.  The test case name should be something meaningful instead of bug***. 3.  You should not need the GridBagConstraints code anywhere to reproduce the issue.  You should

Re: [14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cause Exception

2019-10-31 Thread Pankaj Bansal
"image". > Also, it is not necessary to have a try/catch block in the test, just > call the problematic method > > On 10/10/19 11:01 am, Pankaj Bansal wrote: >> Hi All, >> >> Please review the following fix for jdk14. >> >> >> B

[14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cause Exception

2019-10-10 Thread Pankaj Bansal
is null and adds the ImageObserver (ImageView.ImageHandler) on the Image and sets the ImageView image as null. When getHeight is called, as image is set to null, it results in NPE. We should verify that image is not null. Testing: I have tested it on Window, Linux and Mac. Regards, Pankaj

Re: [14] RFR : JDK-4949105 : Access Bridge lacks html tags parsing

2019-10-01 Thread Pankaj Bansal
Hi Ambarish, The changes look fine to me. The characters in one line are going beyond 80. Please rectify that. Regards, Pankaj From: Ambarish Rapte Sent: Tuesday, September 24, 2019 10:16 PM To: swing-dev@openjdk.java.net Subject: [14] RFR : JDK-4949105 : Access Bridge lacks

Re: [13] RFR JDK-8226964 [Yaru] - GTK L: There is no difference between menu selected and de-selected

2019-08-02 Thread Pankaj Bansal
Hi Kevin, I have tested this with various color combinations and results were fine. Regards, Pankaj From: Kevin Rushforth Sent: Friday, August 2, 2019 9:32 PM To: Pankaj Bansal; Philip Race; swing-dev@openjdk.java.net Subject: Re: [13] RFR JDK-8226964 [Yaru] - GTK L

Re: [13] RFR JDK-8226964 [Yaru] - GTK L: There is no difference between menu selected and de-selected

2019-08-02 Thread Pankaj Bansal
/8226964/webrev03/ Regards, Pankaj From: Kevin Rushforth Sent: Friday, August 2, 2019 3:47 AM To: Philip Race; Pankaj Bansal Cc: swing-dev@openjdk.java.net Subject: Re: [13] RFR JDK-8226964 [Yaru] - GTK L: There is no difference between menu selected and de-selected The conversion

Re: [13] RFR JDK-8226964 [Yaru] - GTK L: There is no difference between menu selected and de-selected

2019-08-01 Thread Pankaj Bansal
rev02/ Regards, Pankaj From: Philip Race Sent: Thursday, August 1, 2019 10:24 PM To: Pankaj Bansal Cc: swing-dev@openjdk.java.net Subject: Re: [13] RFR JDK-8226964 [Yaru] - GTK L: There is no difference between menu selected and de-selected I am not sure about the logic in the if

Re: [13] RFR JDK-8226964 [Yaru] - GTK L: There is no difference between menu selected and de-selected

2019-08-01 Thread Pankaj Bansal
Hi Phil, << nit pick : you spelled luminance wrong here : <http://cr.openjdk.java.net/~pbansal/8226964/webrev01/ Regards, Pankaj From: Philip Race Sent: Thursday, August 1, 2019 6:16 AM To: Pankaj Bansal Cc: swing-dev@openjdk.java.net Subject: Re: [13] RFR JDK-8226964 [Yaru

  1   2   >