Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

+1 Regards Prasanta On 9/15/2017 3:16 PM, Shashidhara Veerabhadraiah wrote: Hi Prasanta, Please find the updated Webrev @ http://cr.openjdk.java.net/~sveerabhadra/8004029/webrev.05/ Thanks and regards, Shashi *From:*Prasanta

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

Hi Prasanta, Please find the updated Webrev @ http://cr.openjdk.java.net/~sveerabhadra/8004029/webrev.05/   Thanks and regards, Shashi   From: Prasanta Sadhukhan Sent: Friday, September 15, 2017 3:11 PM To: Shashidhara Veerabhadraiah ;

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

looks better. but, disposeUI() do not throw any exception so no need to catch in try { 122 if(test != null) { 123 test.disposeUI(); 124 } 125 } catch (Exception ex) { 126 throw new RuntimeException("Exception while disposing UI"); 127 } Regards Prasanta On 9/15/2017 2:57 PM,

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

Hi, Here is the updated webrev. Removed unnecessary try catch blocks!!   http://cr.openjdk.java.net/~sveerabhadra/8004029/webrev.04/   Thanks and regards, Shashi   From: Prasanta Sadhukhan Sent: Thursday, September 14, 2017 4:26 PM To: Shashidhara Veerabhadraiah

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

One more thing I noticed 106 } catch (Exception e) { 107 throw new RuntimeException(e); 108 } 109 110 // disposing the frame 111 SwingUtilities.invokeAndWait(() -> { 112 frame.dispose(); 113 }); if there is any exception thrown as above, then we are not going to

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

Hi Prasanta, Here is the updated Webrev.   http://cr.openjdk.java.net/~sveerabhadra/8004029/webrev.03/   Please note that I have not done the 2nd change(disposeUI() case) as this is required for the time out case where in the testresult had been initialized with false and would call the

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

Few observations on test: init() needs to be called under EDT you are calling disposeUI() in line 233, so it seems there is no need calling again in line122 Regards Prasanta On 9/12/2017 12:54 AM, Sergey Bylokhov wrote: Looks fine. On 9/11/17 01:34, Shashidhara Veerabhadraiah wrote: Hi, I

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

Looks fine. On 9/11/17 01:34, Shashidhara Veerabhadraiah wrote: Hi, I have updated the webrev to indicate the removal of a file which is not required anymore owing to the change in test from appletviewer based to standard java execution. This is only for the reference.

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

Hi, I have updated the webrev to indicate the removal of a file which is not required anymore owing to the change in test from appletviewer based to standard java execution. This is only for the reference. http://cr.openjdk.java.net/~sveerabhadra/8004029/webrev.02/ Thanks and regards, Shashi

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

Right Sergey. I was not sure on how to represent it under this Webrev. I will update the Webrev if need be. Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Saturday, September 9, 2017 7:33 AM To: Shashidhara Veerabhadraiah

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

Hi, Shashi. The fix looks fine, but it looks like bug4310381.html should be removed because it is not used? On 9/4/17 02:33, Shashidhara Veerabhadraiah wrote: Hi All, Please find the updated Webrev at the below link. http://cr.openjdk.java.net/~sveerabhadra/8004029/webrev.01/ I have added a

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

Hi All, Please find the updated Webrev at the below link. http://cr.openjdk.java.net/~sveerabhadra/8004029/webrev.01/ I have added a new test that would go through different laf's and runs the test of the tab titles. Previously this test had been a single default laf test with

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

Fix looks good. But, can you update test/javax/swing/JTabbedPane/4310381/bug4310381.java to include the test for all installed l so that we can see if there is problem in any other l? Regards Prasanta On 8/17/2017 2:08 PM, Shashidhara Veerabhadraiah wrote: Hi All, Please review a fix for

[10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

Hi All, Please review a fix for the JDK- 8004029 where the long tab titles were not clipped with the dots at the end to indicate a lengthy title. The aqua look and feel which is the default laf for mac does the title clipping only leading to an ambiguous UI where in the clipped title would look