Thanks Alex and Andrej for a feedback.
I have created an updated CSR for this.
https://bugs.openjdk.java.net/browse/JDK-8191167
On 09/11/2017 23:04, Andrej Golovnin wrote:
Hi Sergey,
the order of modifiers is wrong. It should be "protected transient
volatile". See
http://cr.openjdk.java.net/~a
Hi Sergey,
the order of modifiers is wrong. It should be "protected transient
volatile". See
http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html#toc-modifiers
for details.
Best regards,
Andrej Golovnin
On Fri, Oct 27, 2017 at 1:18 AM, Sergey Bylokhov
wrote:
> Hello,
> Please review
looks fine to me.
Thanks,
Alexander.
On 10/27/2017 04:48 AM, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk10.
The EventListenerList class was implemented to be thread safe. To
achieve the correct state of the object:
- two mutators(add/remove) were marked as synchronized.
-
Hello,
Please review the fix for jdk10.
The EventListenerList class was implemented to be thread safe. To
achieve the correct state of the object:
- two mutators(add/remove) were marked as synchronized.
- the internal array is updated via copy-on-write, the internal array
is never modified a