Hi Phil,
I have made the change you suggested. Please have a look.
webrev: http://cr.openjdk.java.net/~pbansal/8234733/webrev03/
Regards,
Pankaj
From: Phil Race
Sent: Wednesday, December 18, 2019 12:20 AM
To: Pankaj Bansal; Prasanta Sadhukhan
Cc: swing-dev@openjdk.java.net
Subject:
66
UIManager.setLookAndFeel("com.sun.java.swing.plaf.gtk.GTKLookAndFeel");
I think it would be better here to do something like what we have
in javax/swing/JComboBox/7082443/bug7082443.java
Eg :
public static final String GTK_LAF_CLASS = "GTKLookAndFeel";
for
looks good to me.
Regards
Prasanta
On 05-Dec-19 3:23 PM, Pankaj Bansal wrote:
Hello Prasanta,
I have made the changes suggested by you.
webrev: http://cr.openjdk.java.net/~pbansal/8234733/webrev02/
Regards,
Pankaj Bansal
*From:*Prasanta Sadhukhan
*Sent:* Wednesday, December 4, 2019
Hello Prasanta,
I have made the changes suggested by you.
webrev: http://cr.openjdk.java.net/~pbansal/8234733/webrev02/
Regards,
Pankaj Bansal
From: Prasanta Sadhukhan
Sent: Wednesday, December 4, 2019 12:58 PM
To: Pankaj Bansal; Philip Race
Cc: swing-dev@openjdk.java.net
Subject:
Hi Pankaj,
Some comments about the test:
I guess since we are testing for Platform.isLinux() in the test, there's
no need of "requires" tag. But, I think it's better to use
|System.getProperty("os.name") so that this test can be run in
standalone mode also(without using Platform class),
Hi Sergey,
<<"this behavior happens in native spinner" means after our the fix or before
the fix?
I meant after the fix. In native, when we press the up/down button, there is
change in rendering to show the pressed state. This is not being done in our
code before the fix. After the fix, there
On 12/2/19 3:15 am, Pankaj Bansal wrote:
<< Does it mean that this is the behavior of the gtk3 native spinner component?
Yes, this behavior happens in native spinner. This change makes our Spinner
much more similar to native gtk3 spinner
"this behavior happens in native spinner" means after
Hello Prasanta/Phil/Sergey,
<<1) I suppose this fix is for 14, not 13.
Yes, that was by mistake. I am not changes the subject line, as this would
create separate mail thread. This will be pushed to 14 only.
2) It is "OL", not "OEL"
Ok.
3) Can we create a reliable automated test for this ?
On 11/25/19 2:43 am, Pankaj Bansal wrote:
In GTKL, the spinner’s up/down buttons are drawn in same way whether the
button is pressed or not. We can't distinguish visually whether a button is pressed
or not. The buttons should be highlighted when they are in pressed state. The issue
is due
1) I suppose this fix is for 14, not 13.
2) It is "OL", not "OEL"
3) Can we create a reliable automated test for this ?
If not we should at least create a manual one.
4) A separate issue but we should consider adding a JSpinner demo to
SwingSet2
-phil.
On 11/27/19, 2:31 AM, Prasanta
It works for oel8 too. So the fix looks fine to me.
Regards
Prasanta
On 27-Nov-19 3:54 PM, Prasanta Sadhukhan wrote:
Hi Pankaj,
I can see the issue resolved in ubuntu18.04 but not in OEL8. Also,
SwingSet2 does not have JSpinner demo so we cannot put noreg-demo in
JBS, so we probably need
Hi Pankaj,
I can see the issue resolved in ubuntu18.04 but not in OEL8. Also,
SwingSet2 does not have JSpinner demo so we cannot put noreg-demo in
JBS, so we probably need a regression test, even manual, for this.
Regards
Prasanta
On 25-Nov-19 4:13 PM, Pankaj Bansal wrote:
Hi All,
Hi All,
Please review the following fix for jdk14.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8234733
webrev:
http://cr.openjdk.java.net/~pbansal/8234733/webrev00/
Issue:
In GTKL, the spinner's up/down buttons are drawn in same way whether the
button is pressed or not. We
13 matches
Mail list logo
