Re: [9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

2016-10-19 Thread Semyon Sadetsky
+1 --Semyon On 9/23/2016 4:14 PM, Sergey Bylokhov wrote: Looks fine. Please file a bug to update the code related to scrollbars. They looks different from the x1 version(take a look to the borders and buttons). On 09.09.16 9:07, Andrej Golovnin wrote: Hi Alexandr, this looks much better

Re: [9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

2016-09-09 Thread Andrej Golovnin
Hi Alexandr, this looks much better now. Thanks! Best regards, Andrej Golovnin On Thu, Sep 8, 2016 at 9:52 PM, Alexandr Scherbatiy wrote: > > Hello, > > Could you review the updated fix: > http://cr.openjdk.java.net/~alexsch/8165485/webrev.02 > > - shadow

Re: [9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

2016-09-08 Thread Alexandr Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8165485/webrev.02 - shadow lines are updated - round line end decoration is changed to draw just a point [1], [2], and [3] screenshots show difference between icons drawing before and after the fix for scales

Re: [9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

2016-09-07 Thread Alexandr Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8165485/webrev.01 Round line end decoration is used to draw combo box and scroll bar icons. [1], [2], and [3] screenshots show difference between icons drawing before and after the fix for scales 1x, 2x, and 4x.

Re: [9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

2016-09-07 Thread Phil Race
drawPolyline does not seem to be an option here because of the different colours. Filling custom shapes may be overkill. Round looks to me to be the best of these three. -phil. On 9/7/2016 9:19 AM, Alexandr Scherbatiy wrote: On 9/6/2016 6:10 PM, Sergey Bylokhov wrote: It seems that there

Re: [9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

2016-09-07 Thread Alexandr Scherbatiy
On 9/6/2016 6:10 PM, Sergey Bylokhov wrote: It seems that there are some small artifacts on some of the components, please take a look to the corners of the selected checkbox. In 1x the corners have correct edges but in x2,x4 there are some missing pixels. Similar issue is in the text

Re: [9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

2016-09-06 Thread Sergey Bylokhov
It seems that there are some small artifacts on some of the components, please take a look to the corners of the selected checkbox. In 1x the corners have correct edges but in x2,x4 there are some missing pixels. Similar issue is in the text area(take a look to the white border). On 06.09.16

[9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

2016-09-06 Thread Alexandr Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8165485 webrev: http://cr.openjdk.java.net/~alexsch/8165485/webrev.00 The icons drawing is changed to use ovals and polygons for JRadioButton, JCheckBox, JComboBox, and JScrollBar. The screenshots [1],